From: Dan Carpenter <error27@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 11/11] btrfs: The file argument for fsync() is never
Date: Mon, 14 Jun 2010 21:11:20 +0000 [thread overview]
Message-ID: <20100614211120.GB5483@bicker> (raw)
In-Reply-To: <20100614205849.GA26828@lst.de>
On Mon, Jun 14, 2010 at 10:58:49PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 10:07:23PM +0200, Johannes Hirte wrote:
> > I think you're wrong here. I've run into a kernel null pointer dereference at
> > this point with a NFS exported btrfs filesystem:
>
> Looks like you've applied the patch to a far too old kernel. It can't
> be NULL for quite a while already.
>
You're the expert, but it looks like it could be null in 2.6.34 like he
says. I'm just looking at vfs_fsync_range() in
"git show v2.6.34:fs/sync.c".
> If you're testing patches posted to the mailinglists always make sure
> you have a recent enough kernel.
This actually was merged into the btrfs and the kernel.org trees
already.
I'm not sure how the btrfs backports work...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 11/11] btrfs: The file argument for fsync() is never null
Date: Mon, 14 Jun 2010 23:11:20 +0200 [thread overview]
Message-ID: <20100614211120.GB5483@bicker> (raw)
In-Reply-To: <20100614205849.GA26828@lst.de>
On Mon, Jun 14, 2010 at 10:58:49PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 10:07:23PM +0200, Johannes Hirte wrote:
> > I think you're wrong here. I've run into a kernel null pointer dereference at
> > this point with a NFS exported btrfs filesystem:
>
> Looks like you've applied the patch to a far too old kernel. It can't
> be NULL for quite a while already.
>
You're the expert, but it looks like it could be null in 2.6.34 like he
says. I'm just looking at vfs_fsync_range() in
"git show v2.6.34:fs/sync.c".
> If you're testing patches posted to the mailinglists always make sure
> you have a recent enough kernel.
This actually was merged into the btrfs and the kernel.org trees
already.
I'm not sure how the btrfs backports work...
regards,
dan carpenter
next prev parent reply other threads:[~2010-06-14 21:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 9:49 [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-05-29 9:49 ` Dan Carpenter
2010-06-14 20:07 ` Johannes Hirte
2010-06-14 20:07 ` Johannes Hirte
2010-06-14 20:49 ` [patch 11/11] btrfs: The file argument for fsync() is never Dan Carpenter
2010-06-14 20:49 ` [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-06-14 20:58 ` Christoph Hellwig
2010-06-14 20:58 ` Christoph Hellwig
2010-06-14 21:11 ` Dan Carpenter [this message]
2010-06-14 21:11 ` Dan Carpenter
2010-06-14 21:16 ` Christoph Hellwig
2010-06-14 21:16 ` Christoph Hellwig
2010-06-14 21:45 ` Johannes Hirte
2010-06-14 21:45 ` Johannes Hirte
2010-06-15 0:08 ` [patch 11/11] btrfs: The file argument for fsync() is never Chris Mason
2010-06-15 0:08 ` [patch 11/11] btrfs: The file argument for fsync() is never null Chris Mason
2010-06-16 18:04 ` Johannes Hirte
2010-06-16 18:04 ` Johannes Hirte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614211120.GB5483@bicker \
--to=error27@gmail.com \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=josef@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.