From: Chris Mason <chris.mason@oracle.com>
To: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Cc: Christoph Hellwig <hch@lst.de>, Dan Carpenter <error27@gmail.com>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 11/11] btrfs: The file argument for fsync() is never
Date: Tue, 15 Jun 2010 00:08:20 +0000 [thread overview]
Message-ID: <20100614220804.GM18266@think> (raw)
In-Reply-To: <201006142345.42014.johannes.hirte@fem.tu-ilmenau.de>
On Mon, Jun 14, 2010 at 11:45:40PM +0200, Johannes Hirte wrote:
> Am Montag 14 Juni 2010, 23:16:01 schrieb Christoph Hellwig:
> > On Mon, Jun 14, 2010 at 11:11:20PM +0200, Dan Carpenter wrote:
> > > > Looks like you've applied the patch to a far too old kernel. It can't
> > > > be NULL for quite a while already.
> > >
> > > You're the expert, but it looks like it could be null in 2.6.34 like he
> > > says. I'm just looking at vfs_fsync_range() in
> > > "git show v2.6.34:fs/sync.c".
> >
> > 2.6.34 is far too old.
>
> For the changes yes, but not for working. I needed the btrfs fixes without all
> the other bugs introduced with 2.6.35-rc. I was to careless and pulled to much
> changes in. My fault.
Well, my fault. I usually keep the btrfs-unstable tree against one
release old, and the users have come to expect it.
I'll make a .34 branch that works.
-chris
WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Cc: Christoph Hellwig <hch@lst.de>, Dan Carpenter <error27@gmail.com>,
linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 11/11] btrfs: The file argument for fsync() is never null
Date: Mon, 14 Jun 2010 20:08:20 -0400 [thread overview]
Message-ID: <20100614220804.GM18266@think> (raw)
In-Reply-To: <201006142345.42014.johannes.hirte@fem.tu-ilmenau.de>
On Mon, Jun 14, 2010 at 11:45:40PM +0200, Johannes Hirte wrote:
> Am Montag 14 Juni 2010, 23:16:01 schrieb Christoph Hellwig:
> > On Mon, Jun 14, 2010 at 11:11:20PM +0200, Dan Carpenter wrote:
> > > > Looks like you've applied the patch to a far too old kernel. It can't
> > > > be NULL for quite a while already.
> > >
> > > You're the expert, but it looks like it could be null in 2.6.34 like he
> > > says. I'm just looking at vfs_fsync_range() in
> > > "git show v2.6.34:fs/sync.c".
> >
> > 2.6.34 is far too old.
>
> For the changes yes, but not for working. I needed the btrfs fixes without all
> the other bugs introduced with 2.6.35-rc. I was to careless and pulled to much
> changes in. My fault.
Well, my fault. I usually keep the btrfs-unstable tree against one
release old, and the users have come to expect it.
I'll make a .34 branch that works.
-chris
next prev parent reply other threads:[~2010-06-15 0:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 9:49 [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-05-29 9:49 ` Dan Carpenter
2010-06-14 20:07 ` Johannes Hirte
2010-06-14 20:07 ` Johannes Hirte
2010-06-14 20:49 ` [patch 11/11] btrfs: The file argument for fsync() is never Dan Carpenter
2010-06-14 20:49 ` [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-06-14 20:58 ` Christoph Hellwig
2010-06-14 20:58 ` Christoph Hellwig
2010-06-14 21:11 ` [patch 11/11] btrfs: The file argument for fsync() is never Dan Carpenter
2010-06-14 21:11 ` [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-06-14 21:16 ` Christoph Hellwig
2010-06-14 21:16 ` Christoph Hellwig
2010-06-14 21:45 ` Johannes Hirte
2010-06-14 21:45 ` Johannes Hirte
2010-06-15 0:08 ` Chris Mason [this message]
2010-06-15 0:08 ` Chris Mason
2010-06-16 18:04 ` Johannes Hirte
2010-06-16 18:04 ` Johannes Hirte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614220804.GM18266@think \
--to=chris.mason@oracle.com \
--cc=error27@gmail.com \
--cc=hch@lst.de \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=josef@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.