From: Jan Pogadl <pogadl.jan@googlemail.com>
To: Alex Chiang <achiang@canonical.com>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [BUG, REGRESSION] ACPI: Set _PDC
Date: Thu, 17 Jun 2010 09:51:26 +0200 [thread overview]
Message-ID: <201006170951.26455.pogadl.jan@googlemail.com> (raw)
In-Reply-To: <20100617032413.GC2138@canonical.com>
On Thursday 17 June 2010 05:24:14 Alex Chiang wrote:
> > with commit commit 5d554a7bb0643a6151a84319bfeba8270bf5269e (ACPI: processor:
> > add internal processor_physically_present()) a new function got introduced which
> > always fails on machines with CONFIG_SMP disabled. Thus _PDC will never be
> > initialized? set?.
> Does this patch fix it?
works great
thanks
> ---
> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index 5128435..bcf0cf8 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -223,7 +223,7 @@ static bool processor_physically_present(acpi_handle handle)
> type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0;
> cpuid = acpi_get_cpuid(handle, type, acpi_id);
>
> - if (cpuid == -1)
> + if ((cpuid == -1) && (num_online_cpus() > 1))
> return false;
>
> return true;
>
next prev parent reply other threads:[~2010-06-17 7:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 22:40 [BUG, REGRESSION] ACPI: Set _PDC Jan Pogadl
2010-06-17 3:24 ` Alex Chiang
2010-06-17 7:51 ` Jan Pogadl [this message]
2010-06-17 7:56 ` Chen Gong
2010-06-17 14:54 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006170951.26455.pogadl.jan@googlemail.com \
--to=pogadl.jan@googlemail.com \
--cc=achiang@canonical.com \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.