Re: [BUG, REGRESSION] ACPI: Set _PDC

[Chen Gong <gong.chen@linux.intel.com>]

于 6/17/2010 3:51 PM, Jan Pogadl 写道:
> On Thursday 17 June 2010 05:24:14 Alex Chiang wrote:
>
>>> with commit commit 5d554a7bb0643a6151a84319bfeba8270bf5269e (ACPI: processor:
>>> add internal processor_physically_present()) a new function got introduced which
>>> always fails on machines with CONFIG_SMP disabled. Thus _PDC will never be
>>> initialized? set?.
>
>> Does this patch fix it?
>
> works great
> thanks
>
>> ---
>> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
>> index 5128435..bcf0cf8 100644
>> --- a/drivers/acpi/processor_core.c
>> +++ b/drivers/acpi/processor_core.c
>> @@ -223,7 +223,7 @@ static bool processor_physically_present(acpi_handle handle)
>>   	type = (acpi_type == ACPI_TYPE_DEVICE) ? 1 : 0;
>>   	cpuid = acpi_get_cpuid(handle, type, acpi_id);
>>
>> -	if (cpuid == -1)
>> +	if ((cpuid == -1)&&  (num_online_cpus()>  1))
>>   		return false;
>>
>>   	return true;
>>
I have a puzzle why num_online_cpus is used here, instead of
num_possible_cpus. It will be possible under a hotplug scenario.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html