From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Barry Song <21cnbao@gmail.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
linux-kernel@vger.kernel.org, "Song,
Barry" <Barry.Song@analog.com>,
linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
uclinux-dist-devel@blackfin.uclinux.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code
Date: Tue, 22 Jun 2010 20:55:45 +0400 [thread overview]
Message-ID: <20100622165545.GA10255@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTikY9pfHsQ6xeVkixKF5kqL2nLyV2kgcR2iJKhG-@mail.gmail.com>
On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote:
[...]
> > jid = jedec_probe(spi);
> > if (!jid) {
> > - dev_info(&spi->dev, "non-JEDEC variant of %s\n",
> > - id->name);
> > + return -ENODEV;
> The patch looks good to me. Only problem is NULL is also returned by
> spi_write_then_read() fail:
[...]
> Here much better for -EIO (return tmp)?
Agreed. Though, this is not a regression, and I guess desires
its own patch.
Here are two patches, one for 2.6.35 (minimal changes to fix
the JEDEC problem), another for 2.6.36.
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Barry Song <21cnbao@gmail.com>
Cc: "Song, Barry" <Barry.Song@analog.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Artem Bityutskiy <dedekind1@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-mtd@lists.infradead.org,
uclinux-dist-devel@blackfin.uclinux.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code
Date: Tue, 22 Jun 2010 20:55:45 +0400 [thread overview]
Message-ID: <20100622165545.GA10255@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTikY9pfHsQ6xeVkixKF5kqL2nLyV2kgcR2iJKhG-@mail.gmail.com>
On Tue, Jun 22, 2010 at 02:37:52PM +0800, Barry Song wrote:
[...]
> > jid = jedec_probe(spi);
> > if (!jid) {
> > - dev_info(&spi->dev, "non-JEDEC variant of %s\n",
> > - id->name);
> > + return -ENODEV;
> The patch looks good to me. Only problem is NULL is also returned by
> spi_write_then_read() fail:
[...]
> Here much better for -EIO (return tmp)?
Agreed. Though, this is not a regression, and I guess desires
its own patch.
Here are two patches, one for 2.6.35 (minimal changes to fix
the JEDEC problem), another for 2.6.36.
next prev parent reply other threads:[~2010-06-22 16:55 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 0:39 [PATCH v2 0/6] Device table matching for SPI subsystem Anton Vorontsov
2009-07-31 0:39 ` Anton Vorontsov
2009-07-31 0:39 ` Anton Vorontsov
2009-07-31 0:39 ` [lm-sensors] " Anton Vorontsov
2009-07-31 0:40 ` [PATCH 1/6] spi: Add support for device table matching Anton Vorontsov
2009-07-31 0:40 ` Anton Vorontsov
2009-07-31 0:40 ` Anton Vorontsov
2009-07-31 0:40 ` [lm-sensors] " Anton Vorontsov
2009-07-31 0:41 ` [PATCH 2/6] mtd: m25p80: Convert to " Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Anton Vorontsov
2009-08-04 2:54 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching David Brownell
2009-08-04 2:54 ` David Brownell
2009-08-04 2:54 ` David Brownell
2009-08-04 2:54 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table David Brownell
2009-08-18 21:44 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching Anton Vorontsov
2009-08-18 21:44 ` Anton Vorontsov
2009-08-18 21:44 ` Anton Vorontsov
2009-08-18 21:44 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Anton Vorontsov
2009-08-18 21:46 ` [PATCH 1/2] mtd: m25p80: Rework probing/JEDEC code Anton Vorontsov
2009-08-18 21:46 ` Anton Vorontsov
2010-06-12 6:27 ` Barry Song
2010-06-12 6:27 ` Barry Song
2010-06-12 6:27 ` Barry Song
2010-06-18 13:32 ` Anton Vorontsov
2010-06-18 13:32 ` Anton Vorontsov
2010-06-21 2:42 ` [Uclinux-dist-devel] [PATCH 1/2] mtd: m25p80: Reworkprobing/JEDEC code Song, Barry
2010-06-21 2:42 ` Song, Barry
2010-06-21 2:42 ` Song, Barry
2010-06-21 3:27 ` Barry Song
2010-06-21 3:27 ` Barry Song
2010-06-21 3:27 ` Barry Song
2010-06-21 7:15 ` Anton Vorontsov
2010-06-21 7:15 ` Anton Vorontsov
2010-06-21 7:22 ` Barry Song
2010-06-21 7:22 ` Barry Song
2010-06-21 7:22 ` Barry Song
2010-06-21 7:39 ` Anton Vorontsov
2010-06-21 7:39 ` Anton Vorontsov
2010-06-21 10:31 ` Barry Song
2010-06-21 10:31 ` Barry Song
2010-06-21 10:31 ` Barry Song
2010-06-21 11:20 ` Anton Vorontsov
2010-06-21 11:20 ` Anton Vorontsov
2010-06-21 16:34 ` Mike Frysinger
2010-06-21 16:34 ` Mike Frysinger
2010-06-21 16:34 ` Mike Frysinger
2010-06-21 16:47 ` Anton Vorontsov
2010-06-21 16:47 ` Anton Vorontsov
2010-06-21 16:54 ` Mike Frysinger
2010-06-21 16:54 ` Mike Frysinger
2010-06-21 16:54 ` Mike Frysinger
2010-06-22 6:37 ` Barry Song
2010-06-22 6:37 ` Barry Song
2010-06-22 6:37 ` Barry Song
2010-06-22 16:55 ` Anton Vorontsov [this message]
2010-06-22 16:55 ` Anton Vorontsov
2010-06-22 16:57 ` [PATCH 1/2] mtd: m25p80: Fix false-positive probing Anton Vorontsov
2010-06-22 16:57 ` Anton Vorontsov
2010-06-22 17:56 ` Mike Frysinger
2010-06-22 17:56 ` Mike Frysinger
2010-07-08 5:57 ` Artem Bityutskiy
2010-07-08 5:57 ` Artem Bityutskiy
2010-06-22 16:57 ` [PATCH 2/2] mtd: m25p80: Make jedec_probe() return proper errno values Anton Vorontsov
2010-06-22 16:57 ` Anton Vorontsov
2009-08-18 21:46 ` [PATCH 2/2] mtd: m25p80: Add support for CAT25xxx serial EEPROMs Anton Vorontsov
2009-08-18 21:46 ` Anton Vorontsov
2009-09-22 23:25 ` Andrew Morton
2009-09-22 23:25 ` Andrew Morton
2009-09-22 23:40 ` Anton Vorontsov
2009-09-22 23:40 ` Anton Vorontsov
2009-09-22 23:40 ` Anton Vorontsov
2009-09-22 21:17 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching Andrew Morton
2009-09-22 21:17 ` Andrew Morton
2009-09-22 21:17 ` Andrew Morton
2009-09-22 23:01 ` Anton Vorontsov
2009-09-22 23:01 ` Anton Vorontsov
2009-09-22 23:01 ` Anton Vorontsov
2009-09-22 23:43 ` David Woodhouse
2009-09-22 23:43 ` David Woodhouse
2009-09-22 23:43 ` David Woodhouse
2009-09-22 23:52 ` Andrew Morton
2009-09-22 23:52 ` Andrew Morton
2009-09-22 23:52 ` Andrew Morton
2009-09-22 23:55 ` Anton Vorontsov
2009-09-22 23:55 ` Anton Vorontsov
2009-09-22 23:55 ` Anton Vorontsov
2009-09-23 0:02 ` Andrew Morton
2009-09-23 0:02 ` Andrew Morton
2009-09-23 0:02 ` Andrew Morton
2009-08-12 20:45 ` Michael Barkowski
2009-08-12 20:45 ` Michael Barkowski
2009-08-12 20:45 ` Michael Barkowski
2009-08-12 20:45 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Michael Barkowski
2009-08-12 20:58 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching Anton Vorontsov
2009-08-12 20:58 ` Anton Vorontsov
2009-08-12 20:58 ` Anton Vorontsov
2009-08-12 20:58 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Anton Vorontsov
2009-08-12 20:58 ` [PATCH 2/6] mtd: m25p80: Convert to device table matching Michael Barkowski
2009-08-12 20:58 ` Michael Barkowski
2009-08-12 20:58 ` Michael Barkowski
2009-08-12 20:58 ` [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table Michael Barkowski
2009-07-31 0:41 ` [PATCH 3/6] of: Remove "stm,m25p40" alias Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` [lm-sensors] " Anton Vorontsov
2009-07-31 0:41 ` [PATCH 4/6] hwmon: adxx: Convert to device table matching Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` [lm-sensors] [PATCH 4/6] hwmon: adxx: Convert to device table Anton Vorontsov
2009-07-31 0:41 ` [PATCH 5/6] hwmon: lm70: Convert to device table matching Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` [lm-sensors] [PATCH 5/6] hwmon: lm70: Convert to device table Anton Vorontsov
2009-07-31 0:41 ` [PATCH 6/6] spi: Prefix modalias with "spi:" Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` Anton Vorontsov
2009-07-31 0:41 ` [lm-sensors] " Anton Vorontsov
2009-08-10 7:35 ` [PATCH v2 0/6] Device table matching for SPI subsystem Artem Bityutskiy
2009-08-10 7:35 ` Artem Bityutskiy
2009-08-10 7:35 ` Artem Bityutskiy
2009-08-10 7:35 ` [lm-sensors] [PATCH v2 0/6] Device table matching for SPI Artem Bityutskiy
2009-08-18 21:44 ` [PATCH v2 0/6] Device table matching for SPI subsystem Anton Vorontsov
2009-08-18 21:44 ` Anton Vorontsov
2009-08-18 21:44 ` Anton Vorontsov
2009-08-18 21:44 ` [lm-sensors] [PATCH v2 0/6] Device table matching for SPI Anton Vorontsov
2009-08-25 14:14 ` [PATCH v2 0/6] Device table matching for SPI subsystem Artem Bityutskiy
2009-08-25 14:14 ` Artem Bityutskiy
2009-08-25 14:14 ` Artem Bityutskiy
2009-08-25 14:14 ` [lm-sensors] [PATCH v2 0/6] Device table matching for SPI Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100622165545.GA10255@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=21cnbao@gmail.com \
--cc=Barry.Song@analog.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.