[Bug 16375] New: missing blit_vb check in r600_prepare_blit_copy

[Bug 16375] New: missing blit_vb check in r600_prepare_blit_copy

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=16375

           Summary: missing blit_vb check in r600_prepare_blit_copy
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.35-rc4
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
        AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
        ReportedBy: git.user@gmail.com
        Regression: No


r600_prepare_blit_copy issing check of dev_priv->blit_vb to be filled by
r600_nomm_get_vb. r600_nomm_get_vb can fail and return EAGAIN and we'll see a
NULL pointer dereference.
fix:
--- git/linux-2.6/drivers/gpu/drm/radeon/r600_blit.c    2010-03-09
23:26:42.601820012 +0300
+++ linux-2.6.35-rc4/drivers/gpu/drm/radeon/r600_blit.c 2010-07-12
23:55:43.246560111 +0400
@@ -541,6 +541,8 @@ r600_prepare_blit_copy(struct drm_device
        DRM_DEBUG("\n");

        r600_nomm_get_vb(dev);
+       if (!dev_priv->blit_vb)
+               return;

        dev_priv->blit_vb->file_priv = file_priv;

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--

[Bug 16375] missing blit_vb check in r600_prepare_blit_copy

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=16375


Andrew Morton <akpm@linux-foundation.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akpm@linux-foundation.org




--- Comment #1 from Andrew Morton <akpm@linux-foundation.org>  2010-07-15 18:41:49 ---
Please don't send patches via bugzilla - it causes lots of problems with
our usual patch management and review processes.

Please send this patch via email as per Documentation/SubmittingPatches. 
Suitable recipients may be found via scripts/get_maintainer.pl.  Please
also cc myself on the email.

Thanks.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--

[Bug 16375] missing blit_vb check in r600_prepare_blit_copy

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=16375





--- Comment #2 from Alexander Y.  Fomichev <git.user@gmail.com>  2010-07-20 09:41:15 ---
tnx for reply, i've sent patch with cc to you.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--

[Bug 16375] missing blit_vb check in r600_prepare_blit_copy

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=16375


Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com




--- Comment #3 from Alex Deucher <alexdeucher@gmail.com>  2010-07-22 03:19:27 ---
fix is in Linus' tree:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c42750b0261274107ae85c894c088e618a3e38b9

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
--

[Bug 16375] missing blit_vb check in r600_prepare_blit_copy

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=16375


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.