* [PATCH] install udev rules into rules.d
@ 2010-07-23 12:16 Olaf Hering
2010-07-23 16:47 ` Ian Jackson
0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2010-07-23 12:16 UTC (permalink / raw)
To: xen-devel
Install rules straight into /etc/udev/rules.d
udev version 029 since mid 2004 uses this directory already.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
tools/hotplug/Linux/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- xen-unstable.hg-4.1.21836.orig/tools/hotplug/Linux/Makefile
+++ xen-unstable.hg-4.1.21836/tools/hotplug/Linux/Makefile
@@ -101,8 +101,7 @@ install-udev:
$(INSTALL_DIR) $(DESTDIR)$(UDEV_RULES_DIR)/rules.d
set -e; for i in $(UDEV_RULES); \
do \
- $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
- ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
+ $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
done
.PHONY: clean
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] install udev rules into rules.d
2010-07-23 12:16 [PATCH] install udev rules into rules.d Olaf Hering
@ 2010-07-23 16:47 ` Ian Jackson
2010-07-23 18:20 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Ian Jackson @ 2010-07-23 16:47 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
Olaf Hering writes ("[Xen-devel] [PATCH] install udev rules into rules.d"):
> - $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
> - ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
> + $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
What will this do if run on a system which already has the symlink
arrangement from the previous versions of Xen ? Perhaps some kind of
fixing up is necessary.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] install udev rules into rules.d
2010-07-23 16:47 ` Ian Jackson
@ 2010-07-23 18:20 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2010-07-23 18:20 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
On Fri, Jul 23, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] install udev rules into rules.d"):
> > - $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR); \
> > - ln -sf ../$$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
> > + $(INSTALL_DATA) $$i $(DESTDIR)$(UDEV_RULES_DIR)/rules.d; \
>
> What will this do if run on a system which already has the symlink
> arrangement from the previous versions of Xen ? Perhaps some kind of
> fixing up is necessary.
I tried strace -f -o x -s 123 install a b, and b was unlinked first.
So it appears that the patch above is save.
Packing systems get this symlink-to-file thing right as well.
Olaf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-23 18:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-23 12:16 [PATCH] install udev rules into rules.d Olaf Hering
2010-07-23 16:47 ` Ian Jackson
2010-07-23 18:20 ` Olaf Hering
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.