From: Rabin Vincent <rabin@rab.in>
To: Jeff Ohlstein <johlstei@codeaurora.org>
Cc: linux@arm.linux.org.uk, linux-arm-msm@vger.kernel.org,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GIC: Dont disable INT in ack callback
Date: Sat, 24 Jul 2010 16:00:27 +0530 [thread overview]
Message-ID: <20100724103027.GA3336@debian> (raw)
In-Reply-To: <1279839450-6477-1-git-send-email-johlstei@codeaurora.org>
On Thu, Jul 22, 2010 at 03:57:30PM -0700, Jeff Ohlstein wrote:
> Unless gic_ack_irq is called from __do_IRQ, interrupt should not
> be disabled in the ack function. Disabling the interrupt causes
> handle_edge_irq to never enable it again.
The GIC doesn't use handle_edge_irq.
Anyway, this change is correct since gic_ack_irq is currently doing a
maskack, when it should be just an ack. However, since
GENERIC_HARDIRQS_NO__DO_IRQ is always true on ARM, I don't see a need to
add the ifndef.
WARNING: multiple messages have this Message-ID (diff)
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] GIC: Dont disable INT in ack callback
Date: Sat, 24 Jul 2010 16:00:27 +0530 [thread overview]
Message-ID: <20100724103027.GA3336@debian> (raw)
In-Reply-To: <1279839450-6477-1-git-send-email-johlstei@codeaurora.org>
On Thu, Jul 22, 2010 at 03:57:30PM -0700, Jeff Ohlstein wrote:
> Unless gic_ack_irq is called from __do_IRQ, interrupt should not
> be disabled in the ack function. Disabling the interrupt causes
> handle_edge_irq to never enable it again.
The GIC doesn't use handle_edge_irq.
Anyway, this change is correct since gic_ack_irq is currently doing a
maskack, when it should be just an ack. However, since
GENERIC_HARDIRQS_NO__DO_IRQ is always true on ARM, I don't see a need to
add the ifndef.
next prev parent reply other threads:[~2010-07-24 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 22:57 [PATCH] GIC: Dont disable INT in ack callback Jeff Ohlstein
2010-07-22 22:57 ` Jeff Ohlstein
2010-07-24 10:30 ` Rabin Vincent [this message]
2010-07-24 10:30 ` Rabin Vincent
2010-07-27 18:46 ` [PATCH v2] " Jeff Ohlstein
2010-07-27 18:46 ` Jeff Ohlstein
2010-07-27 18:46 ` Jeff Ohlstein
-- strict thread matches above, loose matches on Subject: below --
2010-09-30 19:58 [PATCH] " Daniel Walker
2010-09-30 19:58 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100724103027.GA3336@debian \
--to=rabin@rab.in \
--cc=adharmap@codeaurora.org \
--cc=johlstei@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.