From: Ralf Baechle <ralf@linux-mips.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, "Chris Dearman" <chris@mips.com>,
"Robert P. J. Day" <rpjday@crashcourse.ca>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in
Date: Mon, 26 Jul 2010 14:04:17 +0000 [thread overview]
Message-ID: <20100726140417.GA12084@linux-mips.org> (raw)
In-Reply-To: <1279130502-10777-1-git-send-email-segooon@gmail.com>
On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
Queued for 2.6.36, thanks!
Yes, %p is prefered here. But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: Ralf Baechle <ralf@linux-mips.org>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, "Chris Dearman" <chris@mips.com>,
"Robert P. J. Day" <rpjday@crashcourse.ca>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"André Goddard Rosa" <andre.goddard@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()
Date: Mon, 26 Jul 2010 15:04:17 +0100 [thread overview]
Message-ID: <20100726140417.GA12084@linux-mips.org> (raw)
In-Reply-To: <1279130502-10777-1-git-send-email-segooon@gmail.com>
On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
Queued for 2.6.36, thanks!
Yes, %p is prefered here. But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...
Ralf
next prev parent reply other threads:[~2010-07-26 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 18:01 [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:01 ` Kulikov Vasiliy
2010-07-26 14:04 ` Ralf Baechle [this message]
2010-07-26 14:04 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100726140417.GA12084@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=andre.goddard@gmail.com \
--cc=chris@mips.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=rpjday@crashcourse.ca \
--cc=rusty@rustcorp.com.au \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.