* [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()
@ 2010-07-14 18:01 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Ralf Baechle, Chris Dearman, Robert P. J. Day, Rusty Russell,
André Goddard Rosa, linux-mips, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/mips/kernel/smtc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/mips/kernel/smtc.c b/arch/mips/kernel/smtc.c
index a95dea5..cfeb2c1 100644
--- a/arch/mips/kernel/smtc.c
+++ b/arch/mips/kernel/smtc.c
@@ -975,8 +975,7 @@ void ipi_decode(struct smtc_ipi *pipi)
ipi_call_interrupt();
break;
default:
- printk("Impossible SMTC IPI Argument 0x%x\n",
- (int)arg_copy);
+ printk("Impossible SMTC IPI Argument %p\n", arg_copy);
break;
}
break;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()
@ 2010-07-14 18:01 ` Kulikov Vasiliy
0 siblings, 0 replies; 4+ messages in thread
From: Kulikov Vasiliy @ 2010-07-14 18:01 UTC (permalink / raw)
To: kernel-janitors
Cc: Ralf Baechle, Chris Dearman, Robert P. J. Day, Rusty Russell,
André Goddard Rosa, linux-mips, linux-kernel
Use %p instead of %08x in printk().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
arch/mips/kernel/smtc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/mips/kernel/smtc.c b/arch/mips/kernel/smtc.c
index a95dea5..cfeb2c1 100644
--- a/arch/mips/kernel/smtc.c
+++ b/arch/mips/kernel/smtc.c
@@ -975,8 +975,7 @@ void ipi_decode(struct smtc_ipi *pipi)
ipi_call_interrupt();
break;
default:
- printk("Impossible SMTC IPI Argument 0x%x\n",
- (int)arg_copy);
+ printk("Impossible SMTC IPI Argument %p\n", arg_copy);
break;
}
break;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in
2010-07-14 18:01 ` Kulikov Vasiliy
@ 2010-07-26 14:04 ` Ralf Baechle
-1 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2010-07-26 14:04 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Chris Dearman, Robert P. J. Day, Rusty Russell,
André Goddard Rosa, linux-mips, linux-kernel
On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
Queued for 2.6.36, thanks!
Yes, %p is prefered here. But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk()
@ 2010-07-26 14:04 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2010-07-26 14:04 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: kernel-janitors, Chris Dearman, Robert P. J. Day, Rusty Russell,
André Goddard Rosa, linux-mips, linux-kernel
On Wed, Jul 14, 2010 at 10:01:42PM +0400, Kulikov Vasiliy wrote:
> Use %p instead of %08x in printk().
Queued for 2.6.36, thanks!
Yes, %p is prefered here. But your log message doesn't mention that your
patch also does a functional change, it drops the 0x prefix of the printed
value ...
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-07-26 14:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 18:01 [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk() Kulikov Vasiliy
2010-07-14 18:01 ` Kulikov Vasiliy
2010-07-26 14:04 ` [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in Ralf Baechle
2010-07-26 14:04 ` [PATCH 03/11] arch/mips/kernel/smtc.c: formatting of pointers in printk() Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.