From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
Date: Sun, 1 Aug 2010 14:40:59 +0200 [thread overview]
Message-ID: <20100801124059.GA7977@pengutronix.de> (raw)
In-Reply-To: <20100730142519.18287.22053.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
Hello,
On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote:
> Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
> module init routine in case of error, and so may have been discarded during
> linkage.
From time to time I think about introducing something like
__init_or_exit that puts a function into .init.text if .exit.text is
discarded. Is it worth the effort?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver()
Date: Sun, 1 Aug 2010 14:40:59 +0200 [thread overview]
Message-ID: <20100801124059.GA7977@pengutronix.de> (raw)
In-Reply-To: <20100730142519.18287.22053.stgit@warthog.procyon.org.uk>
Hello,
On Fri, Jul 30, 2010 at 03:25:19PM +0100, David Howells wrote:
> Remove the __exit mark from cifs_exit_dns_resolver() as it's called by the
> module init routine in case of error, and so may have been discarded during
> linkage.
>From time to time I think about introducing something like
__init_or_exit that puts a function into .init.text if .exit.text is
discarded. Is it worth the effort?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-08-01 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 14:25 [PATCH] CIFS: Remove __exit mark from cifs_exit_dns_resolver() David Howells
2010-07-30 14:25 ` David Howells
[not found] ` <20100730142519.18287.22053.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2010-08-01 12:40 ` Uwe Kleine-König [this message]
2010-08-01 12:40 ` Uwe Kleine-König
[not found] ` <20100801124059.GA7977-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-08-02 9:17 ` David Howells
2010-08-02 9:17 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100801124059.GA7977@pengutronix.de \
--to=u.kleine-koenig-bicnvbalz9megne8c9+irq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.