From: Greg KH <gregkh@suse.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Tejun Heo <tj@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Richard Purdie <rpurdie@rpsys.net>,
Paul Mackerras <paulus@samba.org>,
Jean Delvare <khali@linux-fr.org>, Dmitry Torokhov <dtor@mail.ru>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jani Nikula <ext-jani.1.nikula@nokia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Chris Wright <chrisw@sous-sol.org>,
Nick Cheng <nick.cheng@areca.com.tw>,
James Smart <james.smart@emulex.com>,
Alex Iannicelli <alex.iannicelli@emulex.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Benjamin Thery <benjamin.thery@bull.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Date: Mon, 2 Aug 2010 09:53:27 -0700 [thread overview]
Message-ID: <20100802165327.GA4814@suse.de> (raw)
In-Reply-To: <1280765724.5745.4.camel@groeck-laptop>
On Mon, Aug 02, 2010 at 09:15:24AM -0700, Guenter Roeck wrote:
> On Fri, 2010-07-30 at 10:36 -0400, Greg KH wrote:
> > On Fri, Jul 30, 2010 at 08:28:10PM +1000, Benjamin Herrenschmidt wrote:
> > > On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote:
> > > > On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> > > > > The following comment is found in include/linux/sysfs.h:
> > > > >
> > > > > /* FIXME
> > > > > * The *owner field is no longer used.
> > > > > * x86 tree has been cleaned up. The owner
> > > > > * attribute is still left for other arches.
> > > > > */
> > > > >
> > > > > As it turns out, the *owner field is (again?) initialized in several modules,
> > > > > suggesting that such initialization may be creeping back into the code.
> > > > >
> > > > > This patch set removes the above comment, the *owner field, and each instance
> > > > > in the code where it was found to be initialized.
> > > > >
> > > > > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> > > > > and sparc defconfig builds.
> > > >
> > > > Yeah, the change is way overdue. Maybe we should have just removed
> > > > them back then.
> > >
> > > I'm happy with the powerpc related patches as long as we all agree that
> > > needs to go. Do you need me to put some of this in powerpc.git or are
> > > you carrying them all to Linus ?
> >
> > I can carry them all in my driver-core tree if you don't object.
> >
> Any final verdict ?
>
> Not that it is my decision to make, but I think it would be better to
> have it all in one tree. Otherwise the timing for the last patch would
> get a bit complicated.
I'll take it.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@suse.de>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Nick Cheng <nick.cheng@areca.com.tw>,
Jani Nikula <ext-jani.1.nikula@nokia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
James Smart <james.smart@emulex.com>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chris Wright <chrisw@sous-sol.org>,
Jean Delvare <khali@linux-fr.org>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Richard Purdie <rpurdie@rpsys.net>,
Alex Iannicelli <alex.iannicelli@emulex.com>,
Dmitry Torokhov <dtor@mail.ru>, Tejun Heo <tj@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Benjamin Thery <benjamin.thery@bull.net>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Date: Mon, 2 Aug 2010 09:53:27 -0700 [thread overview]
Message-ID: <20100802165327.GA4814@suse.de> (raw)
In-Reply-To: <1280765724.5745.4.camel@groeck-laptop>
On Mon, Aug 02, 2010 at 09:15:24AM -0700, Guenter Roeck wrote:
> On Fri, 2010-07-30 at 10:36 -0400, Greg KH wrote:
> > On Fri, Jul 30, 2010 at 08:28:10PM +1000, Benjamin Herrenschmidt wrote:
> > > On Fri, 2010-07-30 at 10:45 +0200, Tejun Heo wrote:
> > > > On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> > > > > The following comment is found in include/linux/sysfs.h:
> > > > >
> > > > > /* FIXME
> > > > > * The *owner field is no longer used.
> > > > > * x86 tree has been cleaned up. The owner
> > > > > * attribute is still left for other arches.
> > > > > */
> > > > >
> > > > > As it turns out, the *owner field is (again?) initialized in several modules,
> > > > > suggesting that such initialization may be creeping back into the code.
> > > > >
> > > > > This patch set removes the above comment, the *owner field, and each instance
> > > > > in the code where it was found to be initialized.
> > > > >
> > > > > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> > > > > and sparc defconfig builds.
> > > >
> > > > Yeah, the change is way overdue. Maybe we should have just removed
> > > > them back then.
> > >
> > > I'm happy with the powerpc related patches as long as we all agree that
> > > needs to go. Do you need me to put some of this in powerpc.git or are
> > > you carrying them all to Linus ?
> >
> > I can carry them all in my driver-core tree if you don't object.
> >
> Any final verdict ?
>
> Not that it is my decision to make, but I think it would be better to
> have it all in one tree. Otherwise the timing for the last patch would
> get a bit complicated.
I'll take it.
thanks,
greg k-h
next prev parent reply other threads:[~2010-08-02 16:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 5:09 [PATCH 0/6] Remove owner field from sysfs attribute structure Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` [PATCH 1/6] scsi: Remove owner field from attribute initialization in LPFC driver Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` [PATCH 2/6] scsi: Remove owner field from attribute initialization in ARCMSR driver Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` [PATCH 3/6] leds: Remove owner field from attribute initialization in bd2802 driver Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` [PATCH 4/6] regulator: Remove owner field from attribute initialization in regulator core driver Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 17:15 ` Mark Brown
2010-07-29 17:15 ` Mark Brown
2010-07-29 5:09 ` [PATCH 5/6] powerpc/pci: Remove owner field from attribute initialization in PCI bridge init Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` [PATCH 6/6] Remove owner field from sysfs struct attribute Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 5:09 ` Guenter Roeck
2010-07-29 6:16 ` [PATCH 0/6] Remove owner field from sysfs attribute structure Eric Biederman
2010-07-29 6:16 ` Eric Biederman
2010-07-29 6:16 ` Eric Biederman
2010-08-02 23:31 ` Greg KH
2010-08-02 23:31 ` Greg KH
2010-08-10 13:43 ` Jean Delvare
2010-08-10 13:43 ` Jean Delvare
2010-08-10 15:17 ` Stephen Rothwell
2010-08-10 15:17 ` Stephen Rothwell
2010-08-10 15:20 ` Stephen Rothwell
2010-08-10 15:20 ` Stephen Rothwell
2010-08-10 16:43 ` Guenter Roeck
2010-08-10 16:43 ` Guenter Roeck
2010-08-10 16:43 ` Guenter Roeck
2010-07-30 8:45 ` Tejun Heo
2010-07-30 8:45 ` Tejun Heo
2010-07-30 10:28 ` Benjamin Herrenschmidt
2010-07-30 10:28 ` Benjamin Herrenschmidt
2010-07-30 14:36 ` Greg KH
2010-07-30 14:36 ` Greg KH
2010-08-02 16:15 ` Guenter Roeck
2010-08-02 16:15 ` Guenter Roeck
2010-08-02 16:53 ` Greg KH [this message]
2010-08-02 16:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802165327.GA4814@suse.de \
--to=gregkh@suse.de \
--cc=James.Bottomley@suse.de \
--cc=alex.iannicelli@emulex.com \
--cc=benh@kernel.crashing.org \
--cc=benjamin.thery@bull.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chrisw@sous-sol.org \
--cc=dtor@mail.ru \
--cc=ebiederm@aristanetworks.com \
--cc=ext-jani.1.nikula@nokia.com \
--cc=guenter.roeck@ericsson.com \
--cc=james.smart@emulex.com \
--cc=khali@linux-fr.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=lrg@slimlogic.co.uk \
--cc=nick.cheng@areca.com.tw \
--cc=paulus@samba.org \
--cc=rpurdie@rpsys.net \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.