All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jani Nikula <ext-jani.1.nikula@nokia.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	James Smart <james.smart@emulex.com>,
	"Eric W. Biederman" <ebiederm@aristanetworks.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Chris Wright <chrisw@sous-sol.org>,
	linuxppc-dev@ozlabs.org,
	"James E.J. Bottomley" <James.Bottomley@suse.de>,
	Richard Purdie <rpurdie@rpsys.net>,
	Nick Cheng <nick.cheng@areca.com.tw>,
	Dmitry Torokhov <dtor@mail.ru>, Jean Delvare <khali@linux-fr.org>,
	Paul Mackerras <paulus@samba.org>,
	Benjamin Thery <benjamin.thery@bull.net>,
	linux-scsi@vger.kernel.org,
	Alex Iannicelli <alex.iannicelli@emulex.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Date: Fri, 30 Jul 2010 10:45:48 +0200	[thread overview]
Message-ID: <4C52913C.9020204@kernel.org> (raw)
In-Reply-To: <1280380166-29196-1-git-send-email-guenter.roeck@ericsson.com>

On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> The following comment is found in include/linux/sysfs.h:
> 
>    /* FIXME
>     * The *owner field is no longer used.
>     * x86 tree has been cleaned up. The owner
>     * attribute is still left for other arches.
>     */
> 
> As it turns out, the *owner field is (again?) initialized in several modules,
> suggesting that such initialization may be creeping back into the code.
> 
> This patch set removes the above comment, the *owner field, and each instance
> in the code where it was found to be initialized.
> 
> Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> and sparc defconfig builds.

Yeah, the change is way overdue.  Maybe we should have just removed
them back then.

 Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>,
	Richard Purdie <rpurdie@rpsys.net>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Jean Delvare <khali@linux-fr.org>, Dmitry Torokhov <dtor@mail.ru>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Jani Nikula <ext-jani.1.nikula@nokia.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Chris Wright <chrisw@sous-sol.org>,
	Nick Cheng <nick.cheng@areca.com.tw>,
	James Smart <james.smart@emulex.com>,
	Alex Iannicelli <alex.iannicelli@emulex.com>,
	"Eric W. Biederman" <ebiederm@aristanetworks.com>,
	Benjamin Thery <benjamin.thery@bull.net>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure
Date: Fri, 30 Jul 2010 10:45:48 +0200	[thread overview]
Message-ID: <4C52913C.9020204@kernel.org> (raw)
In-Reply-To: <1280380166-29196-1-git-send-email-guenter.roeck@ericsson.com>

On 07/29/2010 07:09 AM, Guenter Roeck wrote:
> The following comment is found in include/linux/sysfs.h:
> 
>    /* FIXME
>     * The *owner field is no longer used.
>     * x86 tree has been cleaned up. The owner
>     * attribute is still left for other arches.
>     */
> 
> As it turns out, the *owner field is (again?) initialized in several modules,
> suggesting that such initialization may be creeping back into the code.
> 
> This patch set removes the above comment, the *owner field, and each instance
> in the code where it was found to be initialized.
> 
> Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc,
> and sparc defconfig builds.

Yeah, the change is way overdue.  Maybe we should have just removed
them back then.

 Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

  parent reply	other threads:[~2010-07-30  8:45 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  5:09 [PATCH 0/6] Remove owner field from sysfs attribute structure Guenter Roeck
2010-07-29  5:09 ` Guenter Roeck
2010-07-29  5:09 ` Guenter Roeck
2010-07-29  5:09 ` [PATCH 1/6] scsi: Remove owner field from attribute initialization in LPFC driver Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09 ` [PATCH 2/6] scsi: Remove owner field from attribute initialization in ARCMSR driver Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09 ` [PATCH 3/6] leds: Remove owner field from attribute initialization in bd2802 driver Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09 ` [PATCH 4/6] regulator: Remove owner field from attribute initialization in regulator core driver Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29 17:15   ` Mark Brown
2010-07-29 17:15     ` Mark Brown
2010-07-29  5:09 ` [PATCH 5/6] powerpc/pci: Remove owner field from attribute initialization in PCI bridge init Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09 ` [PATCH 6/6] Remove owner field from sysfs struct attribute Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  5:09   ` Guenter Roeck
2010-07-29  6:16 ` [PATCH 0/6] Remove owner field from sysfs attribute structure Eric Biederman
2010-07-29  6:16   ` Eric Biederman
2010-07-29  6:16   ` Eric Biederman
2010-08-02 23:31   ` Greg KH
2010-08-02 23:31     ` Greg KH
2010-08-10 13:43     ` Jean Delvare
2010-08-10 13:43       ` Jean Delvare
2010-08-10 15:17       ` Stephen Rothwell
2010-08-10 15:17         ` Stephen Rothwell
2010-08-10 15:20         ` Stephen Rothwell
2010-08-10 15:20           ` Stephen Rothwell
2010-08-10 16:43           ` Guenter Roeck
2010-08-10 16:43             ` Guenter Roeck
2010-08-10 16:43             ` Guenter Roeck
2010-07-30  8:45 ` Tejun Heo [this message]
2010-07-30  8:45   ` Tejun Heo
2010-07-30 10:28   ` Benjamin Herrenschmidt
2010-07-30 10:28     ` Benjamin Herrenschmidt
2010-07-30 14:36     ` Greg KH
2010-07-30 14:36       ` Greg KH
2010-08-02 16:15       ` Guenter Roeck
2010-08-02 16:15         ` Guenter Roeck
2010-08-02 16:53         ` Greg KH
2010-08-02 16:53           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C52913C.9020204@kernel.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@suse.de \
    --cc=alex.iannicelli@emulex.com \
    --cc=benjamin.thery@bull.net \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=chrisw@sous-sol.org \
    --cc=dtor@mail.ru \
    --cc=ebiederm@aristanetworks.com \
    --cc=ext-jani.1.nikula@nokia.com \
    --cc=gregkh@suse.de \
    --cc=guenter.roeck@ericsson.com \
    --cc=james.smart@emulex.com \
    --cc=khali@linux-fr.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=nick.cheng@areca.com.tw \
    --cc=paulus@samba.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.