From: Luis R. Rodriguez <lrodriguez@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 13:47:56 -0700 [thread overview]
Message-ID: <20100805204756.GA1738@tux> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052226380.31692@ask.diku.dk>
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1 at p1 S2 at p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Julia Lawall <julia@diku.dk>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
Sujith Manoharan <Sujith.Manoharan@Atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing
Date: Thu, 05 Aug 2010 20:47:56 +0000 [thread overview]
Message-ID: <20100805204756.GA1738@tux> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052226380.31692@ask.diku.dk>
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column = p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Julia Lawall <julia@diku.dk>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
Sujith Manoharan <Sujith.Manoharan@Atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 13:47:56 -0700 [thread overview]
Message-ID: <20100805204756.GA1738@tux> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052226380.31692@ask.diku.dk>
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Julia Lawall <julia@diku.dk>
Cc: Luis Rodriguez <Luis.Rodriguez@atheros.com>,
Jouni Malinen <Jouni.Malinen@atheros.com>,
Sujith Manoharan <Sujith.Manoharan@atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
Date: Thu, 5 Aug 2010 13:47:56 -0700 [thread overview]
Message-ID: <20100805204756.GA1738@tux> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052226380.31692@ask.diku.dk>
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
next prev parent reply other threads:[~2010-08-05 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 20:26 [ath9k-devel] [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation Julia Lawall
2010-08-05 20:26 ` Julia Lawall
2010-08-05 20:26 ` Julia Lawall
2010-08-05 20:26 ` [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if Julia Lawall
2010-08-05 20:47 ` Luis R. Rodriguez [this message]
2010-08-05 20:47 ` [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation Luis R. Rodriguez
2010-08-05 20:47 ` Luis R. Rodriguez
2010-08-05 20:47 ` [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100805204756.GA1738@tux \
--to=lrodriguez@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.