* [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
@ 2010-08-05 20:26 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2010-08-05 20:26 UTC (permalink / raw)
To: Luis R. Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanthakumar Thiagarajan, Senthil Balasubramanian,
John W. Linville, linux-wireless, ath9k-devel, netdev,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This patch doesn't change the semantics of the code. But it might not be
what is intended.
drivers/net/wireless/ath/ath9k/ar9003_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 5b995be..a462da2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
@@ -185,7 +185,7 @@ static bool ar9003_hw_get_isr(struct ath_hw *ah, enum ath9k_int *masked)
ath_print(common, ATH_DBG_INTERRUPT,
"AR_INTR_SYNC_LOCAL_TIMEOUT\n");
- REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
+ REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
(void) REG_READ(ah, AR_INTR_SYNC_CAUSE_CLR);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
@ 2010-08-05 20:26 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2010-08-05 20:26 UTC (permalink / raw)
To: Luis R. Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanthakumar Thiagarajan, Senthil Balasubramanian,
John W. Linville, linux-wireless, ath9k-devel, netdev,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column == p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This patch doesn't change the semantics of the code. But it might not be
what is intended.
drivers/net/wireless/ath/ath9k/ar9003_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 5b995be..a462da2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
@@ -185,7 +185,7 @@ static bool ar9003_hw_get_isr(struct ath_hw *ah, enum ath9k_int *masked)
ath_print(common, ATH_DBG_INTERRUPT,
"AR_INTR_SYNC_LOCAL_TIMEOUT\n");
- REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
+ REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
(void) REG_READ(ah, AR_INTR_SYNC_CAUSE_CLR);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if
@ 2010-08-05 20:26 ` Julia Lawall
0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2010-08-05 20:26 UTC (permalink / raw)
To: Luis R. Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanthakumar Thiagarajan, Senthil Balasubramanian,
John W. Linville, linux-wireless, ath9k-devel, netdev,
linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Outdent the code following the if.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@
(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
if (p1[0].column = p2[0].column):
cocci.print_main("branch",p1)
cocci.print_secs("after",p2)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
This patch doesn't change the semantics of the code. But it might not be
what is intended.
drivers/net/wireless/ath/ath9k/ar9003_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mac.c b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
index 5b995be..a462da2 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mac.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mac.c
@@ -185,7 +185,7 @@ static bool ar9003_hw_get_isr(struct ath_hw *ah, enum ath9k_int *masked)
ath_print(common, ATH_DBG_INTERRUPT,
"AR_INTR_SYNC_LOCAL_TIMEOUT\n");
- REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
+ REG_WRITE(ah, AR_INTR_SYNC_CAUSE_CLR, sync_cause);
(void) REG_READ(ah, AR_INTR_SYNC_CAUSE_CLR);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread* [ath9k-devel] [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
2010-08-05 20:26 ` [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if Julia Lawall
(?)
(?)
@ 2010-08-05 20:47 ` Luis R. Rodriguez
-1 siblings, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2010-08-05 20:47 UTC (permalink / raw)
To: ath9k-devel
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1 at p1 S2 at p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
@ 2010-08-05 20:47 ` Luis R. Rodriguez
0 siblings, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2010-08-05 20:47 UTC (permalink / raw)
To: Julia Lawall
Cc: Luis Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanth Thiagarajan, Senthilkumar Balasubramanian,
John W. Linville, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing if indentation
@ 2010-08-05 20:47 ` Luis R. Rodriguez
0 siblings, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2010-08-05 20:47 UTC (permalink / raw)
To: Julia Lawall
Cc: Luis Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanth Thiagarajan, Senthilkumar Balasubramanian,
John W. Linville, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column == p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 33/42] drivers/net/wireless/ath/ath9k: Adjust confusing
@ 2010-08-05 20:47 ` Luis R. Rodriguez
0 siblings, 0 replies; 8+ messages in thread
From: Luis R. Rodriguez @ 2010-08-05 20:47 UTC (permalink / raw)
To: Julia Lawall
Cc: Luis Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanth Thiagarajan, Senthilkumar Balasubramanian,
John W. Linville, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On Thu, Aug 05, 2010 at 01:26:56PM -0700, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Outdent the code following the if.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r disable braces4@
> position p1,p2;
> statement S1,S2;
> @@
>
> (
> if (...) { ... }
> |
> if (...) S1@p1 S2@p2
> )
>
> @script:python@
> p1 << r.p1;
> p2 << r.p2;
> @@
>
> if (p1[0].column = p2[0].column):
> cocci.print_main("branch",p1)
> cocci.print_secs("after",p2)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
> This patch doesn't change the semantics of the code. But it might not be
> what is intended.
Your patch is correct, it wast a tab goof, thanks for fixing this.
Luis
^ permalink raw reply [flat|nested] 8+ messages in thread