From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: James Smart <james.smart@emulex.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"jeykholt@cisco.com" <jeykholt@cisco.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>,
"brking@us.ibm.com" <brking@us.ibm.com>
Subject: Re: [PATCH 1/5] fc class: add fc host default default dev loss setting
Date: Mon, 9 Aug 2010 11:32:29 -0700 [thread overview]
Message-ID: <20100809183229.GE70144@plapp.qlogic.org> (raw)
In-Reply-To: <4C601C1D.2020601@cs.wisc.edu>
On Mon, 09 Aug 2010, Mike Christie wrote:
> On 08/09/2010 10:00 AM, Mike Christie wrote:
> > On 08/09/2010 09:53 AM, James Smart wrote:
> >> Mike,
> >>
> >> why the motivation to get the dev_loss_tmo from the LLDD ? I would have
> >> assumed this would have become a base fc_host attribute which is rd/wr,
> >> the default coming from the module parameter, with the "set" propagating
> >> to the LLDD to change all rports to the host value (either new direct
> >> callback, or loop which calls rport set routine).
> >
> > qla2xxx and fnic set the default/initial dev_loss_tmo based on some
> > value they get from firmware.
> >
>
> The qla2xxx mention is not right.
>
> Andrew,
>
> It looks like when the port_down_retry_count is set the
> login_retry_count could be adjusted.
Actualy it's the other way around. login_retry_count is initially
seeded with NVRAM values, then based on value, reassigned to
port_down_retry_count.
> When the dev_loss_tmo is set by
> sysfs does qla2xxx, possibly want to adjust the login_retry_count?
I'd prefer to continue to have port_down_retry_count stay as a seeded
value to the transport (fc_host).
-- av
prev parent reply other threads:[~2010-08-09 18:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 8:02 FC: fix rport dev_loss_tmo initialization michaelc
2010-08-06 8:02 ` [PATCH 1/5] fc class: add fc host default default dev loss setting michaelc
2010-08-06 8:02 ` [PATCH 2/5] qla2xxx: do not reset dev_loss_tmo in slave callout michaelc
2010-08-06 8:02 ` [PATCH 3/5] lpfc: " michaelc
2010-08-06 8:02 ` [PATCH 4/5] fnic: " michaelc
2010-08-06 8:02 ` [PATCH 5/5] ibmvfc: " michaelc
2010-08-06 15:06 ` [PATCH 4/5] fnic: " Joe Eykholt
2010-08-06 16:32 ` Mike Christie
2010-08-06 16:51 ` Mike Christie
2010-08-06 20:20 ` James Bottomley
2010-08-06 21:14 ` Mike Christie
2010-08-06 8:05 ` [PATCH 3/5] lpfc: " Mike Christie
2010-08-09 14:53 ` [PATCH 1/5] fc class: add fc host default default dev loss setting James Smart
2010-08-09 15:00 ` Mike Christie
2010-08-09 15:17 ` Mike Christie
2010-08-09 18:32 ` Andrew Vasquez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809183229.GE70144@plapp.qlogic.org \
--to=andrew.vasquez@qlogic.com \
--cc=brking@us.ibm.com \
--cc=giridhar.malavali@qlogic.com \
--cc=james.smart@emulex.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.