Re: [PATCH 1/5] fc class: add fc host default default dev loss setting

[Mike Christie <michaelc@cs.wisc.edu>]

On 08/09/2010 09:53 AM, James Smart wrote:
> Mike,
>
> why the motivation to get the dev_loss_tmo from the LLDD ? I would have
> assumed this would have become a base fc_host attribute which is rd/wr,
> the default coming from the module parameter, with the "set" propagating
> to the LLDD to change all rports to the host value (either new direct
> callback, or loop which calls rport set routine).

qla2xxx and fnic set the default/initial dev_loss_tmo based on some 
value they get from firmware.

Should I allow either where a lld can override it if they want to set it 
based on fw/hw info. If I do this should I keep the lpfc dev_loss_tmo on 
the scsi_host for backward compat and then add the fc_host r/w attr for 
it too?



>
> - james s
>
>
> michaelc@cs.wisc.edu wrote:
>> From: Mike Christie <michaelc@cs.wisc.edu>
>>
>> This patch adds a fc_host setting to store the
>> default dev_loss_tmo. It is used if the driver
>> has a callack to get the value from the LLD. If
>> the callback is not set, then we use the fc class
>> module default value.
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html