From: Mike Christie <michaelc@cs.wisc.edu>
To: Joe Eykholt <jeykholt@cisco.com>
Cc: linux-scsi@vger.kernel.org, andrew.vasquez@qlogic.com,
giridhar.malavali@qlogic.com, James.Smart@Emulex.Com,
brking@us.ibm.com
Subject: Re: [PATCH 4/5] fnic: do not reset dev_loss_tmo in slave callout
Date: Fri, 06 Aug 2010 11:32:38 -0500 [thread overview]
Message-ID: <4C5C3926.4030105@cs.wisc.edu> (raw)
In-Reply-To: <4C5C24F7.3050403@cisco.com>
On 08/06/2010 10:06 AM, Joe Eykholt wrote:
> On 8/6/10 1:02 AM, michaelc@cs.wisc.edu wrote:
>> From: Mike Christie<michaelc@cs.wisc.edu>
>>
>> This fixes a bug where the driver was resetting the
>> rport dev_loss_tmo when devices were added by adding
>> support for the get_host_def_dev_loss_tmo callout.
>
> fnic devloss timeout isn't settable on the host.
> It's only configurable from network configuration.
> So, I think this patch is unnecessary.
>
> Note that we don't have a set method, so the
> /sys file will be read-only.
Ah yeah, I see that now. I argee it is not needed to fix the bug I was
fixing. It might be nice to have it, so drivers are setting the dev loss
tmo in the same way though. It does not matter to me either way though.
next prev parent reply other threads:[~2010-08-06 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 8:02 FC: fix rport dev_loss_tmo initialization michaelc
2010-08-06 8:02 ` [PATCH 1/5] fc class: add fc host default default dev loss setting michaelc
2010-08-06 8:02 ` [PATCH 2/5] qla2xxx: do not reset dev_loss_tmo in slave callout michaelc
2010-08-06 8:02 ` [PATCH 3/5] lpfc: " michaelc
2010-08-06 8:02 ` [PATCH 4/5] fnic: " michaelc
2010-08-06 8:02 ` [PATCH 5/5] ibmvfc: " michaelc
2010-08-06 15:06 ` [PATCH 4/5] fnic: " Joe Eykholt
2010-08-06 16:32 ` Mike Christie [this message]
2010-08-06 16:51 ` Mike Christie
2010-08-06 20:20 ` James Bottomley
2010-08-06 21:14 ` Mike Christie
2010-08-06 8:05 ` [PATCH 3/5] lpfc: " Mike Christie
2010-08-09 14:53 ` [PATCH 1/5] fc class: add fc host default default dev loss setting James Smart
2010-08-09 15:00 ` Mike Christie
2010-08-09 15:17 ` Mike Christie
2010-08-09 18:32 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5C3926.4030105@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Smart@Emulex.Com \
--cc=andrew.vasquez@qlogic.com \
--cc=brking@us.ibm.com \
--cc=giridhar.malavali@qlogic.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.