From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/18 v2] char: mxser: call disable_pci_device() if
Date: Mon, 09 Aug 2010 20:27:28 +0000 [thread overview]
Message-ID: <20100809202634.GL9031@bicker> (raw)
In-Reply-To: <1281383369-13613-1-git-send-email-segooon@gmail.com>
On Mon, Aug 09, 2010 at 11:49:27PM +0400, Kulikov Vasiliy wrote:
> @@ -2564,8 +2564,11 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> /* vector */
> ioaddress = pci_resource_start(pdev, 3);
> retval = pci_request_region(pdev, 3, "mxser(vector)");
> - if (retval)
> - goto err_relio;
> + if (retval) {
> + pci_release_region(pdev, 2);
> + brd->info = NULL;
> + goto err_release;
This should just be goto err_null. The original err_null had a bug that
it didn't call pci_release_region(pdev, 2); but you already fixed that.
regards,
dan carpenter
> + }
> brd->vector = ioaddress;
>
> /* irq */
> @@ -2616,10 +2619,13 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> pci_set_drvdata(pdev, brd);
>
> return 0;
> -err_relio:
> - pci_release_region(pdev, 2);
> err_null:
> brd->info = NULL;
> + pci_release_region(pdev, 2);
> +err_release:
> + pci_release_region(pdev, 3);
> +err_disable:
> + pci_disable_device(pdev);
> err:
> return retval;
> #else
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed
Date: Mon, 9 Aug 2010 22:27:28 +0200 [thread overview]
Message-ID: <20100809202634.GL9031@bicker> (raw)
In-Reply-To: <1281383369-13613-1-git-send-email-segooon@gmail.com>
On Mon, Aug 09, 2010 at 11:49:27PM +0400, Kulikov Vasiliy wrote:
> @@ -2564,8 +2564,11 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> /* vector */
> ioaddress = pci_resource_start(pdev, 3);
> retval = pci_request_region(pdev, 3, "mxser(vector)");
> - if (retval)
> - goto err_relio;
> + if (retval) {
> + pci_release_region(pdev, 2);
> + brd->info = NULL;
> + goto err_release;
This should just be goto err_null. The original err_null had a bug that
it didn't call pci_release_region(pdev, 2); but you already fixed that.
regards,
dan carpenter
> + }
> brd->vector = ioaddress;
>
> /* irq */
> @@ -2616,10 +2619,13 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> pci_set_drvdata(pdev, brd);
>
> return 0;
> -err_relio:
> - pci_release_region(pdev, 2);
> err_null:
> brd->info = NULL;
> + pci_release_region(pdev, 2);
> +err_release:
> + pci_release_region(pdev, 3);
> +err_disable:
> + pci_disable_device(pdev);
> err:
> return retval;
> #else
next prev parent reply other threads:[~2010-08-09 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 19:49 [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
2010-08-09 19:49 ` Kulikov Vasiliy
2010-08-09 20:19 ` [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() Jiri Slaby
2010-08-09 20:19 ` [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed Jiri Slaby
2010-08-09 20:19 ` [PATCH 1/1] Char: mxser, call pci_disable_device from probe/remove Jiri Slaby
2010-08-09 20:19 ` Jiri Slaby
2010-08-09 20:23 ` [PATCH v2 " Jiri Slaby
2010-08-09 20:23 ` Jiri Slaby
2010-08-09 20:27 ` Dan Carpenter [this message]
2010-08-09 20:27 ` [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809202634.GL9031@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.