From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe()
Date: Mon, 09 Aug 2010 20:19:06 +0000 [thread overview]
Message-ID: <4C6062BA.4070009@gmail.com> (raw)
In-Reply-To: <1281383369-13613-1-git-send-email-segooon@gmail.com>
On 08/09/2010 09:49 PM, Kulikov Vasiliy wrote:
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2564,8 +2564,11 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> /* vector */
> ioaddress = pci_resource_start(pdev, 3);
> retval = pci_request_region(pdev, 3, "mxser(vector)");
> - if (retval)
> - goto err_relio;
> + if (retval) {
> + pci_release_region(pdev, 2);
> + brd->info = NULL;
> + goto err_release;
> + }
Hi, I'm still not happy with this patch. First, it omits mxser_remove,
where pci_disable_device is not called too. Second, the fail-paths tail
should be reorganized so that we can jump there appropriately. I'll
reply with my version of the patch, if you don't mind.
thanks,
--
js
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Kulikov Vasiliy <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed
Date: Mon, 09 Aug 2010 22:19:06 +0200 [thread overview]
Message-ID: <4C6062BA.4070009@gmail.com> (raw)
In-Reply-To: <1281383369-13613-1-git-send-email-segooon@gmail.com>
On 08/09/2010 09:49 PM, Kulikov Vasiliy wrote:
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -2564,8 +2564,11 @@ static int __devinit mxser_probe(struct pci_dev *pdev,
> /* vector */
> ioaddress = pci_resource_start(pdev, 3);
> retval = pci_request_region(pdev, 3, "mxser(vector)");
> - if (retval)
> - goto err_relio;
> + if (retval) {
> + pci_release_region(pdev, 2);
> + brd->info = NULL;
> + goto err_release;
> + }
Hi, I'm still not happy with this patch. First, it omits mxser_remove,
where pci_disable_device is not called too. Second, the fail-paths tail
should be reorganized so that we can jump there appropriately. I'll
reply with my version of the patch, if you don't mind.
thanks,
--
js
next prev parent reply other threads:[~2010-08-09 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-09 19:49 [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed Kulikov Vasiliy
2010-08-09 19:49 ` Kulikov Vasiliy
2010-08-09 20:19 ` Jiri Slaby [this message]
2010-08-09 20:19 ` Jiri Slaby
2010-08-09 20:19 ` [PATCH 1/1] Char: mxser, call pci_disable_device from probe/remove Jiri Slaby
2010-08-09 20:19 ` Jiri Slaby
2010-08-09 20:23 ` [PATCH v2 " Jiri Slaby
2010-08-09 20:23 ` Jiri Slaby
2010-08-09 20:27 ` [PATCH 02/18 v2] char: mxser: call disable_pci_device() if Dan Carpenter
2010-08-09 20:27 ` [PATCH 02/18 v2] char: mxser: call disable_pci_device() if pci_probe() failed Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6062BA.4070009@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.