From: Joel Becker <Joel.Becker@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>, "Ted Ts'o" <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 1/3] ext3/ext4: Factor out disk addressability check
Date: Mon, 16 Aug 2010 02:21:15 -0700 [thread overview]
Message-ID: <20100816092114.GB9061@mail.oracle.com> (raw)
In-Reply-To: <4C68B244.6080406@redhat.com>
On Sun, Aug 15, 2010 at 10:36:36PM -0500, Eric Sandeen wrote:
> Er, yeah. I had 32 bits in my head since that's the case we're
> checking for... whoops.
>
> So I guess your
>
> ... ||
> ((last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits)) >
> (pgoff_t)(!0ULL))) {
>
> is right :) (my feeble brain has a hard time reading that, though, TBH)
Well, note the bug in my quickly typed version: "(!0ULL)" vs
"(~0ULL)". How about:
u64 last_fs_page = last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits);
... ||
(last_fs_page > (pgoff_t)(~0ULL))) {
Is that more readable?
Joel
--
Life's Little Instruction Book #99
"Think big thoughts, but relish small pleasures."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <Joel.Becker@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Andreas Dilger <adilger@dilger.ca>, Ted Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check
Date: Mon, 16 Aug 2010 02:21:15 -0700 [thread overview]
Message-ID: <20100816092114.GB9061@mail.oracle.com> (raw)
In-Reply-To: <4C68B244.6080406@redhat.com>
On Sun, Aug 15, 2010 at 10:36:36PM -0500, Eric Sandeen wrote:
> Er, yeah. I had 32 bits in my head since that's the case we're
> checking for... whoops.
>
> So I guess your
>
> ... ||
> ((last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits)) >
> (pgoff_t)(!0ULL))) {
>
> is right :) (my feeble brain has a hard time reading that, though, TBH)
Well, note the bug in my quickly typed version: "(!0ULL)" vs
"(~0ULL)". How about:
u64 last_fs_page = last_fs_block >> (PAGE_CACHE_SHIFT - blocksize_bits);
... ||
(last_fs_page > (pgoff_t)(~0ULL))) {
Is that more readable?
Joel
--
Life's Little Instruction Book #99
"Think big thoughts, but relish small pleasures."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2010-08-16 9:21 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 22:03 [PATCH 1/3] ext3/ext4: Factor out disk addressability check Patrick J. LoPresti
2010-07-22 22:03 ` [Ocfs2-devel] " Patrick J. LoPresti
2010-07-22 22:04 ` [PATCH 2/3] JBD2: Allow feature checks before journal recovery Patrick J. LoPresti
2010-07-22 22:04 ` [Ocfs2-devel] " Patrick J. LoPresti
2010-07-22 22:05 ` [PATCH 3/3] OCFS2: Allow huge (> 16 TiB) volumes to mount Patrick J. LoPresti
2010-07-22 22:05 ` [Ocfs2-devel] " Patrick J. LoPresti
2010-08-12 17:43 ` [Ocfs2-devel] [PATCH 2/3] JBD2: Allow feature checks before journal recovery Joel Becker
2010-08-12 17:43 ` Joel Becker
2010-08-12 23:03 ` Joel Becker
2010-08-12 23:03 ` Joel Becker
2010-08-12 23:03 ` Joel Becker
2010-08-12 23:03 ` [Ocfs2-devel] " Joel Becker
2010-08-12 23:03 ` Joel Becker
2010-08-13 3:39 ` Ted Ts'o
2010-08-13 3:39 ` Ted Ts'o
2010-08-13 7:17 ` Joel Becker
2010-08-13 7:17 ` Joel Becker
2010-08-13 7:17 ` Joel Becker
2010-08-10 15:15 ` [Ocfs2-devel] [PATCH 1/3] ext3/ext4: Factor out disk addressability check Joel Becker
2010-08-10 15:15 ` Joel Becker
2010-08-12 17:42 ` Joel Becker
2010-08-12 17:42 ` Joel Becker
2010-08-12 18:45 ` Andreas Dilger
2010-08-12 18:45 ` Andreas Dilger
2010-08-12 20:15 ` Joel Becker
2010-08-12 20:15 ` Joel Becker
2010-08-12 21:32 ` Andreas Dilger
2010-08-12 21:32 ` Andreas Dilger
2010-08-12 22:29 ` Joel Becker
2010-08-12 22:29 ` Joel Becker
2010-08-12 23:07 ` Andreas Dilger
2010-08-12 23:07 ` Andreas Dilger
2010-08-12 23:13 ` Joel Becker
2010-08-12 23:13 ` Joel Becker
2010-08-13 16:30 ` Jan Kara
2010-08-13 16:30 ` Jan Kara
2010-08-13 20:47 ` Joel Becker
2010-08-13 20:47 ` Joel Becker
2010-08-13 22:52 ` Joel Becker
2010-08-13 22:52 ` Joel Becker
2010-08-16 15:09 ` Jan Kara
2010-08-16 15:09 ` Jan Kara
2010-08-15 17:19 ` Eric Sandeen
2010-08-15 17:19 ` Eric Sandeen
2010-08-16 2:54 ` Joel Becker
2010-08-16 2:54 ` [Ocfs2-devel] " Joel Becker
2010-08-16 3:36 ` Eric Sandeen
2010-08-16 3:36 ` Eric Sandeen
2010-08-16 9:21 ` Joel Becker [this message]
2010-08-16 9:21 ` Joel Becker
2010-08-16 14:44 ` Eric Sandeen
2010-08-16 14:44 ` Eric Sandeen
2010-08-16 19:13 ` Joel Becker
2010-08-16 19:13 ` [Ocfs2-devel] " Joel Becker
2010-08-16 19:21 ` Jan Kara
2010-08-16 19:21 ` Jan Kara
2010-08-16 20:45 ` Joel Becker
2010-08-16 20:45 ` [Ocfs2-devel] " Joel Becker
2010-08-16 14:44 ` Eric Sandeen
2010-08-12 23:03 ` Joel Becker
2010-08-12 23:03 ` [Ocfs2-devel] " Joel Becker
2010-08-13 3:39 ` Ted Ts'o
2010-08-13 3:39 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816092114.GB9061@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=adilger@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.