From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH w-t] iwlwifi: rewrite iwl-scan.c to avoid race conditions
Date: Thu, 2 Sep 2010 10:47:21 +0200 [thread overview]
Message-ID: <20100902084720.GA2372@redhat.com> (raw)
In-Reply-To: <1283357075.4124.11.camel@jlt3.sipsolutions.net>
On Wed, Sep 01, 2010 at 06:04:35PM +0200, Johannes Berg wrote:
> > Cancel at the end of iwl_cancel_scan_deferred_work() is for case
> > when we still get notification from f/w and clear STATUS_SCAN_HW bit in
> > iwl_rx_scan_complete_notif. This can happen when firmware is in some
> > sane state but we do restart (for example: when debugfs force_reset
> > file was used).
> >
> > For the same reason we need have to iwl_bg_scan_completed allow to run
> > in parallel with iwl_bg_restart. To complete scanning when performing
> > restart, but f/w is responsible.
>
> I think you mean "responsive"? Otherwise what you're saying doesn't make
> much sense to me?
Ehh, yes responsive.
> But they all take the mutex, so they can't run in parallel anyway. So it
> only becomes an ordering issue, no?
Mutex is not taken all the time in iwl_bg_restart.
Stanislaw
next prev parent reply other threads:[~2010-09-02 8:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 15:00 [PATCH w-t] iwlwifi: rewrite iwl-scan.c to avoid race conditions Stanislaw Gruszka
2010-09-01 10:59 ` Johannes Berg
2010-09-01 11:58 ` Stanislaw Gruszka
2010-09-01 12:41 ` Johannes Berg
2010-09-01 14:16 ` Stanislaw Gruszka
2010-09-01 14:26 ` Johannes Berg
2010-09-01 15:24 ` Stanislaw Gruszka
2010-09-01 16:04 ` Johannes Berg
2010-09-02 8:47 ` Stanislaw Gruszka [this message]
2010-09-02 9:21 ` Johannes Berg
2010-09-02 10:52 ` Stanislaw Gruszka
2010-09-01 12:52 ` Johannes Berg
2010-09-01 14:16 ` Stanislaw Gruszka
2010-09-01 14:24 ` Johannes Berg
2010-09-02 9:36 ` Johannes Berg
2010-09-02 11:07 ` Stanislaw Gruszka
2010-09-02 11:36 ` Johannes Berg
2010-09-02 11:42 ` Stanislaw Gruszka
2010-09-02 10:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100902084720.GA2372@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.