* [PATCH] MIPS: N32: Fix getdents64 syscall for n32
@ 2010-09-03 8:15 Bernhard Walle
2010-09-03 8:42 ` Christoph Hellwig
2010-09-19 23:51 ` Ralf Baechle
0 siblings, 2 replies; 10+ messages in thread
From: Bernhard Walle @ 2010-09-03 8:15 UTC (permalink / raw)
To: linux-mips; +Cc: ralf, ddaney, akpm, ebiederm, hch, linux-kernel
Commit 31c984a5acabea5d8c7224dc226453022be46f33 introduced a new syscall
getdents64. However, in the syscall table, the new syscall still refers
to the old getdents which doesn't work.
The problem appeared with a system that uses the eglibc 2.12-r11187
(that utilizes that new syscall) is very confused. The fix has been
tested with that eglibc version.
Signed-off-by: Bernhard Walle <walle@corscience.de>
---
arch/mips/kernel/scall64-n32.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index a3d6613..dfa8cbc 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -419,5 +419,5 @@ EXPORT(sysn32_call_table)
PTR sys_perf_event_open
PTR sys_accept4
PTR compat_sys_recvmmsg
- PTR sys_getdents
+ PTR sys_getdents64
.size sysn32_call_table,.-sysn32_call_table
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 8:15 [PATCH] MIPS: N32: Fix getdents64 syscall for n32 Bernhard Walle
@ 2010-09-03 8:42 ` Christoph Hellwig
2010-09-03 8:53 ` Arnaud Patard
2010-09-19 23:51 ` Ralf Baechle
1 sibling, 1 reply; 10+ messages in thread
From: Christoph Hellwig @ 2010-09-03 8:42 UTC (permalink / raw)
To: Bernhard Walle
Cc: linux-mips, ralf, ddaney, akpm, ebiederm, hch, linux-kernel
I'm not sure why people suddenly started Ccing me on utterly random
patches, but could you guys please bloody stop it? Thanks!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 8:42 ` Christoph Hellwig
@ 2010-09-03 8:53 ` Arnaud Patard
2010-09-03 8:55 ` Christoph Hellwig
2010-09-03 9:13 ` Bernhard Walle
0 siblings, 2 replies; 10+ messages in thread
From: Arnaud Patard @ 2010-09-03 8:53 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Bernhard Walle, linux-mips, ralf, ddaney, akpm, ebiederm,
linux-kernel
Christoph Hellwig <hch@lst.de> writes:
Hi,
> I'm not sure why people suddenly started Ccing me on utterly random
> patches, but could you guys please bloody stop it? Thanks!
I guess the explanation is the one below :
$ ./scripts/get_maintainer.pl -f arch/mips/kernel/scall64-n32.S
Ralf Baechle <ralf@linux-mips.org>
David Daney <ddaney@caviumnetworks.com>
Andrew Morton <akpm@linux-foundation.org>
"Eric W. Biederman" <ebiederm@xmission.com>
Christoph Hellwig <hch@lst.de>
linux-mips@linux-mips.org
linux-kernel@vger.kernel.org
Arnaud
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 8:53 ` Arnaud Patard
@ 2010-09-03 8:55 ` Christoph Hellwig
2010-09-03 9:13 ` Bernhard Walle
1 sibling, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2010-09-03 8:55 UTC (permalink / raw)
To: Arnaud Patard
Cc: Christoph Hellwig, Bernhard Walle, linux-mips, ralf, ddaney, akpm,
ebiederm, linux-kernel
On Fri, Sep 03, 2010 at 10:53:31AM +0200, Arnaud Patard wrote:
> Christoph Hellwig <hch@lst.de> writes:
>
> Hi,
>
> > I'm not sure why people suddenly started Ccing me on utterly random
> > patches, but could you guys please bloody stop it? Thanks!
>
> I guess the explanation is the one below :
>
> $ ./scripts/get_maintainer.pl -f arch/mips/kernel/scall64-n32.S
I'm certainly not the maintainer of it, nor anything near it. Whoever
wrote such a stupid script really needs to be beaten up seriously.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 8:53 ` Arnaud Patard
2010-09-03 8:55 ` Christoph Hellwig
@ 2010-09-03 9:13 ` Bernhard Walle
2010-09-03 10:01 ` Ralf Baechle
1 sibling, 1 reply; 10+ messages in thread
From: Bernhard Walle @ 2010-09-03 9:13 UTC (permalink / raw)
To: Arnaud Patard
Cc: Christoph Hellwig, linux-mips, ralf, ddaney, akpm, ebiederm,
linux-kernel
Am 03.09.2010 10:53, schrieb Arnaud Patard:
>
> I guess the explanation is the one below :
>
> $ ./scripts/get_maintainer.pl -f arch/mips/kernel/scall64-n32.S
> Ralf Baechle<ralf@linux-mips.org>
> David Daney<ddaney@caviumnetworks.com>
> Andrew Morton<akpm@linux-foundation.org>
> "Eric W. Biederman"<ebiederm@xmission.com>
> Christoph Hellwig<hch@lst.de>
> linux-mips@linux-mips.org
> linux-kernel@vger.kernel.org
Yes, I just used that script and trusted the results. Sorry for that.
Regards,
Bernhard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 9:13 ` Bernhard Walle
@ 2010-09-03 10:01 ` Ralf Baechle
2010-09-03 11:27 ` Bernhard Walle
0 siblings, 1 reply; 10+ messages in thread
From: Ralf Baechle @ 2010-09-03 10:01 UTC (permalink / raw)
To: Bernhard Walle
Cc: Arnaud Patard, Christoph Hellwig, linux-mips, ddaney, akpm,
ebiederm, linux-kernel
On Fri, Sep 03, 2010 at 11:13:30AM +0200, Bernhard Walle wrote:
> >I guess the explanation is the one below :
> >
> >$ ./scripts/get_maintainer.pl -f arch/mips/kernel/scall64-n32.S
> >Ralf Baechle<ralf@linux-mips.org>
> >David Daney<ddaney@caviumnetworks.com>
> >Andrew Morton<akpm@linux-foundation.org>
> >"Eric W. Biederman"<ebiederm@xmission.com>
> >Christoph Hellwig<hch@lst.de>
> >linux-mips@linux-mips.org
> >linux-kernel@vger.kernel.org
>
> Yes, I just used that script and trusted the results. Sorry for that.
I'm certainly not interested on getting cc'ed half of I2C patches or
Itanium framebuffer drivers. The defaults are idiotic. Anybody who
touched a file in the past year will get spammed.
Throw in a --nogit to disable the history search and you get:
Ralf Baechle <ralf@linux-mips.org>
linux-mips@linux-mips.org
linux-kernel@vger.kernel.org
cc'ing lkml is a bit pointless in many cases as well but the simplistic
filename pattern system in MAINTAINERS doesn't allow entries entries to
match only if no other previous entries are matching.
Ralf
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 10:01 ` Ralf Baechle
@ 2010-09-03 11:27 ` Bernhard Walle
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2010-09-03 11:27 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
Am 03.09.2010 12:01, schrieb Ralf Baechle:
>
> I'm certainly not interested on getting cc'ed half of I2C patches or
> Itanium framebuffer drivers. The defaults are idiotic. Anybody who
> touched a file in the past year will get spammed.
>
> Throw in a --nogit to disable the history search and you get:
Ok, I will use that in the future. But what about the patch itself?
Regards,
Bernhard
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-03 8:15 [PATCH] MIPS: N32: Fix getdents64 syscall for n32 Bernhard Walle
2010-09-03 8:42 ` Christoph Hellwig
@ 2010-09-19 23:51 ` Ralf Baechle
2010-09-21 7:49 ` Bernhard Walle
1 sibling, 1 reply; 10+ messages in thread
From: Ralf Baechle @ 2010-09-19 23:51 UTC (permalink / raw)
To: Bernhard Walle; +Cc: linux-mips, ddaney, akpm, ebiederm, hch, linux-kernel
On Fri, Sep 03, 2010 at 10:15:34AM +0200, Bernhard Walle wrote:
> Commit 31c984a5acabea5d8c7224dc226453022be46f33 introduced a new syscall
> getdents64. However, in the syscall table, the new syscall still refers
> to the old getdents which doesn't work.
>
> The problem appeared with a system that uses the eglibc 2.12-r11187
> (that utilizes that new syscall) is very confused. The fix has been
> tested with that eglibc version.
Thanks Bernhard!
Ralf
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] MIPS: N32: Fix getdents64 syscall for n32
2010-09-19 23:51 ` Ralf Baechle
@ 2010-09-21 7:49 ` Bernhard Walle
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2010-09-21 7:49 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, linux-kernel
Am 20.09.2010 01:51, schrieb Ralf Baechle:
> On Fri, Sep 03, 2010 at 10:15:34AM +0200, Bernhard Walle wrote:
>
>> Commit 31c984a5acabea5d8c7224dc226453022be46f33 introduced a new syscall
>> getdents64. However, in the syscall table, the new syscall still refers
>> to the old getdents which doesn't work.
>>
>> The problem appeared with a system that uses the eglibc 2.12-r11187
>> (that utilizes that new syscall) is very confused. The fix has been
>> tested with that eglibc version.
>
> Thanks Bernhard!
Wouldn't it make sense to put that fix also in the stable tree (2.6.35.6)?
Regards,
Bernhard
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] MIPS: N32: Fix getdents64 syscall for n32
@ 2010-09-08 7:35 Bernhard Walle
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2010-09-08 7:35 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, linux-kernel
Commit 31c984a5acabea5d8c7224dc226453022be46f33 introduced a new syscall
getdents64. However, in the syscall table, the new syscall still refers
to the old getdents which doesn't work.
The problem appeared with a system that uses the eglibc 2.12-r11187
(that utilizes that new syscall) is very confused. The fix has been
tested with that eglibc version.
Signed-off-by: Bernhard Walle <walle@corscience.de>
---
arch/mips/kernel/scall64-n32.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
index a3d6613..dfa8cbc 100644
--- a/arch/mips/kernel/scall64-n32.S
+++ b/arch/mips/kernel/scall64-n32.S
@@ -419,5 +419,5 @@ EXPORT(sysn32_call_table)
PTR sys_perf_event_open
PTR sys_accept4
PTR compat_sys_recvmmsg
- PTR sys_getdents
+ PTR sys_getdents64
.size sysn32_call_table,.-sysn32_call_table
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-09-21 7:50 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 8:15 [PATCH] MIPS: N32: Fix getdents64 syscall for n32 Bernhard Walle
2010-09-03 8:42 ` Christoph Hellwig
2010-09-03 8:53 ` Arnaud Patard
2010-09-03 8:55 ` Christoph Hellwig
2010-09-03 9:13 ` Bernhard Walle
2010-09-03 10:01 ` Ralf Baechle
2010-09-03 11:27 ` Bernhard Walle
2010-09-19 23:51 ` Ralf Baechle
2010-09-21 7:49 ` Bernhard Walle
-- strict thread matches above, loose matches on Subject: below --
2010-09-08 7:35 Bernhard Walle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.