From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support
Date: Mon, 6 Sep 2010 11:25:58 +0100 [thread overview]
Message-ID: <20100906102557.GE10367@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <Pine.LNX.4.64.1009060932430.20387@axis700.grange>
On Mon, Sep 06, 2010 at 10:27:56AM +0200, Guennadi Liakhovetski wrote:
> On Tue, 31 Aug 2010, Kuninori Morimoto wrote:
> > +static int sh_hdmi_snd_write(struct snd_soc_codec *codec,
> > + unsigned int reg,
> > + unsigned int value)
> > +{
> > + struct sh_hdmi *hdmi = snd_soc_codec_get_drvdata(codec);
> > +
> > + hdmi_write(hdmi, value, reg);
> > + return 0;
> > +}
> Are these two actually needed? As long as you don't have a register cache
> - no need for these?
Something needs to translate the ASoC register I/O functions into what
the HDMI layer code is expecting.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>,
Linux-SH <linux-sh@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support
Date: Mon, 06 Sep 2010 10:25:58 +0000 [thread overview]
Message-ID: <20100906102557.GE10367@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <Pine.LNX.4.64.1009060932430.20387@axis700.grange>
On Mon, Sep 06, 2010 at 10:27:56AM +0200, Guennadi Liakhovetski wrote:
> On Tue, 31 Aug 2010, Kuninori Morimoto wrote:
> > +static int sh_hdmi_snd_write(struct snd_soc_codec *codec,
> > + unsigned int reg,
> > + unsigned int value)
> > +{
> > + struct sh_hdmi *hdmi = snd_soc_codec_get_drvdata(codec);
> > +
> > + hdmi_write(hdmi, value, reg);
> > + return 0;
> > +}
> Are these two actually needed? As long as you don't have a register cache
> - no need for these?
Something needs to translate the ASoC register I/O functions into what
the HDMI layer code is expecting.
next prev parent reply other threads:[~2010-09-06 10:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 5:45 [PATCH 0/4 v2] Add FSI - HDMI support V2 Kuninori Morimoto
2010-08-31 5:45 ` Kuninori Morimoto
2010-08-31 5:46 ` [PATCH 1/4 v2] fbdev: sh-mobile: Add HDMI sound type selection Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:19 ` Mark Brown
2010-09-01 10:19 ` Mark Brown
2010-09-06 7:32 ` Guennadi Liakhovetski
2010-09-06 7:32 ` Guennadi Liakhovetski
2010-09-06 9:49 ` Kuninori Morimoto
2010-09-06 9:49 ` Kuninori Morimoto
2010-08-31 5:46 ` [PATCH 2/4 v2] ASoC: fsi-codec: Add FSI - HDMI support Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:20 ` Mark Brown
2010-09-01 10:20 ` Mark Brown
2010-09-06 9:17 ` Guennadi Liakhovetski
2010-09-06 9:17 ` Guennadi Liakhovetski
2010-08-31 5:46 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound support Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:23 ` Mark Brown
2010-09-01 10:23 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound Mark Brown
2010-09-06 10:07 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound support Guennadi Liakhovetski
2010-09-06 10:07 ` Guennadi Liakhovetski
2010-09-09 3:56 ` Kuninori Morimoto
2010-09-09 21:04 ` Guennadi Liakhovetski
2010-08-31 5:47 ` [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi " Kuninori Morimoto
2010-08-31 5:47 ` Kuninori Morimoto
2010-09-01 10:20 ` Mark Brown
2010-09-01 10:20 ` Mark Brown
2010-09-06 8:27 ` Guennadi Liakhovetski
2010-09-06 8:27 ` Guennadi Liakhovetski
2010-09-06 10:25 ` Mark Brown [this message]
2010-09-06 10:25 ` Mark Brown
2010-09-07 7:11 ` Guennadi Liakhovetski
2010-09-07 7:11 ` Guennadi Liakhovetski
2010-09-07 9:40 ` Mark Brown
2010-09-07 9:40 ` Mark Brown
2010-09-07 9:56 ` Guennadi Liakhovetski
2010-09-07 9:56 ` Guennadi Liakhovetski
2010-09-07 10:02 ` Mark Brown
2010-09-07 10:02 ` Mark Brown
2010-09-07 3:56 ` Kuninori Morimoto
2010-09-07 3:56 ` Kuninori Morimoto
2010-08-31 9:57 ` [alsa-devel] [PATCH 0/4 v2] Add FSI - HDMI support V2 Liam Girdwood
2010-08-31 9:57 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906102557.GE10367@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=g.liakhovetski@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.