From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Paul Mundt <lethal@linux-sh.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux-SH <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support
Date: Tue, 7 Sep 2010 11:02:55 +0100 [thread overview]
Message-ID: <20100907100255.GC7886@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <Pine.LNX.4.64.1009071152330.1345@axis700.grange>
On Tue, Sep 07, 2010 at 11:56:34AM +0200, Guennadi Liakhovetski wrote:
> On Tue, 7 Sep 2010, Mark Brown wrote:
> > Could you please be more explicit here? Register I/O needs to happen
> > somehow...
> Sorry, maybe I am missing something, but my understanding is, that the
> ASoC core knows nothing about codec's specific register layout, so, the
> core itself cannot initiate any register IO. So, I presume, there can be
> only two instances, that can do that - the codec driver itself and some
> user-space (debugging) programs. The driver doesn't use cached register
> accesses, so, it can access the registers directly, and it doesn't have to
> provide an ability to the user-space to access registers - if it chooses
> so. So, I don't see, who should be trying to use generic ASoC register
> access routines here.
All register I/O, cached or not, is supposed to go through the register
I/O operations. Any cache is abstraced away within those operations.
Since the driver presumably needs do do some I/O (even if only in the
hw_params() you have identified as missing) I would expect it to provide
register I/O functionality.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Paul Mundt <lethal@linux-sh.org>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Linux-SH <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi sound support
Date: Tue, 07 Sep 2010 10:02:55 +0000 [thread overview]
Message-ID: <20100907100255.GC7886@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <Pine.LNX.4.64.1009071152330.1345@axis700.grange>
On Tue, Sep 07, 2010 at 11:56:34AM +0200, Guennadi Liakhovetski wrote:
> On Tue, 7 Sep 2010, Mark Brown wrote:
> > Could you please be more explicit here? Register I/O needs to happen
> > somehow...
> Sorry, maybe I am missing something, but my understanding is, that the
> ASoC core knows nothing about codec's specific register layout, so, the
> core itself cannot initiate any register IO. So, I presume, there can be
> only two instances, that can do that - the codec driver itself and some
> user-space (debugging) programs. The driver doesn't use cached register
> accesses, so, it can access the registers directly, and it doesn't have to
> provide an ability to the user-space to access registers - if it chooses
> so. So, I don't see, who should be trying to use generic ASoC register
> access routines here.
All register I/O, cached or not, is supposed to go through the register
I/O operations. Any cache is abstraced away within those operations.
Since the driver presumably needs do do some I/O (even if only in the
hw_params() you have identified as missing) I would expect it to provide
register I/O functionality.
next prev parent reply other threads:[~2010-09-07 10:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 5:45 [PATCH 0/4 v2] Add FSI - HDMI support V2 Kuninori Morimoto
2010-08-31 5:45 ` Kuninori Morimoto
2010-08-31 5:46 ` [PATCH 1/4 v2] fbdev: sh-mobile: Add HDMI sound type selection Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:19 ` Mark Brown
2010-09-01 10:19 ` Mark Brown
2010-09-06 7:32 ` Guennadi Liakhovetski
2010-09-06 7:32 ` Guennadi Liakhovetski
2010-09-06 9:49 ` Kuninori Morimoto
2010-09-06 9:49 ` Kuninori Morimoto
2010-08-31 5:46 ` [PATCH 2/4 v2] ASoC: fsi-codec: Add FSI - HDMI support Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:20 ` Mark Brown
2010-09-01 10:20 ` Mark Brown
2010-09-06 9:17 ` Guennadi Liakhovetski
2010-09-06 9:17 ` Guennadi Liakhovetski
2010-08-31 5:46 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound support Kuninori Morimoto
2010-08-31 5:46 ` Kuninori Morimoto
2010-09-01 10:23 ` Mark Brown
2010-09-01 10:23 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound Mark Brown
2010-09-06 10:07 ` [PATCH 4/4 v2] ARM: mach-shmobile: ap4evb: Add HDMI sound support Guennadi Liakhovetski
2010-09-06 10:07 ` Guennadi Liakhovetski
2010-09-09 3:56 ` Kuninori Morimoto
2010-09-09 21:04 ` Guennadi Liakhovetski
2010-08-31 5:47 ` [PATCH 2/4 v2] ASoC: Add sh_mobile_hdmi " Kuninori Morimoto
2010-08-31 5:47 ` Kuninori Morimoto
2010-09-01 10:20 ` Mark Brown
2010-09-01 10:20 ` Mark Brown
2010-09-06 8:27 ` Guennadi Liakhovetski
2010-09-06 8:27 ` Guennadi Liakhovetski
2010-09-06 10:25 ` Mark Brown
2010-09-06 10:25 ` Mark Brown
2010-09-07 7:11 ` Guennadi Liakhovetski
2010-09-07 7:11 ` Guennadi Liakhovetski
2010-09-07 9:40 ` Mark Brown
2010-09-07 9:40 ` Mark Brown
2010-09-07 9:56 ` Guennadi Liakhovetski
2010-09-07 9:56 ` Guennadi Liakhovetski
2010-09-07 10:02 ` Mark Brown [this message]
2010-09-07 10:02 ` Mark Brown
2010-09-07 3:56 ` Kuninori Morimoto
2010-09-07 3:56 ` Kuninori Morimoto
2010-08-31 9:57 ` [alsa-devel] [PATCH 0/4 v2] Add FSI - HDMI support V2 Liam Girdwood
2010-08-31 9:57 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100907100255.GC7886@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=g.liakhovetski@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.