From: Denys Dmytriyenko <denis@denix.org>
To: openembedded-devel@lists.openembedded.org
Cc: tsc@openembedded.org
Subject: Re: [PATCH] base.bbclass: fix soc-family test
Date: Fri, 10 Sep 2010 14:50:04 -0400 [thread overview]
Message-ID: <20100910185004.GF28148@denix.org> (raw)
In-Reply-To: <4C88EC2B.2090208@balister.org>
On Thu, Sep 09, 2010 at 10:16:11AM -0400, Philip Balister wrote:
> On 09/09/2010 10:06 AM, Chris Larson wrote:
>> On Thu, Sep 9, 2010 at 3:11 AM, Frans Meulenbroeks<
>> fransmeulenbroeks@gmail.com> wrote:
>>
>>> Signed-off-by: Chase Maupin<chase.maupin@ti.com>
>>> Acked-by: Denys Dmytriyenko<denys@ti.com>
>>> Acked-by: Koen Kooi<k-kooi@ti.com>
>>> Signed-off-by: Koen Kooi<koen@openembedded.org>
>>>
>>> I would suggest modifying the commit policy disallowing these kind of
>>> things, saying the two Ack's must be from two developers not
>>> affiliated with the same company.
>>>
>>
>> I'd agree with this quite strongly. I'm generally pretty careful to let
>> others review the changes from my coworkers, to avoid any bias.
Chris,
Not to point any fingers, but mishaps happen and numerous reverts would be a
living proof of that in the repository... :) Nobody's perfect.
> This would be a good topic for OEDEM.
>
> For the record, I am really happy to see the .com people actively
> participating in the the OE project. I am also glad that they are pushing
> stuff into .dev and not keeping it in private repositories. This is a very
> good thing.
As I just replied to Frans' post in this thread - as a company, we are trying
to follow review procedures closely and give enough time for feedback on the
patches. I personally would like to apologize for the misunderstanding and
promise to do a better job in the future.
As an active OE e.V. member on the other hand, I'm all in favor of this
modification to the commit policy, as long as there is time limit on review
period and if there are no strong objections, it can be pushed even if only
acked by the same company. Let's discuss it further and vote at OEDEM.
--
Denys
next prev parent reply other threads:[~2010-09-10 18:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 18:52 [PATCH] base.bbclass: fix soc-family test Frans Meulenbroeks
2010-09-09 7:11 ` Frans Meulenbroeks
2010-09-09 9:30 ` Phil Blundell
2010-09-09 10:07 ` Leon Woestenberg
2010-09-09 10:11 ` Frans Meulenbroeks
2010-09-09 12:20 ` Maupin, Chase
2010-09-09 13:16 ` Frans Meulenbroeks
2010-09-10 18:37 ` Denys Dmytriyenko
2010-09-10 21:20 ` Phil Blundell
2010-09-10 20:27 ` Maupin, Chase
2010-09-10 22:53 ` Phil Blundell
2010-09-11 11:33 ` Michael 'Mickey' Lauer
2010-09-09 14:06 ` Chris Larson
2010-09-09 14:16 ` Philip Balister
2010-09-10 18:50 ` Denys Dmytriyenko [this message]
2010-09-10 18:55 ` Chris Larson
2010-09-10 19:19 ` Denys Dmytriyenko
2010-09-10 20:38 ` Tom Rini
2010-09-10 22:26 ` Phil Blundell
2010-09-09 12:13 ` Maupin, Chase
2010-09-09 12:30 ` Maupin, Chase
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910185004.GF28148@denix.org \
--to=denis@denix.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=tsc@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.