Re: [PATCH] base.bbclass: fix soc-family test

[Tom Rini <tom_rini@mentor.com>]

Denys Dmytriyenko wrote:
> On Thu, Sep 09, 2010 at 10:16:11AM -0400, Philip Balister wrote:
>> On 09/09/2010 10:06 AM, Chris Larson wrote:
>>> On Thu, Sep 9, 2010 at 3:11 AM, Frans Meulenbroeks<
>>> fransmeulenbroeks@gmail.com>  wrote:
>>>
>>>> Signed-off-by: Chase Maupin<chase.maupin@ti.com>
>>>> Acked-by: Denys Dmytriyenko<denys@ti.com>
>>>> Acked-by: Koen Kooi<k-kooi@ti.com>
>>>> Signed-off-by: Koen Kooi<koen@openembedded.org>
>>>>
>>>> I would suggest modifying the commit policy disallowing these kind of
>>>> things, saying the two Ack's must be from two developers not
>>>> affiliated with the same company.
>>>>
>>> I'd agree with this quite strongly.  I'm generally pretty careful to let
>>> others review the changes from my coworkers, to avoid any bias.
> 
> Chris,
> 
> Not to point any fingers, but mishaps happen and numerous reverts would be a 
> living proof of that in the repository... :) Nobody's perfect.
> 
>> This would be a good topic for OEDEM.
>>
>> For the record, I am really happy to see the .com people actively 
>> participating in the the OE project. I am also glad that they are pushing 
>> stuff into .dev and not keeping it in private repositories. This is a very 
>> good thing.
> 
> As I just replied to Frans' post in this thread - as a company, we are trying 
> to follow review procedures closely and give enough time for feedback on the 
> patches. I personally would like to apologize for the misunderstanding and 
> promise to do a better job in the future.

That it seems that you're doing Ack/SOB in-house first is a good thing, 
I think.

> As an active OE e.V. member on the other hand, I'm all in favor of this 
> modification to the commit policy, as long as there is time limit on review 
> period and if there are no strong objections, it can be pushed even if only 
> acked by the same company. Let's discuss it further and vote at OEDEM.

So long as there's exceptions for limited area of expertise places. 
There's both things like packaged-staging where Chris and I and RP have 
dealt with it the most, and then there's also TI recipes that's really 
you guys.

-- 
Tom Rini
Mentor Graphics Corporation