From: Paul Mundt <lethal@linux-sh.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] DMA: reduce the number of memory allocations
Date: Tue, 14 Sep 2010 08:52:06 +0000 [thread overview]
Message-ID: <20100914085206.GP7336@linux-sh.org> (raw)
In-Reply-To: <20100819160255.GA3948@suse.de>
On Thu, Aug 19, 2010 at 09:02:55AM -0700, Greg KH wrote:
> On Thu, Aug 19, 2010 at 05:46:38PM +0200, Guennadi Liakhovetski wrote:
> > On Thu, 19 Aug 2010, Greg KH wrote:
> >
> > > On Thu, Aug 19, 2010 at 04:40:15PM +0200, Guennadi Liakhovetski wrote:
> > > > Allocate the bitmap in dma_declare_coherent_memory() together with the struct
> > > > dma_coherent_mem object.
> > >
> > > You describe what you did, but _why_ are you doing it?
> >
> > Well, to me the subject "_reduce_ the number..." is already a reason
> > enough - the fewer kmalloc's of 20 bytes - the better, I think. But if you
> > like, I can update the description too.
>
> Yes, as I missed that, others might as well :)
>
Indeed. When this is reposted, it should also include an update for
Documentation/DMA-API.txt. I'm simply not going to take any DMA API
patches if they don't include the documentation update. DMA-API.txt is
one of the few useful parts of Documentation/, we should really strive to
keep it that way.
It would also be nice if on the next iteration DMA API people were Cc'ed,
this would be at least:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
James Bottomley <James.Bottomley@HansenPartnership.com>
WARNING: multiple messages have this Message-ID (diff)
From: lethal@linux-sh.org (Paul Mundt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] DMA: reduce the number of memory allocations
Date: Tue, 14 Sep 2010 17:52:06 +0900 [thread overview]
Message-ID: <20100914085206.GP7336@linux-sh.org> (raw)
In-Reply-To: <20100819160255.GA3948@suse.de>
On Thu, Aug 19, 2010 at 09:02:55AM -0700, Greg KH wrote:
> On Thu, Aug 19, 2010 at 05:46:38PM +0200, Guennadi Liakhovetski wrote:
> > On Thu, 19 Aug 2010, Greg KH wrote:
> >
> > > On Thu, Aug 19, 2010 at 04:40:15PM +0200, Guennadi Liakhovetski wrote:
> > > > Allocate the bitmap in dma_declare_coherent_memory() together with the struct
> > > > dma_coherent_mem object.
> > >
> > > You describe what you did, but _why_ are you doing it?
> >
> > Well, to me the subject "_reduce_ the number..." is already a reason
> > enough - the fewer kmalloc's of 20 bytes - the better, I think. But if you
> > like, I can update the description too.
>
> Yes, as I missed that, others might as well :)
>
Indeed. When this is reposted, it should also include an update for
Documentation/DMA-API.txt. I'm simply not going to take any DMA API
patches if they don't include the documentation update. DMA-API.txt is
one of the few useful parts of Documentation/, we should really strive to
keep it that way.
It would also be nice if on the next iteration DMA API people were Cc'ed,
this would be at least:
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
James Bottomley <James.Bottomley@HansenPartnership.com>
next prev parent reply other threads:[~2010-09-14 8:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 14:39 [PATCH 0/5] Add API for DMA memory reservation for devices Guennadi Liakhovetski
2010-08-19 14:39 ` Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 1/5] DMA: Remove unneeded "extern" from function declarations Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 2/5] DMA: dma_declare_coherent_memory() should return an Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 2/5] DMA: dma_declare_coherent_memory() should return an error if unsupported Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 3/5] DMA: reduce the number of memory allocations Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-08-19 15:35 ` Greg KH
2010-08-19 15:35 ` Greg KH
2010-08-19 15:46 ` Guennadi Liakhovetski
2010-08-19 15:46 ` Guennadi Liakhovetski
2010-08-19 16:02 ` Greg KH
2010-08-19 16:02 ` Greg KH
2010-09-14 8:52 ` Paul Mundt [this message]
2010-09-14 8:52 ` Paul Mundt
2010-09-15 7:23 ` Guennadi Liakhovetski
2010-09-15 7:23 ` Guennadi Liakhovetski
2010-09-16 2:58 ` FUJITA Tomonori
2010-09-16 2:58 ` FUJITA Tomonori
2010-09-16 7:04 ` Russell King - ARM Linux
2010-09-16 7:04 ` Russell King - ARM Linux
2010-09-16 7:08 ` FUJITA Tomonori
2010-09-16 7:08 ` FUJITA Tomonori
2010-09-16 4:22 ` Paul Mundt
2010-09-16 4:22 ` Paul Mundt
2010-08-20 1:15 ` Michał Nazarewicz
2010-08-20 1:15 ` Michał Nazarewicz
2010-08-19 14:40 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-09-02 10:50 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor Russell King - ARM Linux
2010-09-02 10:50 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Russell King - ARM Linux
2010-09-15 7:28 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor
2010-09-15 7:28 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Uwe Kleine-König
2010-08-19 14:40 ` [PATCH 5/5] SH: use dma_preallocate_coherent_memory() for platform Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 5/5] SH: use dma_preallocate_coherent_memory() for platform device memory Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914085206.GP7336@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.