From: "Michał Nazarewicz" <m.nazarewicz@samsung.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] DMA: reduce the number of memory allocations
Date: Fri, 20 Aug 2010 01:15:22 +0000 [thread overview]
Message-ID: <op.vhpprwkr7p4s8u@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.1008191634160.26145@axis700.grange>
On Thu, 19 Aug 2010 16:40:15 +0200, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> Allocate the bitmap in dma_declare_coherent_memory() together with the struct
> dma_coherent_mem object.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/base/dma-coherent.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c
> index f369e27..8efdfd4 100644
> --- a/drivers/base/dma-coherent.c
> +++ b/drivers/base/dma-coherent.c
> @@ -11,7 +11,7 @@ struct dma_coherent_mem {
> dma_addr_t device_base;
> int size;
> int flags;
> - unsigned long *bitmap;
> + unsigned long bitmap[0];
> };
Wouldn't "bitmap[]" be better? AFAIR "bitmap[0]" is really a GCC extension and
C99 has introduced "bitmap[]" for exactly the above purpose.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Michał "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
WARNING: multiple messages have this Message-ID (diff)
From: m.nazarewicz@samsung.com (Michał Nazarewicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] DMA: reduce the number of memory allocations
Date: Fri, 20 Aug 2010 03:15:22 +0200 [thread overview]
Message-ID: <op.vhpprwkr7p4s8u@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.1008191634160.26145@axis700.grange>
On Thu, 19 Aug 2010 16:40:15 +0200, Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
> Allocate the bitmap in dma_declare_coherent_memory() together with the struct
> dma_coherent_mem object.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/base/dma-coherent.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c
> index f369e27..8efdfd4 100644
> --- a/drivers/base/dma-coherent.c
> +++ b/drivers/base/dma-coherent.c
> @@ -11,7 +11,7 @@ struct dma_coherent_mem {
> dma_addr_t device_base;
> int size;
> int flags;
> - unsigned long *bitmap;
> + unsigned long bitmap[0];
> };
Wouldn't "bitmap[]" be better? AFAIR "bitmap[0]" is really a GCC extension and
C99 has introduced "bitmap[]" for exactly the above purpose.
--
Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, Micha? "mina86" Nazarewicz (o o)
+----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-08-20 1:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-19 14:39 [PATCH 0/5] Add API for DMA memory reservation for devices Guennadi Liakhovetski
2010-08-19 14:39 ` Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 1/5] DMA: Remove unneeded "extern" from function declarations Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 2/5] DMA: dma_declare_coherent_memory() should return an Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 2/5] DMA: dma_declare_coherent_memory() should return an error if unsupported Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 3/5] DMA: reduce the number of memory allocations Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-08-19 15:35 ` Greg KH
2010-08-19 15:35 ` Greg KH
2010-08-19 15:46 ` Guennadi Liakhovetski
2010-08-19 15:46 ` Guennadi Liakhovetski
2010-08-19 16:02 ` Greg KH
2010-08-19 16:02 ` Greg KH
2010-09-14 8:52 ` Paul Mundt
2010-09-14 8:52 ` Paul Mundt
2010-09-15 7:23 ` Guennadi Liakhovetski
2010-09-15 7:23 ` Guennadi Liakhovetski
2010-09-16 2:58 ` FUJITA Tomonori
2010-09-16 2:58 ` FUJITA Tomonori
2010-09-16 7:04 ` Russell King - ARM Linux
2010-09-16 7:04 ` Russell King - ARM Linux
2010-09-16 7:08 ` FUJITA Tomonori
2010-09-16 7:08 ` FUJITA Tomonori
2010-09-16 4:22 ` Paul Mundt
2010-09-16 4:22 ` Paul Mundt
2010-08-20 1:15 ` Michał Nazarewicz [this message]
2010-08-20 1:15 ` Michał Nazarewicz
2010-08-19 14:40 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Guennadi Liakhovetski
2010-08-19 14:40 ` Guennadi Liakhovetski
2010-09-02 10:50 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor Russell King - ARM Linux
2010-09-02 10:50 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Russell King - ARM Linux
2010-09-15 7:28 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor
2010-09-15 7:28 ` [PATCH 4/5] DMA: Add functions to preallocate DMA memory dor devices Uwe Kleine-König
2010-08-19 14:40 ` [PATCH 5/5] SH: use dma_preallocate_coherent_memory() for platform Guennadi Liakhovetski
2010-08-19 14:40 ` [PATCH 5/5] SH: use dma_preallocate_coherent_memory() for platform device memory Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vhpprwkr7p4s8u@localhost \
--to=m.nazarewicz@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.