All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/3] ASoC: tlv320aic3x: Complete the soc-cache conversion
Date: Tue, 14 Sep 2010 13:04:58 +0100	[thread overview]
Message-ID: <20100914120458.GE27029@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1284465289-4865-3-git-send-email-jhnikula@gmail.com>

On Tue, Sep 14, 2010 at 02:54:49PM +0300, Jarkko Nikula wrote:
> Complete the phasing out of aic3x_read_reg_cache, aic3x_write_reg_cache,
> aic3x_read and aic3x_write calls.
> 
> This patch replaces the aic3x_read with codec->hw_read that points to a
> function implemented by soc-cache. There is no need to cache the value from
> chip since the functions using aic3x_read are interested only read-only
> bits.
> 
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>

It'd be a bit nicer to do this by using snd_soc_read() here also and
marking the registers as volatile.  This makes the process much less
error prone since users can just use snd_soc_read() and the register
cache code will work out if it needs to go to the chip or not.

  reply	other threads:[~2010-09-14 12:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-14 11:54 [PATCH 1/3] ASoC: tlv320aic3x: Use snd_soc_read and snd_soc_write Jarkko Nikula
2010-09-14 11:54 ` [PATCH 2/3] ASoC: tlv320aic3x: Switch to soc-cache helpers Jarkko Nikula
2010-09-14 11:59   ` Mark Brown
2010-09-14 11:54 ` [PATCH 3/3] ASoC: tlv320aic3x: Complete the soc-cache conversion Jarkko Nikula
2010-09-14 12:04   ` Mark Brown [this message]
2010-09-14 12:14     ` Jarkko Nikula
2010-09-14 12:21       ` Mark Brown
2010-09-14 12:45         ` Jarkko Nikula
2010-09-14 12:55           ` Mark Brown
2010-09-14 13:59             ` [PATCHv2 " Jarkko Nikula
2010-09-14 15:08               ` Mark Brown
2010-09-15 12:57                 ` Liam Girdwood
2010-09-14 11:59 ` [PATCH 1/3] ASoC: tlv320aic3x: Use snd_soc_read and snd_soc_write Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100914120458.GE27029@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jhnikula@gmail.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.