From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate
Date: Thu, 16 Sep 2010 15:14:46 +0000 [thread overview]
Message-ID: <20100916151446.GA14229@ovro.caltech.edu> (raw)
In-Reply-To: <1284602835-7605-2-git-send-email-guenter.roeck@ericsson.com>
On Wed, Sep 15, 2010 at 07:07:14PM -0700, Guenter Roeck wrote:
> The attribute reflects an interval, not a rate.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Documentation/hwmon/sysfs-interface | 12 +++++-----
> drivers/hwmon/adm1031.c | 43 +++++++++++++++++++---------------
> 2 files changed, 30 insertions(+), 25 deletions(-)
>
I'm the original author of both the update_rate text in sysfs-interface
and the adm1031 support. Your change looks good to me. Thanks for doing
the work.
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: "Ira W. Snyder" <iws@ovro.caltech.edu>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval
Date: Thu, 16 Sep 2010 08:14:46 -0700 [thread overview]
Message-ID: <20100916151446.GA14229@ovro.caltech.edu> (raw)
In-Reply-To: <1284602835-7605-2-git-send-email-guenter.roeck@ericsson.com>
On Wed, Sep 15, 2010 at 07:07:14PM -0700, Guenter Roeck wrote:
> The attribute reflects an interval, not a rate.
>
> Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Documentation/hwmon/sysfs-interface | 12 +++++-----
> drivers/hwmon/adm1031.c | 43 +++++++++++++++++++---------------
> 2 files changed, 30 insertions(+), 25 deletions(-)
>
I'm the original author of both the update_rate text in sysfs-interface
and the adm1031 support. Your change looks good to me. Thanks for doing
the work.
Acked-by: Ira W. Snyder <iws@ovro.caltech.edu>
next prev parent reply other threads:[~2010-09-16 15:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 2:07 [lm-sensors] [PATCH 0/2] hwmon: Replace update_rate sysfs attribute Guenter Roeck
2010-09-16 2:07 ` [PATCH 0/2] hwmon: Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 2:07 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs Guenter Roeck
2010-09-16 2:07 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:14 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 15:14 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 15:37 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 15:37 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 16:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 16:42 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 19:43 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 19:43 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 21:02 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 21:02 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 21:39 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 21:39 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Henrique de Moraes Holschuh
2010-09-16 15:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Henrique de Moraes Holschuh
2010-09-16 16:01 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 16:01 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 16:54 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Henrique de Moraes Holschuh
2010-09-16 16:54 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Henrique de Moraes Holschuh
2010-09-16 15:14 ` Ira W. Snyder [this message]
2010-09-16 15:14 ` Ira W. Snyder
2010-09-16 2:07 ` [lm-sensors] [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs Guenter Roeck
2010-09-16 2:07 ` [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:19 ` [lm-sensors] [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs Jean Delvare
2010-09-16 15:19 ` [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs attribute with update_interval Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916151446.GA14229@ovro.caltech.edu \
--to=iws@ovro.caltech.edu \
--cc=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.