From: Jean Delvare <khali@linux-fr.org>
To: guenter.roeck@ericsson.com
Cc: Randy Dunlap <rdunlap@xenotime.net>,
lm-sensors@lm-sensors.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate
Date: Thu, 16 Sep 2010 21:02:34 +0000 [thread overview]
Message-ID: <20100916230234.34f16725@hyperion.delvare> (raw)
In-Reply-To: <1284666195.15696.35.camel@groeck-laptop>
On Thu, 16 Sep 2010 12:43:15 -0700, Guenter Roeck wrote:
> On Thu, 2010-09-16 at 12:42 -0400, Jean Delvare wrote:
> > I'd rather change all these to "millisecond", so that the document
> > consistently uses singular for all units.
> >
> > I also see that the indentation isn't consistent, with power and energy
> > having 4 tabs where the rest has only 2. Bah.
> >
> To get beyond this ... how about you apply my rev2, and I make the other
> changes (formatting and milliseconds --> millisecond) in a subsequent
> patch ?
I'll do the milliseconds --> millisecond myself, no need to resend.
Further changes would indeed belong to one or two separate patches, if
you have time for that. This is definitely low priority though.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <khali@linux-fr.org>
To: guenter.roeck@ericsson.com
Cc: Randy Dunlap <rdunlap@xenotime.net>,
lm-sensors@lm-sensors.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval
Date: Thu, 16 Sep 2010 23:02:34 +0200 [thread overview]
Message-ID: <20100916230234.34f16725@hyperion.delvare> (raw)
In-Reply-To: <1284666195.15696.35.camel@groeck-laptop>
On Thu, 16 Sep 2010 12:43:15 -0700, Guenter Roeck wrote:
> On Thu, 2010-09-16 at 12:42 -0400, Jean Delvare wrote:
> > I'd rather change all these to "millisecond", so that the document
> > consistently uses singular for all units.
> >
> > I also see that the indentation isn't consistent, with power and energy
> > having 4 tabs where the rest has only 2. Bah.
> >
> To get beyond this ... how about you apply my rev2, and I make the other
> changes (formatting and milliseconds --> millisecond) in a subsequent
> patch ?
I'll do the milliseconds --> millisecond myself, no need to resend.
Further changes would indeed belong to one or two separate patches, if
you have time for that. This is definitely low priority though.
--
Jean Delvare
next prev parent reply other threads:[~2010-09-16 21:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 2:07 [lm-sensors] [PATCH 0/2] hwmon: Replace update_rate sysfs attribute Guenter Roeck
2010-09-16 2:07 ` [PATCH 0/2] hwmon: Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 2:07 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs Guenter Roeck
2010-09-16 2:07 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:14 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 15:14 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 15:37 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 15:37 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 16:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 16:42 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 19:43 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 19:43 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 21:02 ` Jean Delvare [this message]
2010-09-16 21:02 ` Jean Delvare
2010-09-16 21:39 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Guenter Roeck
2010-09-16 21:39 ` [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Henrique de Moraes Holschuh
2010-09-16 15:42 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Henrique de Moraes Holschuh
2010-09-16 16:01 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Jean Delvare
2010-09-16 16:01 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Jean Delvare
2010-09-16 16:54 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Henrique de Moraes Holschuh
2010-09-16 16:54 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Henrique de Moraes Holschuh
2010-09-16 15:14 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate Ira W. Snyder
2010-09-16 15:14 ` [lm-sensors] [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval Ira W. Snyder
2010-09-16 2:07 ` [lm-sensors] [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs Guenter Roeck
2010-09-16 2:07 ` [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs attribute with update_interval Guenter Roeck
2010-09-16 15:19 ` [lm-sensors] [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs Jean Delvare
2010-09-16 15:19 ` [PATCH 2/2] hwmon: (lm95241) Replace rate sysfs attribute with update_interval Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916230234.34f16725@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=guenter.roeck@ericsson.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.