* [PATCH 01/11] OMAP: mach-omap2: Fix incorrect assignment warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 02/11] OMAP: mach-omap2: Fix static declaration warnings G, Manjunath Kondaiah
` (10 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes below sparse warnings for incorrect assignments.
arch/arm/mach-omap2/control.c:195:16: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-omap2/control.c:195:16: expected unsigned int [usertype] *v_addr
arch/arm/mach-omap2/control.c:195:16: got void [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:199:25: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/control.c:199:25: expected void const volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:199:25: got unsigned int [usertype] *
arch/arm/mach-omap2/control.c:320:28: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-omap2/control.c:320:28: expected void *[noderef] <asn:2>scratchpad_address
arch/arm/mach-omap2/control.c:320:28: got void [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:321:9: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/control.c:321:9: expected void volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:321:9: got void *[noderef] <asn:2>scratchpad_address
arch/arm/mach-omap2/control.c:324:9: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/control.c:324:9: expected void volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:324:9: got void *
arch/arm/mach-omap2/control.c:327:9: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/control.c:327:9: expected void volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:327:9: got void *
arch/arm/mach-omap2/control.c:334:9: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/control.c:334:9: expected void volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/control.c:334:9: got void *
arch/arm/mach-omap2/control.c:321:9: warning: dereference of noderef expression
arch/arm/mach-omap2/control.c:324:9: warning: dereference of noderef expression
arch/arm/mach-omap2/control.c:327:9: warning: dereference of noderef expression
arch/arm/mach-omap2/control.c:334:9: warning: dereference of noderef expression
arch/arm/mach-omap2/pm34xx.c:323:28: warning: incorrect type in assignment (different address spaces)
arch/arm/mach-omap2/pm34xx.c:323:28: expected unsigned int [usertype] *scratchpad_address
arch/arm/mach-omap2/pm34xx.c:323:28: got void [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/pm34xx.c:326:26: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/pm34xx.c:326:26: expected void const volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/pm34xx.c:326:26: got unsigned int [usertype] *
arch/arm/mach-omap2/pm34xx.c:329:26: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/pm34xx.c:329:26: expected void const volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/pm34xx.c:329:26: got unsigned int [usertype] *
arch/arm/mach-omap2/pm34xx.c:334:29: warning: incorrect type in argument 1 (different address spaces)
arch/arm/mach-omap2/pm34xx.c:334:29: expected void const volatile [noderef] <asn:2>*<noident>
arch/arm/mach-omap2/pm34xx.c:334:29: got unsigned int [usertype] *
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/control.c | 4 ++--
arch/arm/mach-omap2/pm34xx.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
index a8d20ee..7405936 100644
--- a/arch/arm/mach-omap2/control.c
+++ b/arch/arm/mach-omap2/control.c
@@ -190,7 +190,7 @@ void omap_ctrl_writel(u32 val, u16 offset)
void omap3_clear_scratchpad_contents(void)
{
u32 max_offset = OMAP343X_SCRATCHPAD_ROM_OFFSET;
- u32 *v_addr;
+ void __iomem *v_addr;
u32 offset = 0;
v_addr = OMAP2_L4_IO_ADDRESS(OMAP343X_SCRATCHPAD_ROM);
if (prm_read_mod_reg(OMAP3430_GR_MOD, OMAP3_PRM_RSTST_OFFSET) &
@@ -206,7 +206,7 @@ void omap3_clear_scratchpad_contents(void)
/* Populate the scratchpad structure with restore structure */
void omap3_save_scratchpad_contents(void)
{
- void * __iomem scratchpad_address;
+ void __iomem *scratchpad_address;
u32 arm_context_addr;
struct omap3_scratchpad scratchpad_contents;
struct omap3_scratchpad_prcm_block prcm_block_contents;
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 7b03426..4af19a6 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -316,7 +316,7 @@ static void restore_control_register(u32 val)
/* Function to restore the table entry that was modified for enabling MMU */
static void restore_table_entry(void)
{
- u32 *scratchpad_address;
+ void __iomem *scratchpad_address;
u32 previous_value, control_reg_value;
u32 *address;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 02/11] OMAP: mach-omap2: Fix static declaration warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 01/11] OMAP: mach-omap2: Fix incorrect assignment warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 03/11] OMAP: mach-omap2: Fix static function warnings G, Manjunath Kondaiah
` (9 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes sparse warnings due to non declaration of
static structures and variables.
Sparse warning logs fixed:
arch/arm/mach-omap2/control.c:88:6: warning: symbol 'omap3_secure_ram_storage' was not declared. Should it be static?
n
arch/arm/mach-omap2/timer-gp.c:50:22: warning: symbol 'gptimer_wakeup' was not declared. Should it be static?
arch/arm/mach-omap2/timer-gp.c:240:18: warning: symbol 'omap_timer' was not declared. Should it be static?
arch/arm/mach-omap2/prcm.c:121:24: warning: symbol 'prcm_context' was not declared. Should it be static?
arch/arm/mach-omap2/mux2420.c:510:29: warning: symbol 'omap2420_pop_ball' was not declared. Should it be static?
arch/arm/mach-omap2/mux2430.c:589:29: warning: symbol 'omap2430_pop_ball' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:934:28: warning: symbol 'omap3_cus_subset' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:1080:29: warning: symbol 'omap3_cus_ball' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:1272:28: warning: symbol 'omap3_cbb_subset' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:1393:29: warning: symbol 'omap3_cbb_ball' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:1603:28: warning: symbol 'omap36xx_cbp_subset' was not declared. Should it be static?
arch/arm/mach-omap2/mux34xx.c:1821:29: warning: symbol 'omap36xx_cbp_ball' was not declared. Should it be static?
arch/arm/mach-omap2/pm-debug.c:165:15: warning: symbol 'pm_dbg_dir' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap3evm.c:587:30: warning: symbol 'ads7846_config' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap3evm.c:606:23: warning: symbol 'omap3evm_spi_board_info' was not declared. Should it be static?
arch/arm/mach-omap2/board-rx51-sdram.c:46:25: warning: symbol 'rx51_sdrc_params' was not declared. Should it be static?
arch/arm/mach-omap2/board-rx51-sdram.c:211:25: warning: symbol 'rx51_get_sdram_timings' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap3touchbook.c:64:15: warning: symbol 'touchbook_revision' was not declared. Should it be static?
arch/arm/mach-omap2/board-am3517evm.c:350:24: warning: symbol 'am3517_evm_dss_device' was not declared. Should it be static?
arch/arm/mach-omap2/board-omap3stalker.c:567:23: warning: symbol 'omap3stalker_spi_board_info' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/board-am3517evm.c | 2 +-
arch/arm/mach-omap2/board-omap3evm.c | 4 ++--
arch/arm/mach-omap2/board-omap3stalker.c | 2 +-
arch/arm/mach-omap2/board-omap3touchbook.c | 2 +-
arch/arm/mach-omap2/board-rx51-sdram.c | 2 +-
arch/arm/mach-omap2/control.c | 1 +
arch/arm/mach-omap2/mux2420.c | 2 +-
arch/arm/mach-omap2/mux2430.c | 2 +-
arch/arm/mach-omap2/mux34xx.c | 12 ++++++------
arch/arm/mach-omap2/pm-debug.c | 2 +-
arch/arm/mach-omap2/prcm.c | 2 +-
arch/arm/plat-omap/include/plat/dmtimer.h | 2 ++
arch/arm/plat-omap/include/plat/sdrc.h | 1 +
13 files changed, 20 insertions(+), 16 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
index 4d0f585..197289b 100644
--- a/arch/arm/mach-omap2/board-am3517evm.c
+++ b/arch/arm/mach-omap2/board-am3517evm.c
@@ -347,7 +347,7 @@ static struct omap_dss_board_info am3517_evm_dss_data = {
.default_device = &am3517_evm_lcd_device,
};
-struct platform_device am3517_evm_dss_device = {
+static struct platform_device am3517_evm_dss_device = {
.name = "omapdss",
.id = -1,
.dev = {
diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index f76d9c0..892b740 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -584,7 +584,7 @@ static int ads7846_get_pendown_state(void)
return !gpio_get_value(OMAP3_EVM_TS_GPIO);
}
-struct ads7846_platform_data ads7846_config = {
+static struct ads7846_platform_data ads7846_config = {
.x_max = 0x0fff,
.y_max = 0x0fff,
.x_plate_ohms = 180,
@@ -603,7 +603,7 @@ static struct omap2_mcspi_device_config ads7846_mcspi_config = {
.single_channel = 1, /* 0: slave, 1: master */
};
-struct spi_board_info omap3evm_spi_board_info[] = {
+static struct spi_board_info omap3evm_spi_board_info[] = {
[0] = {
.modalias = "ads7846",
.bus_num = 1,
diff --git a/arch/arm/mach-omap2/board-omap3stalker.c b/arch/arm/mach-omap2/board-omap3stalker.c
index bcd01d2..70067d6 100644
--- a/arch/arm/mach-omap2/board-omap3stalker.c
+++ b/arch/arm/mach-omap2/board-omap3stalker.c
@@ -564,7 +564,7 @@ static struct omap2_mcspi_device_config ads7846_mcspi_config = {
.single_channel = 1, /* 0: slave, 1: master */
};
-struct spi_board_info omap3stalker_spi_board_info[] = {
+static struct spi_board_info omap3stalker_spi_board_info[] = {
[0] = {
.modalias = "ads7846",
.bus_num = 1,
diff --git a/arch/arm/mach-omap2/board-omap3touchbook.c b/arch/arm/mach-omap2/board-omap3touchbook.c
index 663c62d..430ae22 100644
--- a/arch/arm/mach-omap2/board-omap3touchbook.c
+++ b/arch/arm/mach-omap2/board-omap3touchbook.c
@@ -61,7 +61,7 @@
#define TB_BL_PWM_TIMER 9
#define TB_KILL_POWER_GPIO 168
-unsigned long touchbook_revision;
+static unsigned long touchbook_revision;
static struct mtd_partition omap3touchbook_nand_partitions[] = {
/* All the partition sizes are listed in terms of NAND block size */
diff --git a/arch/arm/mach-omap2/board-rx51-sdram.c b/arch/arm/mach-omap2/board-rx51-sdram.c
index f392844..a43b2c5 100644
--- a/arch/arm/mach-omap2/board-rx51-sdram.c
+++ b/arch/arm/mach-omap2/board-rx51-sdram.c
@@ -43,7 +43,7 @@ struct sdram_timings {
u32 tWTR;
};
-struct omap_sdrc_params rx51_sdrc_params[4];
+static struct omap_sdrc_params rx51_sdrc_params[4];
static const struct sdram_timings rx51_timings[] = {
{
diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c
index 7405936..018022a 100644
--- a/arch/arm/mach-omap2/control.c
+++ b/arch/arm/mach-omap2/control.c
@@ -23,6 +23,7 @@
#include "cm.h"
#include "prm.h"
#include "sdrc.h"
+#include "pm.h"
static void __iomem *omap2_ctrl_base;
diff --git a/arch/arm/mach-omap2/mux2420.c b/arch/arm/mach-omap2/mux2420.c
index fdb04a7..414af54 100644
--- a/arch/arm/mach-omap2/mux2420.c
+++ b/arch/arm/mach-omap2/mux2420.c
@@ -507,7 +507,7 @@ static struct omap_mux __initdata omap2420_muxmodes[] = {
* Balls for 447-pin POP package
*/
#ifdef CONFIG_DEBUG_FS
-struct omap_ball __initdata omap2420_pop_ball[] = {
+static struct omap_ball __initdata omap2420_pop_ball[] = {
_OMAP2420_BALLENTRY(CAM_D0, "y4", NULL),
_OMAP2420_BALLENTRY(CAM_D1, "y3", NULL),
_OMAP2420_BALLENTRY(CAM_D2, "u7", NULL),
diff --git a/arch/arm/mach-omap2/mux2430.c b/arch/arm/mach-omap2/mux2430.c
index 7dcaaa8..84d2c5a 100644
--- a/arch/arm/mach-omap2/mux2430.c
+++ b/arch/arm/mach-omap2/mux2430.c
@@ -586,7 +586,7 @@ static struct omap_mux __initdata omap2430_muxmodes[] = {
* 447-pin s-PBGA Package, 0.00mm Ball Pitch (Bottom)
*/
#ifdef CONFIG_DEBUG_FS
-struct omap_ball __initdata omap2430_pop_ball[] = {
+static struct omap_ball __initdata omap2430_pop_ball[] = {
_OMAP2430_BALLENTRY(CAM_D0, "t8", NULL),
_OMAP2430_BALLENTRY(CAM_D1, "t4", NULL),
_OMAP2430_BALLENTRY(CAM_D10, "r4", NULL),
diff --git a/arch/arm/mach-omap2/mux34xx.c b/arch/arm/mach-omap2/mux34xx.c
index f64d7ee..574e54e 100644
--- a/arch/arm/mach-omap2/mux34xx.c
+++ b/arch/arm/mach-omap2/mux34xx.c
@@ -931,7 +931,7 @@ struct omap_ball __initdata omap3_cbc_ball[] = {
* Signals different on CUS package compared to superset
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_OMAP_PACKAGE_CUS)
-struct omap_mux __initdata omap3_cus_subset[] = {
+static struct omap_mux __initdata omap3_cus_subset[] = {
_OMAP3_MUXENTRY(CAM_D10, 109,
"cam_d10", NULL, NULL, NULL,
"gpio_109", NULL, NULL, "safe_mode"),
@@ -1077,7 +1077,7 @@ struct omap_mux __initdata omap3_cus_subset[] = {
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_DEBUG_FS) \
&& defined(CONFIG_OMAP_PACKAGE_CUS)
-struct omap_ball __initdata omap3_cus_ball[] = {
+static struct omap_ball __initdata omap3_cus_ball[] = {
_OMAP3_BALLENTRY(CAM_D0, "ab18", NULL),
_OMAP3_BALLENTRY(CAM_D1, "ac18", NULL),
_OMAP3_BALLENTRY(CAM_D10, "f21", NULL),
@@ -1269,7 +1269,7 @@ struct omap_ball __initdata omap3_cus_ball[] = {
* Signals different on CBB package comapared to superset
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_OMAP_PACKAGE_CBB)
-struct omap_mux __initdata omap3_cbb_subset[] = {
+static struct omap_mux __initdata omap3_cbb_subset[] = {
_OMAP3_MUXENTRY(CAM_D10, 109,
"cam_d10", NULL, NULL, NULL,
"gpio_109", NULL, NULL, "safe_mode"),
@@ -1390,7 +1390,7 @@ struct omap_mux __initdata omap3_cbb_subset[] = {
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_DEBUG_FS) \
&& defined(CONFIG_OMAP_PACKAGE_CBB)
-struct omap_ball __initdata omap3_cbb_ball[] = {
+static struct omap_ball __initdata omap3_cbb_ball[] = {
_OMAP3_BALLENTRY(CAM_D0, "ag17", NULL),
_OMAP3_BALLENTRY(CAM_D1, "ah17", NULL),
_OMAP3_BALLENTRY(CAM_D10, "b25", NULL),
@@ -1600,7 +1600,7 @@ struct omap_ball __initdata omap3_cbb_ball[] = {
* Signals different on 36XX CBP package comapared to 34XX CBC package
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_OMAP_PACKAGE_CBP)
-struct omap_mux __initdata omap36xx_cbp_subset[] = {
+static struct omap_mux __initdata omap36xx_cbp_subset[] = {
_OMAP3_MUXENTRY(CAM_D0, 99,
"cam_d0", NULL, "csi2_dx2", NULL,
"gpio_99", NULL, NULL, "safe_mode"),
@@ -1818,7 +1818,7 @@ struct omap_mux __initdata omap36xx_cbp_subset[] = {
*/
#if defined(CONFIG_OMAP_MUX) && defined(CONFIG_DEBUG_FS) \
&& defined (CONFIG_OMAP_PACKAGE_CBP)
-struct omap_ball __initdata omap36xx_cbp_ball[] = {
+static struct omap_ball __initdata omap36xx_cbp_ball[] = {
_OMAP3_BALLENTRY(CAM_D0, "ag17", NULL),
_OMAP3_BALLENTRY(CAM_D1, "ah17", NULL),
_OMAP3_BALLENTRY(CAM_D10, "b25", NULL),
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 723b44e..efb1d15 100644
--- a/arch/arm/mach-omap2/pm-debug.c
+++ b/arch/arm/mach-omap2/pm-debug.c
@@ -162,7 +162,7 @@ void omap2_pm_dump(int mode, int resume, unsigned int us)
static void pm_dbg_regset_store(u32 *ptr);
-struct dentry *pm_dbg_dir;
+static struct dentry *pm_dbg_dir;
static int pm_dbg_init_done;
diff --git a/arch/arm/mach-omap2/prcm.c b/arch/arm/mach-omap2/prcm.c
index c201374..8d412a2 100644
--- a/arch/arm/mach-omap2/prcm.c
+++ b/arch/arm/mach-omap2/prcm.c
@@ -118,7 +118,7 @@ struct omap3_prcm_regs {
u32 wkup_pm_wken;
};
-struct omap3_prcm_regs prcm_context;
+static struct omap3_prcm_regs prcm_context;
u32 omap_prcm_get_reset_sources(void)
{
diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap/include/plat/dmtimer.h
index 20f1054..dfa3aff 100644
--- a/arch/arm/plat-omap/include/plat/dmtimer.h
+++ b/arch/arm/plat-omap/include/plat/dmtimer.h
@@ -45,6 +45,8 @@
#define OMAP_TIMER_TRIGGER_OVERFLOW_AND_COMPARE 0x02
struct omap_dm_timer;
+extern struct omap_dm_timer *gptimer_wakeup;
+extern struct sys_timer omap_timer;
struct clk;
int omap_dm_timer_init(void);
diff --git a/arch/arm/plat-omap/include/plat/sdrc.h b/arch/arm/plat-omap/include/plat/sdrc.h
index 7b76f50..efd87c8 100644
--- a/arch/arm/plat-omap/include/plat/sdrc.h
+++ b/arch/arm/plat-omap/include/plat/sdrc.h
@@ -147,6 +147,7 @@ struct memory_timings {
};
extern void omap2xxx_sdrc_init_params(u32 force_lock_to_unlock_mode);
+struct omap_sdrc_params *rx51_get_sdram_timings(void);
u32 omap2xxx_sdrc_dll_is_unlocked(void);
u32 omap2xxx_sdrc_reprogram(u32 level, u32 force);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 03/11] OMAP: mach-omap2: Fix static function warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 01/11] OMAP: mach-omap2: Fix incorrect assignment warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 02/11] OMAP: mach-omap2: Fix static declaration warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings G, Manjunath Kondaiah
` (8 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes sparse warnings due non declarations of static functions.
arch/arm/mach-omap2/timer-gp.c:115:12: warning: symbol 'omap2_gp_clockevent_set_gptimer' was not declared. Should it be static?
arch/arm/mach-omap2/powerdomain.c:993:5: warning: symbol 'pwrdm_set_lowpwrstchange' was not declared. Should it be static?
arch/arm/mach-omap2/board-flash.c:141:8: warning: symbol 'board_nand_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-n8x0.c:416:6: warning: symbol 'n8x0_mmc_slot1_cover_handler' was not declared. Should it be static?
arch/arm/mach-omap2/board-n8x0.c:544:13: warning: symbol 'n8x0_mmc_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-rx51-peripherals.c:902:13: warning: symbol 'rx51_peripherals_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-rx51-video.c:107:13: warning: symbol 'rx51_video_mem_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-zoom-debugboard.c:155:12: warning: symbol 'zoom_debugboard_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-zoom-peripherals.c:280:13: warning: symbol 'zoom_peripherals_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-igep0020.c:110:13: warning: symbol 'igep2_flash_init' was not declared. Should it be static?
arch/arm/mach-omap2/board-am3517evm.c:109:6: warning: symbol 'am3517_evm_ethernet_init' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/board-am3517evm.c | 2 +-
arch/arm/mach-omap2/board-igep0020.c | 4 +-
arch/arm/mach-omap2/board-n8x0.c | 16 +------------
arch/arm/mach-omap2/board-rx51-peripherals.c | 2 +
arch/arm/mach-omap2/board-rx51-video.c | 2 +
arch/arm/mach-omap2/board-zoom-debugboard.c | 2 +
arch/arm/mach-omap2/board-zoom-peripherals.c | 2 +
arch/arm/mach-omap2/include/mach/board-flash.h | 2 +
arch/arm/mach-omap2/include/mach/board-rx51.h | 11 +++++++++
arch/arm/mach-omap2/powerdomain.c | 28 ------------------------
arch/arm/mach-omap2/timer-gp.c | 1 +
arch/arm/plat-omap/include/plat/dmtimer.h | 2 +-
12 files changed, 27 insertions(+), 47 deletions(-)
create mode 100644 arch/arm/mach-omap2/include/mach/board-rx51.h
diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
index 197289b..ae22ea8 100644
--- a/arch/arm/mach-omap2/board-am3517evm.c
+++ b/arch/arm/mach-omap2/board-am3517evm.c
@@ -106,7 +106,7 @@ static void am3517_disable_ethernet_int(void)
regval = omap_ctrl_readl(AM35XX_CONTROL_LVL_INTR_CLEAR);
}
-void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
+static void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
{
unsigned int regval;
diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 175f043..fbcb888 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -107,7 +107,7 @@ static struct platform_device igep2_onenand_device = {
},
};
-void __init igep2_flash_init(void)
+static void __init igep2_flash_init(void)
{
u8 cs = 0;
u8 onenandcs = GPMC_CS_NUM + 1;
@@ -141,7 +141,7 @@ void __init igep2_flash_init(void)
}
#else
-void __init igep2_flash_init(void) {}
+static void __init igep2_flash_init(void) {}
#endif
#if defined(CONFIG_SMSC911X) || defined(CONFIG_SMSC911X_MODULE)
diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
index d705cc8..26145c9 100644
--- a/arch/arm/mach-omap2/board-n8x0.c
+++ b/arch/arm/mach-omap2/board-n8x0.c
@@ -413,15 +413,6 @@ static void n8x0_mmc_callback(void *data, u8 card_mask)
omap_mmc_notify_cover_event(mmc_device, index, *openp);
}
-void n8x0_mmc_slot1_cover_handler(void *arg, int closed_state)
-{
- if (mmc_device == NULL)
- return;
-
- slot1_cover_open = !closed_state;
- omap_mmc_notify_cover_event(mmc_device, 0, closed_state);
-}
-
static int n8x0_mmc_late_init(struct device *dev)
{
int r, bit, *openp;
@@ -541,7 +532,7 @@ static struct omap_mmc_platform_data mmc1_data = {
static struct omap_mmc_platform_data *mmc_data[OMAP24XX_NR_MMC];
-void __init n8x0_mmc_init(void)
+static void __init n8x0_mmc_init(void)
{
int err;
@@ -590,11 +581,6 @@ void __init n8x0_mmc_init(void)
void __init n8x0_mmc_init(void)
{
}
-
-void n8x0_mmc_slot1_cover_handler(void *arg, int state)
-{
-}
-
#endif /* CONFIG_MMC_OMAP */
#ifdef CONFIG_MENELAUS
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 9a5eb87..83d4efd 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -32,6 +32,8 @@
#include <plat/onenand.h>
#include <plat/gpmc-smc91x.h>
+#include <mach/board-rx51.h>
+
#include <sound/tlv320aic3x.h>
#include <sound/tpa6130a2-plat.h>
diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
index 5a1005b..85503fe 100644
--- a/arch/arm/mach-omap2/board-rx51-video.c
+++ b/arch/arm/mach-omap2/board-rx51-video.c
@@ -20,6 +20,8 @@
#include <plat/vram.h>
#include <plat/mcspi.h>
+#include <mach/board-rx51.h>
+
#include "mux.h"
#define RX51_LCD_RESET_GPIO 90
diff --git a/arch/arm/mach-omap2/board-zoom-debugboard.c b/arch/arm/mach-omap2/board-zoom-debugboard.c
index 1d7f827..007ebdc 100644
--- a/arch/arm/mach-omap2/board-zoom-debugboard.c
+++ b/arch/arm/mach-omap2/board-zoom-debugboard.c
@@ -16,6 +16,8 @@
#include <plat/gpmc.h>
+#include <mach/board-zoom.h>
+
#define ZOOM_SMSC911X_CS 7
#define ZOOM_SMSC911X_GPIO 158
#define ZOOM_QUADUART_CS 3
diff --git a/arch/arm/mach-omap2/board-zoom-peripherals.c b/arch/arm/mach-omap2/board-zoom-peripherals.c
index 6b39849..e2e7353 100644
--- a/arch/arm/mach-omap2/board-zoom-peripherals.c
+++ b/arch/arm/mach-omap2/board-zoom-peripherals.c
@@ -24,6 +24,8 @@
#include <plat/common.h>
#include <plat/usb.h>
+#include <mach/board-zoom.h>
+
#include "mux.h"
#include "hsmmc.h"
diff --git a/arch/arm/mach-omap2/include/mach/board-flash.h b/arch/arm/mach-omap2/include/mach/board-flash.h
index b2242ae..69befe0 100644
--- a/arch/arm/mach-omap2/include/mach/board-flash.h
+++ b/arch/arm/mach-omap2/include/mach/board-flash.h
@@ -26,3 +26,5 @@ struct flash_partitions {
extern void board_flash_init(struct flash_partitions [],
char chip_sel[][GPMC_CS_NUM]);
+extern void board_nand_init(struct mtd_partition *nand_parts,
+ u8 nr_parts, u8 cs);
diff --git a/arch/arm/mach-omap2/include/mach/board-rx51.h b/arch/arm/mach-omap2/include/mach/board-rx51.h
new file mode 100644
index 0000000..b76f49e
--- /dev/null
+++ b/arch/arm/mach-omap2/include/mach/board-rx51.h
@@ -0,0 +1,11 @@
+/*
+ * Defines for rx51 boards
+ */
+
+#ifndef _OMAP_BOARD_RX51_H
+#define _OMAP_BOARD_RX51_H
+
+extern void __init rx51_peripherals_init(void);
+extern void __init rx51_video_mem_init(void);
+
+#endif
diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap2/powerdomain.c
index 6527ec3..6e51079 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -981,34 +981,6 @@ bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
}
/**
- * pwrdm_set_lowpwrstchange - Request a low power state change
- * @pwrdm: struct powerdomain *
- *
- * Allows a powerdomain to transtion to a lower power sleep state
- * from an existing sleep state without waking up the powerdomain.
- * Returns -EINVAL if the powerdomain pointer is null or if the
- * powerdomain does not support LOWPOWERSTATECHANGE, or returns 0
- * upon success.
- */
-int pwrdm_set_lowpwrstchange(struct powerdomain *pwrdm)
-{
- if (!pwrdm)
- return -EINVAL;
-
- if (!(pwrdm->flags & PWRDM_HAS_LOWPOWERSTATECHANGE))
- return -EINVAL;
-
- pr_debug("powerdomain: %s: setting LOWPOWERSTATECHANGE bit\n",
- pwrdm->name);
-
- prm_rmw_mod_reg_bits(OMAP4430_LOWPOWERSTATECHANGE_MASK,
- (1 << OMAP4430_LOWPOWERSTATECHANGE_SHIFT),
- pwrdm->prcm_offs, pwrstctrl_reg_offs);
-
- return 0;
-}
-
-/**
* pwrdm_wait_transition - wait for powerdomain power transition to finish
* @pwrdm: struct powerdomain * to wait for
*
diff --git a/arch/arm/mach-omap2/timer-gp.c b/arch/arm/mach-omap2/timer-gp.c
index 74fbed8..cd2f7b8 100644
--- a/arch/arm/mach-omap2/timer-gp.c
+++ b/arch/arm/mach-omap2/timer-gp.c
@@ -123,6 +123,7 @@ int __init omap2_gp_clockevent_set_gptimer(u8 id)
return 0;
}
+EXPORT_SYMBOL(omap2_gp_clockevent_set_gptimer);
static void __init omap2_gp_clockevent_init(void)
{
diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap/include/plat/dmtimer.h
index dfa3aff..ce55949 100644
--- a/arch/arm/plat-omap/include/plat/dmtimer.h
+++ b/arch/arm/plat-omap/include/plat/dmtimer.h
@@ -81,6 +81,6 @@ unsigned int omap_dm_timer_read_counter(struct omap_dm_timer *timer);
void omap_dm_timer_write_counter(struct omap_dm_timer *timer, unsigned int value);
int omap_dm_timers_active(void);
-
+int omap2_gp_clockevent_set_gptimer(u8 id);
#endif /* __ASM_ARCH_DMTIMER_H */
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (2 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 03/11] OMAP: mach-omap2: Fix static function warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-09-16 19:27 ` Tony Lindgren
2010-08-26 20:56 ` [PATCH 05/11] OMAP: plat-omap: Fix static function warnings G, Manjunath Kondaiah
` (7 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes miscellaneous sparse warnings in mach-omap2.
arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice
arch/arm/mach-omap2/board-am3517evm.c:142:18: also defined here
arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/board-am3517evm.c | 1 -
arch/arm/mach-omap2/irq.c | 2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
index ae22ea8..b091741 100644
--- a/arch/arm/mach-omap2/board-am3517evm.c
+++ b/arch/arm/mach-omap2/board-am3517evm.c
@@ -139,7 +139,6 @@ static void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
static struct i2c_board_info __initdata am3517evm_i2c1_boardinfo[] = {
{
I2C_BOARD_INFO("s35390a", 0x30),
- .type = "s35390a",
},
};
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 26aeef5..02fd942 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -47,7 +47,7 @@ static struct omap_irq_bank {
} __attribute__ ((aligned(4))) irq_banks[] = {
{
/* MPU INTC */
- .base_reg = 0,
+ .base_reg = (void __iomem *)0,
.nr_irqs = 96,
},
};
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings
2010-08-26 20:56 ` [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings G, Manjunath Kondaiah
@ 2010-09-16 19:27 ` Tony Lindgren
2010-09-20 5:57 ` G, Manjunath Kondaiah
0 siblings, 1 reply; 19+ messages in thread
From: Tony Lindgren @ 2010-09-16 19:27 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: linux-omap, Nishanth Menon
* G, Manjunath Kondaiah <manjugk@ti.com> [100826 13:50]:
> From: Manjunatha GK <manjugk@ti.com>
>
> This patch fixes miscellaneous sparse warnings in mach-omap2.
>
> arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice
> arch/arm/mach-omap2/board-am3517evm.c:142:18: also defined here
>
> arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/mach-omap2/board-am3517evm.c | 1 -
> arch/arm/mach-omap2/irq.c | 2 +-
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
> index ae22ea8..b091741 100644
> --- a/arch/arm/mach-omap2/board-am3517evm.c
> +++ b/arch/arm/mach-omap2/board-am3517evm.c
> @@ -139,7 +139,6 @@ static void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
> static struct i2c_board_info __initdata am3517evm_i2c1_boardinfo[] = {
> {
> I2C_BOARD_INFO("s35390a", 0x30),
> - .type = "s35390a",
> },
> };
OK, I2C_BOARD_INFO sets it too.
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 26aeef5..02fd942 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -47,7 +47,7 @@ static struct omap_irq_bank {
> } __attribute__ ((aligned(4))) irq_banks[] = {
> {
> /* MPU INTC */
> - .base_reg = 0,
> + .base_reg = (void __iomem *)0,
> .nr_irqs = 96,
> },
> };
The base_reg line you can remove, the static data area gets zeroed
during init.
Regards,
Tony
^ permalink raw reply [flat|nested] 19+ messages in thread* RE: [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings
2010-09-16 19:27 ` Tony Lindgren
@ 2010-09-20 5:57 ` G, Manjunath Kondaiah
0 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-20 5:57 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap@vger.kernel.org, Menon, Nishanth
> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Friday, September 17, 2010 12:58 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap@vger.kernel.org; Menon, Nishanth
> Subject: Re: [PATCH 04/11] OMAP: mach-omap2: Fix
> miscellaneous sparse warnings
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100826 13:50]:
> > From: Manjunatha GK <manjugk@ti.com>
...
> > I2C_BOARD_INFO("s35390a", 0x30),
> > - .type = "s35390a",
> > },
> > };
>
> OK, I2C_BOARD_INFO sets it too.
>
> > diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> > index 26aeef5..02fd942 100644
> > --- a/arch/arm/mach-omap2/irq.c
> > +++ b/arch/arm/mach-omap2/irq.c
> > @@ -47,7 +47,7 @@ static struct omap_irq_bank { } __attribute__
> > ((aligned(4))) irq_banks[] = {
> > {
> > /* MPU INTC */
> > - .base_reg = 0,
> > + .base_reg = (void __iomem *)0,
> > .nr_irqs = 96,
> > },
> > };
>
> The base_reg line you can remove, the static data area gets
> zeroed during init.
Ok.
-Manjunath
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 05/11] OMAP: plat-omap: Fix static function warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (3 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 06/11] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
` (6 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes sparse warnings due non declarations of static functions.
arch/arm/plat-omap/sram.c:130:13: warning: symbol 'omap_detect_sram' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:216:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:348:12: warning: symbol 'omap242x_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:369:12: warning: symbol 'omap243x_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:425:12: warning: symbol 'omap34xx_sram_init' was not declared. Should it be static?
arch/arm/plat-omap/sram.c:441:12: warning: symbol 'omap44xx_sram_init' was not declared. Should it be static
arch/arm/plat-omap/mcbsp.c:36:6: warning: symbol 'omap_mcbsp_write' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:50:5: warning: symbol 'omap_mcbsp_read' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:65:6: warning: symbol 'omap_mcbsp_st_write' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:70:5: warning: symbol 'omap_mcbsp_st_read' was not declared. Should it be static?
arch/arm/plat-omap/mcbsp.c:1648:15: warning: symbol 'omap_st_add' was not declared. Should it be static?
arch/arm/plat-omap/fb.c:414:15: warning: symbol 'omapfb_reserve_sram' was not declared. Should it be static?
arch/arm/plat-omap/cpu-omap.c:43:5: warning: symbol 'omap_verify_speed' was not declared. Should it be static?
arch/arm/plat-omap/cpu-omap.c:61:14: warning: symbol 'omap_getspeed' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
arch/arm/plat-omap/cpu-omap.c | 4 ++--
arch/arm/plat-omap/fb.c | 1 +
arch/arm/plat-omap/mcbsp.c | 10 +++++-----
arch/arm/plat-omap/sram.c | 13 +++++++------
include/linux/omapfb.h | 5 +++++
5 files changed, 20 insertions(+), 13 deletions(-)
diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
index 6d3d333..11c54ec 100644
--- a/arch/arm/plat-omap/cpu-omap.c
+++ b/arch/arm/plat-omap/cpu-omap.c
@@ -40,7 +40,7 @@ static struct clk *mpu_clk;
/* TODO: Add support for SDRAM timing changes */
-int omap_verify_speed(struct cpufreq_policy *policy)
+static int omap_verify_speed(struct cpufreq_policy *policy)
{
if (freq_table)
return cpufreq_frequency_table_verify(policy, freq_table);
@@ -58,7 +58,7 @@ int omap_verify_speed(struct cpufreq_policy *policy)
return 0;
}
-unsigned int omap_getspeed(unsigned int cpu)
+static unsigned int omap_getspeed(unsigned int cpu)
{
unsigned long rate;
diff --git a/arch/arm/plat-omap/fb.c b/arch/arm/plat-omap/fb.c
index 0054b95..9a12893 100644
--- a/arch/arm/plat-omap/fb.c
+++ b/arch/arm/plat-omap/fb.c
@@ -421,3 +421,4 @@ unsigned long omapfb_reserve_sram(unsigned long sram_pstart,
}
#endif
+EXPORT_SYMBOL(omapfb_reserve_sram);
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c
index e31496e..a81fa35 100644
--- a/arch/arm/plat-omap/mcbsp.c
+++ b/arch/arm/plat-omap/mcbsp.c
@@ -33,7 +33,7 @@
struct omap_mcbsp **mcbsp_ptr;
int omap_mcbsp_count, omap_mcbsp_cache_size;
-void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
+static void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
{
if (cpu_class_is_omap1()) {
((u16 *)mcbsp->reg_cache)[reg / sizeof(u16)] = (u16)val;
@@ -47,7 +47,7 @@ void omap_mcbsp_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
}
}
-int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache)
+static int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache)
{
if (cpu_class_is_omap1()) {
return !from_cache ? __raw_readw(mcbsp->io_base + reg) :
@@ -62,12 +62,12 @@ int omap_mcbsp_read(struct omap_mcbsp *mcbsp, u16 reg, bool from_cache)
}
#ifdef CONFIG_ARCH_OMAP3
-void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
+static void omap_mcbsp_st_write(struct omap_mcbsp *mcbsp, u16 reg, u32 val)
{
__raw_writel(val, mcbsp->st_data->io_base_st + reg);
}
-int omap_mcbsp_st_read(struct omap_mcbsp *mcbsp, u16 reg)
+static int omap_mcbsp_st_read(struct omap_mcbsp *mcbsp, u16 reg)
{
return __raw_readl(mcbsp->st_data->io_base_st + reg);
}
@@ -1645,7 +1645,7 @@ static const struct attribute_group sidetone_attr_group = {
.attrs = (struct attribute **)sidetone_attrs,
};
-int __devinit omap_st_add(struct omap_mcbsp *mcbsp)
+static int __devinit omap_st_add(struct omap_mcbsp *mcbsp)
{
struct omap_mcbsp_platform_data *pdata = mcbsp->pdata;
struct omap_mcbsp_st_data *st_data;
diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
index 226b2e8..f178c2a 100644
--- a/arch/arm/plat-omap/sram.c
+++ b/arch/arm/plat-omap/sram.c
@@ -127,7 +127,7 @@ static int is_sram_locked(void)
* to secure SRAM will hang the system. Also the SRAM is not
* yet mapped at this point.
*/
-void __init omap_detect_sram(void)
+static void __init omap_detect_sram(void)
{
unsigned long reserved;
@@ -213,7 +213,7 @@ static struct map_desc omap_sram_io_desc[] __initdata = {
/*
* Note that we cannot use ioremap for SRAM, as clock init needs SRAM early.
*/
-void __init omap_map_sram(void)
+static void __init omap_map_sram(void)
{
unsigned long base;
@@ -345,7 +345,7 @@ u32 omap2_set_prcm(u32 dpll_ctrl_val, u32 sdrc_rfr_val, int bypass)
#endif
#ifdef CONFIG_ARCH_OMAP2420
-int __init omap242x_sram_init(void)
+static int __init omap242x_sram_init(void)
{
_omap2_sram_ddr_init = omap_sram_push(omap242x_sram_ddr_init,
omap242x_sram_ddr_init_sz);
@@ -366,7 +366,7 @@ static inline int omap242x_sram_init(void)
#endif
#ifdef CONFIG_ARCH_OMAP2430
-int __init omap243x_sram_init(void)
+static int __init omap243x_sram_init(void)
{
_omap2_sram_ddr_init = omap_sram_push(omap243x_sram_ddr_init,
omap243x_sram_ddr_init_sz);
@@ -422,7 +422,7 @@ void omap3_sram_restore_context(void)
}
#endif /* CONFIG_PM */
-int __init omap34xx_sram_init(void)
+static int __init omap34xx_sram_init(void)
{
_omap3_sram_configure_core_dpll =
omap_sram_push(omap3_sram_configure_core_dpll,
@@ -438,7 +438,7 @@ static inline int omap34xx_sram_init(void)
#endif
#ifdef CONFIG_ARCH_OMAP4
-int __init omap44xx_sram_init(void)
+static int __init omap44xx_sram_init(void)
{
printk(KERN_ERR "FIXME: %s not implemented\n", __func__);
@@ -469,3 +469,4 @@ int __init omap_sram_init(void)
return 0;
}
+EXPORT_SYMBOL(omap_sram_init);
diff --git a/include/linux/omapfb.h b/include/linux/omapfb.h
index c0b0187..059045e 100644
--- a/include/linux/omapfb.h
+++ b/include/linux/omapfb.h
@@ -257,6 +257,11 @@ struct omapfb_platform_data {
extern void omapfb_set_platform_data(struct omapfb_platform_data *data);
extern void omapfb_set_ctrl_platform_data(void *pdata);
extern void omapfb_reserve_sdram_memblock(void);
+extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart,
+ unsigned long sram_vstart,
+ unsigned long sram_size,
+ unsigned long pstart_avail,
+ unsigned long size_avail);
#endif
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 06/11] OMAP: McBSP: Fix static function warning
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (4 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 05/11] OMAP: plat-omap: Fix static function warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-31 7:34 ` Peter Ujfalusi
2010-08-26 20:56 ` [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning G, Manjunath Kondaiah
` (5 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes sparse warning due non declaration of static function
sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
sound/soc/omap/omap-mcbsp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 86f2139..5768381 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -780,7 +780,7 @@ struct snd_soc_dai omap_mcbsp_dai[] = {
EXPORT_SYMBOL_GPL(omap_mcbsp_dai);
-int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
+static int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_info *uinfo)
{
struct soc_mixer_control *mc =
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 06/11] OMAP: McBSP: Fix static function warning
2010-08-26 20:56 ` [PATCH 06/11] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
@ 2010-08-31 7:34 ` Peter Ujfalusi
0 siblings, 0 replies; 19+ messages in thread
From: Peter Ujfalusi @ 2010-08-31 7:34 UTC (permalink / raw)
To: ext G, Manjunath Kondaiah
Cc: linux-omap@vger.kernel.org, Tony Lindgren, Nishanth Menon
Hi,
this is audio related file, so use the alsa-devel for this patch, and also CC
the maintainers (Jarkko, Liam, Mark, and me).
On Thursday 26 August 2010 23:56:44 ext G, Manjunath Kondaiah wrote:
> From: Manjunatha GK <manjugk@ti.com>
>
> This patch fixes sparse warning due non declaration of static function
>
> sound/soc/omap/omap-mcbsp.c:783:5: warning: symbol
> 'omap_mcbsp_st_info_volsw' was not declared. Should it be static?
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> sound/soc/omap/omap-mcbsp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index 86f2139..5768381 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -780,7 +780,7 @@ struct snd_soc_dai omap_mcbsp_dai[] = {
>
> EXPORT_SYMBOL_GPL(omap_mcbsp_dai);
>
> -int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
> +static int omap_mcbsp_st_info_volsw(struct snd_kcontrol *kcontrol,
> struct snd_ctl_elem_info *uinfo)
> {
> struct soc_mixer_control *mc =
Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (5 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 06/11] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-27 9:03 ` kishore kadiyala
2010-08-26 20:56 ` [PATCH 08/11] OMAP: NAND: Fix static declaration warning G, Manjunath Kondaiah
` (4 subsequent siblings)
11 siblings, 1 reply; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
Fixes warning due to unused variable.
drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2308: warning: unused variable 'state'
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
drivers/mmc/host/omap_hsmmc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 4a8776f..fb6446a 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2305,7 +2305,6 @@ static int omap_hsmmc_suspend(struct device *dev)
int ret = 0;
struct platform_device *pdev = to_platform_device(dev);
struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
- pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
if (host && host->suspended)
return 0;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning
2010-08-26 20:56 ` [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning G, Manjunath Kondaiah
@ 2010-08-27 9:03 ` kishore kadiyala
0 siblings, 0 replies; 19+ messages in thread
From: kishore kadiyala @ 2010-08-27 9:03 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: linux-omap, Tony Lindgren, Nishanth Menon
Hi Manju,
Patch already posted here :
https://patchwork.kernel.org/patch/118871/
Regards,
Kishore
On Fri, Aug 27, 2010 at 2:26 AM, G, Manjunath Kondaiah <manjugk@ti.com> wrote:
> From: Manjunatha GK <manjugk@ti.com>
>
> Fixes warning due to unused variable.
>
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
> drivers/mmc/host/omap_hsmmc.c:2308: warning: unused variable 'state'
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> drivers/mmc/host/omap_hsmmc.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 4a8776f..fb6446a 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2305,7 +2305,6 @@ static int omap_hsmmc_suspend(struct device *dev)
> int ret = 0;
> struct platform_device *pdev = to_platform_device(dev);
> struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
> - pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
>
> if (host && host->suspended)
> return 0;
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 08/11] OMAP: NAND: Fix static declaration warning
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (6 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 09/11] TWL CORE: Fix sparse warning G, Manjunath Kondaiah
` (3 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
This patch fixes sparse warning for static declaration of variable "use_dma"
drivers/mtd/nand/omap2.c:114:11: warning: symbol 'use_dma' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
drivers/mtd/nand/omap2.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 133d515..439e80d 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -111,11 +111,11 @@ static int use_dma = 1;
module_param(use_dma, bool, 0);
MODULE_PARM_DESC(use_dma, "enable/disable use of DMA");
#else
-const int use_dma;
+static const int use_dma;
#endif
#else
const int use_prefetch;
-const int use_dma;
+static const int use_dma;
#endif
struct omap_nand_info {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 09/11] TWL CORE: Fix sparse warning
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (7 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 08/11] OMAP: NAND: Fix static declaration warning G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 10/11] TWL IRQ: Fix fucntion declaration warnings G, Manjunath Kondaiah
` (2 subsequent siblings)
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
Fixes below sparse warning.
drivers/mfd/twl-core.c:258:20: warning: symbol 'twl_map' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
drivers/mfd/twl-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 720e099..53c371a 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -255,7 +255,7 @@ struct twl_mapping {
unsigned char sid; /* Slave ID */
unsigned char base; /* base address */
};
-struct twl_mapping *twl_map;
+static struct twl_mapping *twl_map;
static struct twl_mapping twl4030_map[TWL4030_MODULE_LAST + 1] = {
/*
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 10/11] TWL IRQ: Fix fucntion declaration warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (8 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 09/11] TWL CORE: Fix sparse warning G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error G, Manjunath Kondaiah
2010-09-16 19:34 ` [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings Tony Lindgren
11 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
Fixes following sparse warnings for twl4030 and twl6030 irq files.
drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not declared. Should it be static?
drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not declared. Should it be static?
drivers/mfd/twl4030-irq.c:873:5: warning: symbol 'twl4030_init_chip_irq' was not declared. Should it be static?
drivers/mfd/twl6030-irq.c:226:5: warning: symbol 'twl6030_init_irq' was not declared. Should it be static?
drivers/mfd/twl6030-irq.c:290:5: warning: symbol 'twl6030_exit_irq' was not declared. Should it be static?
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
include/linux/i2c/twl.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index 6de90bf..c61e90a 100644
--- a/include/linux/i2c/twl.h
+++ b/include/linux/i2c/twl.h
@@ -172,6 +172,11 @@ int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
int twl6030_interrupt_unmask(u8 bit_mask, u8 offset);
int twl6030_interrupt_mask(u8 bit_mask, u8 offset);
+int twl6030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end);
+int twl6030_exit_irq(void);
+int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end);
+int twl4030_exit_irq(void);
+int twl4030_init_chip_irq(const char *chip);
/*----------------------------------------------------------------------*/
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (9 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 10/11] TWL IRQ: Fix fucntion declaration warnings G, Manjunath Kondaiah
@ 2010-08-26 20:56 ` G, Manjunath Kondaiah
2010-08-31 7:32 ` Peter Ujfalusi
2010-09-16 19:34 ` [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings Tony Lindgren
11 siblings, 1 reply; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-08-26 20:56 UTC (permalink / raw)
To: linux-omap; +Cc: Manjunatha GK, Tony Lindgren, Nishanth Menon
From: Manjunatha GK <manjugk@ti.com>
Fixes sparse warning for the below error
drivers/mfd/twl4030-codec.c:118:5: error: symbol 'twl4030_codec_disable_resource'
redeclared with different type (originally declared at include/linux/mfd/twl4030-
codec.h:268) - incompatible argument 1 (different signedness)
Signed-off-by: Manjunatha GK <manjugk@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>
---
include/linux/mfd/twl4030-codec.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/mfd/twl4030-codec.h b/include/linux/mfd/twl4030-codec.h
index 2ec317c..0f7300e 100644
--- a/include/linux/mfd/twl4030-codec.h
+++ b/include/linux/mfd/twl4030-codec.h
@@ -265,7 +265,7 @@ enum twl4030_codec_res {
TWL4030_CODEC_RES_MAX,
};
-int twl4030_codec_disable_resource(enum twl4030_codec_res id);
+int twl4030_codec_disable_resource(unsigned id);
int twl4030_codec_enable_resource(enum twl4030_codec_res id);
unsigned int twl4030_codec_get_mclk(void);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error
2010-08-26 20:56 ` [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error G, Manjunath Kondaiah
@ 2010-08-31 7:32 ` Peter Ujfalusi
0 siblings, 0 replies; 19+ messages in thread
From: Peter Ujfalusi @ 2010-08-31 7:32 UTC (permalink / raw)
To: ext G, Manjunath Kondaiah
Cc: linux-omap@vger.kernel.org, Tony Lindgren, Nishanth Menon
On Thursday 26 August 2010 23:56:49 ext G, Manjunath Kondaiah wrote:
> From: Manjunatha GK <manjugk@ti.com>
>
> Fixes sparse warning for the below error
>
> drivers/mfd/twl4030-codec.c:118:5: error: symbol
> 'twl4030_codec_disable_resource' redeclared with different type
> (originally declared at include/linux/mfd/twl4030- codec.h:268) -
> incompatible argument 1 (different signedness)
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> include/linux/mfd/twl4030-codec.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/mfd/twl4030-codec.h
> b/include/linux/mfd/twl4030-codec.h index 2ec317c..0f7300e 100644
> --- a/include/linux/mfd/twl4030-codec.h
> +++ b/include/linux/mfd/twl4030-codec.h
> @@ -265,7 +265,7 @@ enum twl4030_codec_res {
> TWL4030_CODEC_RES_MAX,
> };
>
> -int twl4030_codec_disable_resource(enum twl4030_codec_res id);
> +int twl4030_codec_disable_resource(unsigned id);
> int twl4030_codec_enable_resource(enum twl4030_codec_res id);
> unsigned int twl4030_codec_get_mclk(void);
I have no idea how this happened, but it would be better to correct the driver
instead the header.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
` (10 preceding siblings ...)
2010-08-26 20:56 ` [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error G, Manjunath Kondaiah
@ 2010-09-16 19:34 ` Tony Lindgren
2010-09-20 5:58 ` G, Manjunath Kondaiah
11 siblings, 1 reply; 19+ messages in thread
From: Tony Lindgren @ 2010-09-16 19:34 UTC (permalink / raw)
To: G, Manjunath Kondaiah; +Cc: linux-omap, Nishanth Menon
* G, Manjunath Kondaiah <manjugk@ti.com> [100826 13:50]:
> This patch series fixes sparse warnings for OMAP and TWL code.
> For better readabilty the patches are categorised based on type of
> sparse warnigns.
>
> The sparse warning logs are embedded with each patch followed
> by fix.
>
> Build and boot tested on omap3 with omap3_defconfig.
>
> Manjunatha GK (11):
> OMAP: mach-omap2: Fix incorrect assignment warnings
> OMAP: mach-omap2: Fix static declaration warnings
> OMAP: mach-omap2: Fix static function warnings
> OMAP: mach-omap2: Fix miscellaneous sparse warnings
> OMAP: plat-omap: Fix static function warnings
> OMAP: McBSP: Fix static function warning
> OMAP: HSMMC: Fix unused variable warning
> OMAP: NAND: Fix static declaration warning
> TWL CORE: Fix sparse warning
> TWL IRQ: Fix fucntion declaration warnings
> TWL4030: Codec: Fix fucntion declaration error
Looks like these are almost ready to go. Please repost against
v2.6.36-rc4 with linux-arm-kernel list Cc'd. Also check that
the related driver list is Cc'd.
Then, assuming no more comments, can you set up a git
branch somewhere for me to pull? For more info, see
"Merging patches using git" at:
http://www.elinux.org/OMAP_patch_merging_process#Patch_submission_checklist
Regards,
Tony
^ permalink raw reply [flat|nested] 19+ messages in thread* RE: [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings
2010-09-16 19:34 ` [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings Tony Lindgren
@ 2010-09-20 5:58 ` G, Manjunath Kondaiah
0 siblings, 0 replies; 19+ messages in thread
From: G, Manjunath Kondaiah @ 2010-09-20 5:58 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap@vger.kernel.org, Menon, Nishanth
Tony,
> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Friday, September 17, 2010 1:04 AM
> To: G, Manjunath Kondaiah
> Cc: linux-omap@vger.kernel.org; Menon, Nishanth
> Subject: Re: [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings
>
> * G, Manjunath Kondaiah <manjugk@ti.com> [100826 13:50]:
> > This patch series fixes sparse warnings for OMAP and TWL code.
> > For better readabilty the patches are categorised based on type of
> > sparse warnigns.
> >
> > The sparse warning logs are embedded with each patch
> followed by fix.
> >
> > Build and boot tested on omap3 with omap3_defconfig.
> >
> > Manjunatha GK (11):
> > OMAP: mach-omap2: Fix incorrect assignment warnings
> > OMAP: mach-omap2: Fix static declaration warnings
> > OMAP: mach-omap2: Fix static function warnings
> > OMAP: mach-omap2: Fix miscellaneous sparse warnings
> > OMAP: plat-omap: Fix static function warnings
> > OMAP: McBSP: Fix static function warning
> > OMAP: HSMMC: Fix unused variable warning
> > OMAP: NAND: Fix static declaration warning
> > TWL CORE: Fix sparse warning
> > TWL IRQ: Fix fucntion declaration warnings
> > TWL4030: Codec: Fix fucntion declaration error
>
> Looks like these are almost ready to go. Please repost against
> v2.6.36-rc4 with linux-arm-kernel list Cc'd. Also check that
> the related driver list is Cc'd.
>
> Then, assuming no more comments, can you set up a git branch
> somewhere for me to pull? For more info, see "Merging patches
> using git" at:
>
> http://www.elinux.org/OMAP_patch_merging_process#Patch_submiss
> ion_checklist
Ok. I will do that along with v2 version of this patch series.
-Manjunath
^ permalink raw reply [flat|nested] 19+ messages in thread