From: Mel Gorman <mel@csn.ul.ie>
To: Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/10] Hugepage migration (v5)
Date: Mon, 20 Sep 2010 12:14:18 +0100 [thread overview]
Message-ID: <20100920111417.GK1998@csn.ul.ie> (raw)
In-Reply-To: <20100909123306.32134d5e@basil.nowhere.org>
On Thu, Sep 09, 2010 at 12:33:06PM +0200, Andi Kleen wrote:
> On Wed, 8 Sep 2010 10:19:31 +0900
> Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
>
> > Hi,
> >
> > This is the 5th version of "hugepage migration" set.
> >
> > Changes from v4 (mostly refactoring):
> > - remove unnecessary might_sleep() [3/10]
> > - define migrate_huge_pages() from copy of migrate_pages() [4/10]
> > - soft_offline_page() branches off to hugepage path. [8/10]
>
> I went over this patchkit again and it all looks good to me.
> I plan to merge it through my hwpoison tree.
>
> As far as I understand all earlier comments have been addressed
> with this revision, correct?
>
> Thanks for your work, this is very good.
>
> But I would like to have some Acks from Christoph for the
> page migration changes and from Mel for the hugetlb changes
> outside memory-failures.c. Are the patches ok for you two?
> Can I have your Acked-by or Reviewed-by?
>
Sorry for taking so long to get back. I was snowed under by other work.
I've reviewed the bulk of the hugetlb changes that affect common paths.
There are a few small queries there but they are very minor. Once covered,
feel free to add by Acked-by. I didn't get the chance to actually test the
patches but they look ok.
> Any other comments would be welcome too.
>
> I am considering to fast track 10/10 (the page-types fix).
>
> I think the other bug fixes in the series are only for bugs added
> earlier in the series, correct?
>
That is what it looked like to me.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/10] Hugepage migration (v5)
Date: Mon, 20 Sep 2010 12:14:18 +0100 [thread overview]
Message-ID: <20100920111417.GK1998@csn.ul.ie> (raw)
In-Reply-To: <20100909123306.32134d5e@basil.nowhere.org>
On Thu, Sep 09, 2010 at 12:33:06PM +0200, Andi Kleen wrote:
> On Wed, 8 Sep 2010 10:19:31 +0900
> Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
>
> > Hi,
> >
> > This is the 5th version of "hugepage migration" set.
> >
> > Changes from v4 (mostly refactoring):
> > - remove unnecessary might_sleep() [3/10]
> > - define migrate_huge_pages() from copy of migrate_pages() [4/10]
> > - soft_offline_page() branches off to hugepage path. [8/10]
>
> I went over this patchkit again and it all looks good to me.
> I plan to merge it through my hwpoison tree.
>
> As far as I understand all earlier comments have been addressed
> with this revision, correct?
>
> Thanks for your work, this is very good.
>
> But I would like to have some Acks from Christoph for the
> page migration changes and from Mel for the hugetlb changes
> outside memory-failures.c. Are the patches ok for you two?
> Can I have your Acked-by or Reviewed-by?
>
Sorry for taking so long to get back. I was snowed under by other work.
I've reviewed the bulk of the hugetlb changes that affect common paths.
There are a few small queries there but they are very minor. Once covered,
feel free to add by Acked-by. I didn't get the chance to actually test the
patches but they look ok.
> Any other comments would be welcome too.
>
> I am considering to fast track 10/10 (the page-types fix).
>
> I think the other bug fixes in the series are only for bugs added
> earlier in the series, correct?
>
That is what it looked like to me.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-20 11:14 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 1:19 [PATCH 0/10] Hugepage migration (v5) Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 01/10] hugetlb: fix metadata corruption in hugetlb_fault() Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 10:47 ` Mel Gorman
2010-09-20 10:47 ` Mel Gorman
2010-09-22 20:41 ` Christoph Lameter
2010-09-22 20:41 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 02/10] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 10:59 ` Mel Gorman
2010-09-20 10:59 ` Mel Gorman
2010-09-22 4:41 ` Naoya Horiguchi
2010-09-22 4:41 ` Naoya Horiguchi
2010-09-22 8:37 ` Mel Gorman
2010-09-22 8:37 ` Mel Gorman
2010-09-22 21:05 ` Christoph Lameter
2010-09-22 21:05 ` Christoph Lameter
2010-09-23 8:49 ` Mel Gorman
2010-09-23 8:49 ` Mel Gorman
2010-09-23 16:02 ` Christoph Lameter
2010-09-23 16:02 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 03/10] hugetlb: redefine hugepage copy functions Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 11:03 ` Mel Gorman
2010-09-20 11:03 ` Mel Gorman
2010-09-20 11:15 ` Andi Kleen
2010-09-20 11:15 ` Andi Kleen
2010-09-20 11:18 ` Mel Gorman
2010-09-20 11:18 ` Mel Gorman
2010-09-23 16:21 ` Christoph Lameter
2010-09-23 16:21 ` Christoph Lameter
2010-09-24 3:24 ` Naoya Horiguchi
2010-09-24 3:24 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 04/10] hugetlb: hugepage migration core Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 11:10 ` Mel Gorman
2010-09-20 11:10 ` Mel Gorman
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 8:40 ` Mel Gorman
2010-09-22 8:40 ` Mel Gorman
2010-09-23 16:52 ` Christoph Lameter
2010-09-23 16:52 ` Christoph Lameter
2010-09-24 5:58 ` Naoya Horiguchi
2010-09-24 5:58 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 05/10] HWPOISON, hugetlb: add free check to dequeue_hwpoison_huge_page() Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-23 16:54 ` Christoph Lameter
2010-09-23 16:54 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 06/10] hugetlb: move refcounting in hugepage allocation inside hugetlb_lock Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-23 17:12 ` Christoph Lameter
2010-09-23 17:12 ` Christoph Lameter
2010-09-24 6:47 ` Naoya Horiguchi
2010-09-24 6:47 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 07/10] HWPOSION, hugetlb: recover from free hugepage error when !MF_COUNT_INCREASED Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 08/10] HWPOISON, hugetlb: soft offlining for hugepage Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 09/10] HWPOISON, hugetlb: fix unpoison " Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 10/10] page-types.c: fix name of unpoison interface Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-09 10:33 ` [PATCH 0/10] Hugepage migration (v5) Andi Kleen
2010-09-09 10:33 ` Andi Kleen
2010-09-09 22:56 ` Naoya Horiguchi
2010-09-09 22:56 ` Naoya Horiguchi
2010-09-20 11:14 ` Mel Gorman [this message]
2010-09-20 11:14 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920111417.GK1998@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.