From: Mel Gorman <mel@csn.ul.ie>
To: Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/10] hugetlb: redefine hugepage copy functions
Date: Mon, 20 Sep 2010 12:18:44 +0100 [thread overview]
Message-ID: <20100920111844.GL1998@csn.ul.ie> (raw)
In-Reply-To: <215a2d3717d0d55026688fb59ff7bb79.squirrel@www.firstfloor.org>
On Mon, Sep 20, 2010 at 01:15:44PM +0200, Andi Kleen wrote:
>
> >> +static void copy_gigantic_page(struct page *dst, struct page *src)
> >> +{
> >> + int i;
> >> + struct hstate *h = page_hstate(src);
> >> + struct page *dst_base = dst;
> >> + struct page *src_base = src;
> >> +
> >> + for (i = 0; i < pages_per_huge_page(h); ) {
> >> + cond_resched();
> >
> > Should this function not have a might_sleep() check too?
>
> cond_resched() implies might_sleep I believe. I think
> that answers the earlier question too becuse that function
> calls this.
>
You're right, cond_resched() calls might_sleep so the additional check
is redundant.
> /*
> >
> > Other than the removal of the might_sleep() check, this looks ok too.
>
> Can I assume an Ack?
>
Yes.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Andi Kleen <andi@firstfloor.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Jun'ichi Nomura <j-nomura@ce.jp.nec.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/10] hugetlb: redefine hugepage copy functions
Date: Mon, 20 Sep 2010 12:18:44 +0100 [thread overview]
Message-ID: <20100920111844.GL1998@csn.ul.ie> (raw)
In-Reply-To: <215a2d3717d0d55026688fb59ff7bb79.squirrel@www.firstfloor.org>
On Mon, Sep 20, 2010 at 01:15:44PM +0200, Andi Kleen wrote:
>
> >> +static void copy_gigantic_page(struct page *dst, struct page *src)
> >> +{
> >> + int i;
> >> + struct hstate *h = page_hstate(src);
> >> + struct page *dst_base = dst;
> >> + struct page *src_base = src;
> >> +
> >> + for (i = 0; i < pages_per_huge_page(h); ) {
> >> + cond_resched();
> >
> > Should this function not have a might_sleep() check too?
>
> cond_resched() implies might_sleep I believe. I think
> that answers the earlier question too becuse that function
> calls this.
>
You're right, cond_resched() calls might_sleep so the additional check
is redundant.
> /*
> >
> > Other than the removal of the might_sleep() check, this looks ok too.
>
> Can I assume an Ack?
>
Yes.
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-09-20 11:18 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 1:19 [PATCH 0/10] Hugepage migration (v5) Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 01/10] hugetlb: fix metadata corruption in hugetlb_fault() Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 10:47 ` Mel Gorman
2010-09-20 10:47 ` Mel Gorman
2010-09-22 20:41 ` Christoph Lameter
2010-09-22 20:41 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 02/10] hugetlb: add allocate function for hugepage migration Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 10:59 ` Mel Gorman
2010-09-20 10:59 ` Mel Gorman
2010-09-22 4:41 ` Naoya Horiguchi
2010-09-22 4:41 ` Naoya Horiguchi
2010-09-22 8:37 ` Mel Gorman
2010-09-22 8:37 ` Mel Gorman
2010-09-22 21:05 ` Christoph Lameter
2010-09-22 21:05 ` Christoph Lameter
2010-09-23 8:49 ` Mel Gorman
2010-09-23 8:49 ` Mel Gorman
2010-09-23 16:02 ` Christoph Lameter
2010-09-23 16:02 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 03/10] hugetlb: redefine hugepage copy functions Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 11:03 ` Mel Gorman
2010-09-20 11:03 ` Mel Gorman
2010-09-20 11:15 ` Andi Kleen
2010-09-20 11:15 ` Andi Kleen
2010-09-20 11:18 ` Mel Gorman [this message]
2010-09-20 11:18 ` Mel Gorman
2010-09-23 16:21 ` Christoph Lameter
2010-09-23 16:21 ` Christoph Lameter
2010-09-24 3:24 ` Naoya Horiguchi
2010-09-24 3:24 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 04/10] hugetlb: hugepage migration core Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-20 11:10 ` Mel Gorman
2010-09-20 11:10 ` Mel Gorman
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 4:59 ` Naoya Horiguchi
2010-09-22 8:40 ` Mel Gorman
2010-09-22 8:40 ` Mel Gorman
2010-09-23 16:52 ` Christoph Lameter
2010-09-23 16:52 ` Christoph Lameter
2010-09-24 5:58 ` Naoya Horiguchi
2010-09-24 5:58 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 05/10] HWPOISON, hugetlb: add free check to dequeue_hwpoison_huge_page() Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-23 16:54 ` Christoph Lameter
2010-09-23 16:54 ` Christoph Lameter
2010-09-08 1:19 ` [PATCH 06/10] hugetlb: move refcounting in hugepage allocation inside hugetlb_lock Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-23 17:12 ` Christoph Lameter
2010-09-23 17:12 ` Christoph Lameter
2010-09-24 6:47 ` Naoya Horiguchi
2010-09-24 6:47 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 07/10] HWPOSION, hugetlb: recover from free hugepage error when !MF_COUNT_INCREASED Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 08/10] HWPOISON, hugetlb: soft offlining for hugepage Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 09/10] HWPOISON, hugetlb: fix unpoison " Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-08 1:19 ` [PATCH 10/10] page-types.c: fix name of unpoison interface Naoya Horiguchi
2010-09-08 1:19 ` Naoya Horiguchi
2010-09-09 10:33 ` [PATCH 0/10] Hugepage migration (v5) Andi Kleen
2010-09-09 10:33 ` Andi Kleen
2010-09-09 22:56 ` Naoya Horiguchi
2010-09-09 22:56 ` Naoya Horiguchi
2010-09-20 11:14 ` Mel Gorman
2010-09-20 11:14 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2010-09-03 4:37 [PATCH 0/10] Hugepage migration (v4) Naoya Horiguchi
2010-09-03 4:37 ` [PATCH 03/10] hugetlb: redefine hugepage copy functions Naoya Horiguchi
2010-09-03 4:37 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920111844.GL1998@csn.ul.ie \
--to=mel@csn.ul.ie \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.