From: Chris Ball <cjb@laptop.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kyungmin.park@samsung.com,
kgene.kim@samsung.com, ben-linux@fluff.org,
akpm@linux-foundation.org, w.sang@pengutronix.de
Subject: Re: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge
Date: Tue, 21 Sep 2010 02:17:11 +0100 [thread overview]
Message-ID: <20100921011711.GB5873@void.printf.net> (raw)
In-Reply-To: <1284987822-17955-1-git-send-email-m.szyprowski@samsung.com>
On Mon, Sep 20, 2010 at 03:03:42PM +0200, Marek Szyprowski wrote:
> In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict
> in the sdhci-s3c driver been fixed. However the fix used incorrect
> spinlock operation - it cause a race with sdhci interrupt service. The
> correct way to solve it is to use spin_lock_irqsave/irqrestore() calls.
Thanks, applied to mmc-next with:
Signed-off-by: Chris Ball <cjb@laptop.org>
Andrew, not sure how best to get this upstream -- do you want to send
this up to Linus (for -rc5) via your queue in -mm?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
WARNING: multiple messages have this Message-ID (diff)
From: cjb@laptop.org (Chris Ball)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge
Date: Tue, 21 Sep 2010 02:17:11 +0100 [thread overview]
Message-ID: <20100921011711.GB5873@void.printf.net> (raw)
In-Reply-To: <1284987822-17955-1-git-send-email-m.szyprowski@samsung.com>
On Mon, Sep 20, 2010 at 03:03:42PM +0200, Marek Szyprowski wrote:
> In the commit f522886e202a34a2191dd5d471b3c4d46410a9a0 a merge conflict
> in the sdhci-s3c driver been fixed. However the fix used incorrect
> spinlock operation - it cause a race with sdhci interrupt service. The
> correct way to solve it is to use spin_lock_irqsave/irqrestore() calls.
Thanks, applied to mmc-next with:
Signed-off-by: Chris Ball <cjb@laptop.org>
Andrew, not sure how best to get this upstream -- do you want to send
this up to Linus (for -rc5) via your queue in -mm?
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-21 1:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 13:03 [PATCH] sdhci-s3c: fix incorrect spinlock usage after merge Marek Szyprowski
2010-09-20 13:03 ` Marek Szyprowski
2010-09-21 1:17 ` Chris Ball [this message]
2010-09-21 1:17 ` Chris Ball
2010-09-21 1:29 ` Andrew Morton
2010-09-21 1:29 ` Andrew Morton
2010-09-21 3:15 ` Chris Ball
2010-09-21 3:15 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921011711.GB5873@void.printf.net \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.