All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: fenghua.yu@intel.com, khali@linux-fr.org,
	gong.chen@linux.intel.com, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] x86/hwmon: fix module init for
Date: Fri, 24 Sep 2010 18:50:08 +0000	[thread overview]
Message-ID: <20100924185008.GA20110@ericsson.com> (raw)
In-Reply-To: <4C8E139F0200007800015AA5@vpn.id2.novell.com>

On Mon, Sep 13, 2010 at 10:05:51AM -0000, Jan Beulich wrote:
> In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to
> platform_driver_unregister() was made conditional upon !HOTPLUG_CPU,
> but the return value from coretemp_init() was left to indicate an
> error. This isn't correct, as the negative return value indicates to
> the module loader that initialization failed, which isn't intended
> here and results in dangling pointers.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Chen Gong <gong.chen@linux.intel.com>
> 
Looks like my previous mail got lost or stuck in our e-mail system.
Trying again. Sorry if this message is received twice.

I have not seen an Acked-by for this set of patches, nor a Nack. Since 
(most of) the patches fix real bugs, I applied the ones which do into
my staging tree, and the others into my -next tree.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jan Beulich <jbeulich@novell.com>
Cc: fenghua.yu@intel.com, khali@linux-fr.org,
	gong.chen@linux.intel.com, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: x86/hwmon: fix module init for hotplug-but-no-device-found case
Date: Fri, 24 Sep 2010 11:50:08 -0700	[thread overview]
Message-ID: <20100924185008.GA20110@ericsson.com> (raw)
In-Reply-To: <4C8E139F0200007800015AA5@vpn.id2.novell.com>

On Mon, Sep 13, 2010 at 10:05:51AM -0000, Jan Beulich wrote:
> In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to
> platform_driver_unregister() was made conditional upon !HOTPLUG_CPU,
> but the return value from coretemp_init() was left to indicate an
> error. This isn't correct, as the negative return value indicates to
> the module loader that initialization failed, which isn't intended
> here and results in dangling pointers.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Cc: Chen Gong <gong.chen@linux.intel.com>
> 
Looks like my previous mail got lost or stuck in our e-mail system.
Trying again. Sorry if this message is received twice.

I have not seen an Acked-by for this set of patches, nor a Nack. Since 
(most of) the patches fix real bugs, I applied the ones which do into
my staging tree, and the others into my -next tree.

Guenter

  parent reply	other threads:[~2010-09-24 18:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 10:05 [lm-sensors] [PATCH] x86/hwmon: fix module init for Jan Beulich
2010-09-13 10:05 ` [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case Jan Beulich
2010-09-14  6:30 ` [lm-sensors] [PATCH] x86/hwmon: fix module init Chen Gong
2010-09-14  6:30   ` [lm-sensors] [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case Chen Gong
2010-09-14  6:47   ` [lm-sensors] [PATCH] x86/hwmon: fix module init Jan Beulich
2010-09-14  6:47     ` [lm-sensors] [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case Jan Beulich
2010-09-14  7:46     ` [lm-sensors] [PATCH] x86/hwmon: fix module Chen Gong
2010-09-14  7:46       ` [lm-sensors] [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case Chen Gong
2010-09-14  8:19       ` [lm-sensors] [PATCH] x86/hwmon: fix module init for Jan Beulich
2010-09-14  8:19         ` [lm-sensors] [PATCH] x86/hwmon: fix module init for hotplug-but-no-device-found case Jan Beulich
2010-09-24  4:43 ` Guenter Roeck
2010-09-24 18:50 ` Guenter Roeck [this message]
2010-09-24 18:50   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924185008.GA20110@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=fenghua.yu@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=jbeulich@novell.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.