All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Yuri Ershov <ext-yuri.ershov@nokia.com>
Cc: eric.piel@tremplin-utc.net, samu.p.onkalo@nokia.com,
	akpm@linux-foundation.org, daniel@caiaq.de,
	ext-yuri.kululin@nokia.com, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [2/2] lis3: Set device owner
Date: Fri, 24 Sep 2010 20:27:31 +0000	[thread overview]
Message-ID: <20100924202731.GA20908@ericsson.com> (raw)
In-Reply-To: <f7f75208147a0655eda1ac402f07e98d745fc178.1282647258.git.ext-yuri.kululin@nokia.com>

On Fri, Aug 27, 2010 at 02:33:21PM -0000, Yuri Ershov wrote:
> Set device owner for i2c part.
> 
> Signed-off-by: Yuri Kululin <ext-yuri.kululin@nokia.com>
> 
> ---
> drivers/hwmon/lis3lv02d_i2c.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/lis3lv02d_i2c.c b/drivers/hwmon/lis3lv02d_i2c.c
> index b2f8bae..1a55bb3 100644
> --- a/drivers/hwmon/lis3lv02d_i2c.c
> +++ b/drivers/hwmon/lis3lv02d_i2c.c
> @@ -129,6 +129,7 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
>  	lis3_dev.reg_ctrl = lis3_reg_ctrl;
>  	lis3_dev.irq	  = client->irq;
>  	lis3_dev.ac	  = lis3lv02d_axis_map;
> +	lis3_dev.owner	  = THIS_MODULE;
>  
>  	i2c_set_clientdata(client, &lis3_dev);
>  
> @@ -149,6 +150,7 @@ static int __devexit lis3lv02d_i2c_remove(struct i2c_client *client)
>  
>  	lis3lv02d_joystick_disable();
>  	lis3lv02d_remove_fs(&lis3_dev);
> +	lis3_dev.owner = NULL;
>  
Should not be necessary, since you are about to unload the driver.
Unless I am missing something, of course.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Yuri Ershov <ext-yuri.ershov@nokia.com>
Cc: eric.piel@tremplin-utc.net, samu.p.onkalo@nokia.com,
	akpm@linux-foundation.org, daniel@caiaq.de,
	ext-yuri.kululin@nokia.com, lm-sensors@lm-sensors.org,
	linux-kernel@vger.kernel.org
Subject: Re: [2/2] lis3: Set device owner
Date: Fri, 24 Sep 2010 13:27:31 -0700	[thread overview]
Message-ID: <20100924202731.GA20908@ericsson.com> (raw)
In-Reply-To: <f7f75208147a0655eda1ac402f07e98d745fc178.1282647258.git.ext-yuri.kululin@nokia.com>

On Fri, Aug 27, 2010 at 02:33:21PM -0000, Yuri Ershov wrote:
> Set device owner for i2c part.
> 
> Signed-off-by: Yuri Kululin <ext-yuri.kululin@nokia.com>
> 
> ---
> drivers/hwmon/lis3lv02d_i2c.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/lis3lv02d_i2c.c b/drivers/hwmon/lis3lv02d_i2c.c
> index b2f8bae..1a55bb3 100644
> --- a/drivers/hwmon/lis3lv02d_i2c.c
> +++ b/drivers/hwmon/lis3lv02d_i2c.c
> @@ -129,6 +129,7 @@ static int __devinit lis3lv02d_i2c_probe(struct i2c_client *client,
>  	lis3_dev.reg_ctrl = lis3_reg_ctrl;
>  	lis3_dev.irq	  = client->irq;
>  	lis3_dev.ac	  = lis3lv02d_axis_map;
> +	lis3_dev.owner	  = THIS_MODULE;
>  
>  	i2c_set_clientdata(client, &lis3_dev);
>  
> @@ -149,6 +150,7 @@ static int __devexit lis3lv02d_i2c_remove(struct i2c_client *client)
>  
>  	lis3lv02d_joystick_disable();
>  	lis3lv02d_remove_fs(&lis3_dev);
> +	lis3_dev.owner = NULL;
>  
Should not be necessary, since you are about to unload the driver.
Unless I am missing something, of course.

Guenter


  reply	other threads:[~2010-09-24 20:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 14:33 [lm-sensors] [PATCH 0/2] Accelerometer driver unload Yuri Ershov
2010-08-27 14:33 ` Yuri Ershov
2010-08-27 14:33 ` [lm-sensors] [PATCH 1/2] lis3: Add device owner Yuri Ershov
2010-08-27 14:33   ` Yuri Ershov
2010-08-27 14:33   ` [lm-sensors] [PATCH 2/2] lis3: Set " Yuri Ershov
2010-08-27 14:33     ` Yuri Ershov
2010-09-24 20:27     ` Guenter Roeck [this message]
2010-09-24 20:27       ` [2/2] " Guenter Roeck
2010-09-24 20:24   ` [lm-sensors] [1/2] lis3: Add " Guenter Roeck
2010-09-24 20:24     ` Guenter Roeck
2010-09-28  8:52     ` [lm-sensors] " Yuri Kululin
2010-09-28  8:52       ` Yuri Kululin
2010-10-02  0:03       ` [lm-sensors] " Guenter Roeck
2010-10-02  0:03         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924202731.GA20908@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@caiaq.de \
    --cc=eric.piel@tremplin-utc.net \
    --cc=ext-yuri.ershov@nokia.com \
    --cc=ext-yuri.kululin@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=samu.p.onkalo@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.