All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Yuri Kululin <ext-yuri.kululin@nokia.com>
Cc: Yuri Ershov <ext-yuri.ershov@nokia.com>,
	"eric.piel@tremplin-utc.net" <eric.piel@tremplin-utc.net>,
	"samu.p.onkalo@nokia.com" <samu.p.onkalo@nokia.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"daniel@caiaq.de" <daniel@caiaq.de>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [1/2] lis3: Add device owner
Date: Sat, 02 Oct 2010 00:03:48 +0000	[thread overview]
Message-ID: <20101002000348.GB25276@ericsson.com> (raw)
In-Reply-To: <4CA1ACC3.4000809@nokia.com>

On Tue, Sep 28, 2010 at 04:52:19AM -0400, Yuri Kululin wrote:
[ ... ]
> 
> > On a higher level, reassigning the owner like this seems to be quite uncommon,
> > at least in hwmon. I would like to see an Acked-by from Eric to ensure
> > that the fix is correct.
> 
> I tried to use the standard way of module usage control because all functions 
> provided by lis3lv02d_i2c.c, lis3lv02d_spi.c or hp_accel.c can be called through 
>   lis3lv02d_misc_fops file ops or joystick poll device.
> 
> I can propose another solution. We can use try_module_get(owner) during device 
> registration (in lis3lv02d_add_fs()), release module by using module_put(owner) 
>   after device unregister (in lis3lv02d_remove_fs()) and do not touch 
> lis3lv02d_misc_fops. But anyway dev->owner should be set.
> 
Key is really to get feedback from others, since I am neither familiar
with module ownership handling nor with this driver.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Yuri Kululin <ext-yuri.kululin@nokia.com>
Cc: Yuri Ershov <ext-yuri.ershov@nokia.com>,
	"eric.piel@tremplin-utc.net" <eric.piel@tremplin-utc.net>,
	"samu.p.onkalo@nokia.com" <samu.p.onkalo@nokia.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"daniel@caiaq.de" <daniel@caiaq.de>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [1/2] lis3: Add device owner
Date: Fri, 1 Oct 2010 17:03:48 -0700	[thread overview]
Message-ID: <20101002000348.GB25276@ericsson.com> (raw)
In-Reply-To: <4CA1ACC3.4000809@nokia.com>

On Tue, Sep 28, 2010 at 04:52:19AM -0400, Yuri Kululin wrote:
[ ... ]
> 
> > On a higher level, reassigning the owner like this seems to be quite uncommon,
> > at least in hwmon. I would like to see an Acked-by from Eric to ensure
> > that the fix is correct.
> 
> I tried to use the standard way of module usage control because all functions 
> provided by lis3lv02d_i2c.c, lis3lv02d_spi.c or hp_accel.c can be called through 
>   lis3lv02d_misc_fops file ops or joystick poll device.
> 
> I can propose another solution. We can use try_module_get(owner) during device 
> registration (in lis3lv02d_add_fs()), release module by using module_put(owner) 
>   after device unregister (in lis3lv02d_remove_fs()) and do not touch 
> lis3lv02d_misc_fops. But anyway dev->owner should be set.
> 
Key is really to get feedback from others, since I am neither familiar
with module ownership handling nor with this driver.

Thanks,
Guenter

  reply	other threads:[~2010-10-02  0:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 14:33 [lm-sensors] [PATCH 0/2] Accelerometer driver unload Yuri Ershov
2010-08-27 14:33 ` Yuri Ershov
2010-08-27 14:33 ` [lm-sensors] [PATCH 1/2] lis3: Add device owner Yuri Ershov
2010-08-27 14:33   ` Yuri Ershov
2010-08-27 14:33   ` [lm-sensors] [PATCH 2/2] lis3: Set " Yuri Ershov
2010-08-27 14:33     ` Yuri Ershov
2010-09-24 20:27     ` [lm-sensors] [2/2] " Guenter Roeck
2010-09-24 20:27       ` Guenter Roeck
2010-09-24 20:24   ` [lm-sensors] [1/2] lis3: Add " Guenter Roeck
2010-09-24 20:24     ` Guenter Roeck
2010-09-28  8:52     ` [lm-sensors] " Yuri Kululin
2010-09-28  8:52       ` Yuri Kululin
2010-10-02  0:03       ` Guenter Roeck [this message]
2010-10-02  0:03         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101002000348.GB25276@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@caiaq.de \
    --cc=eric.piel@tremplin-utc.net \
    --cc=ext-yuri.ershov@nokia.com \
    --cc=ext-yuri.kululin@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=samu.p.onkalo@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.