From: Michal Marek <mmarek@suse.cz>
To: matt mooney <mfm@muteddisk.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Documentation/kbuild: correct variable definitions in
Date: Fri, 01 Oct 2010 20:56:46 +0000 [thread overview]
Message-ID: <20101001205646.GA10988@sepie.suse.cz> (raw)
In-Reply-To: <20100929231904.GB21930@haskell.muteddisk.com>
On Wed, Sep 29, 2010 at 04:19:04PM -0700, matt mooney wrote:
> On 19:50 Wed 29 Sep , Sam Ravnborg wrote:
> > On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> > > On 20.9.2010 08:33, matt mooney wrote:
> > > > Change $(src) and $(obj) definitions to state the path as absolute and
> > > > not relative.
> > >
> > > It _is_ a relative patch, AFAICS. What makes you think otherwise?
> >
> > With extenal modules $(src) and $(obj) are absolute - but in nomal
> > use they are relative.
Ah, I see. Then we should simply say "path", without any adjectives.
> > And again in normal use they are also equal. I usually say that we
> > have two just to document what is srource and what is generated.
>
> Ah, I see. Sorry, I should have looked into this more. Now you did say
> in normal use they are equal, but I thought they were also equal when
> used for an external module too.
Yes, they are, using $(src) for shipped files and $(obj) for generated
ones is just a service for the reader of the Makefile.
Michal
WARNING: multiple messages have this Message-ID (diff)
From: Michal Marek <mmarek@suse.cz>
To: matt mooney <mfm@muteddisk.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt
Date: Fri, 1 Oct 2010 22:56:46 +0200 [thread overview]
Message-ID: <20101001205646.GA10988@sepie.suse.cz> (raw)
In-Reply-To: <20100929231904.GB21930@haskell.muteddisk.com>
On Wed, Sep 29, 2010 at 04:19:04PM -0700, matt mooney wrote:
> On 19:50 Wed 29 Sep , Sam Ravnborg wrote:
> > On Wed, Sep 29, 2010 at 05:03:29PM +0200, Michal Marek wrote:
> > > On 20.9.2010 08:33, matt mooney wrote:
> > > > Change $(src) and $(obj) definitions to state the path as absolute and
> > > > not relative.
> > >
> > > It _is_ a relative patch, AFAICS. What makes you think otherwise?
> >
> > With extenal modules $(src) and $(obj) are absolute - but in nomal
> > use they are relative.
Ah, I see. Then we should simply say "path", without any adjectives.
> > And again in normal use they are also equal. I usually say that we
> > have two just to document what is srource and what is generated.
>
> Ah, I see. Sorry, I should have looked into this more. Now you did say
> in normal use they are equal, but I thought they were also equal when
> used for an external module too.
Yes, they are, using $(src) for shipped files and $(obj) for generated
ones is just a service for the reader of the Makefile.
Michal
next prev parent reply other threads:[~2010-10-01 20:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 6:33 [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt matt mooney
2010-09-20 6:33 ` matt mooney
2010-09-29 15:03 ` [PATCH] Documentation/kbuild: correct variable definitions in Michal Marek
2010-09-29 15:03 ` [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt Michal Marek
2010-09-29 17:50 ` [PATCH] Documentation/kbuild: correct variable definitions in Sam Ravnborg
2010-09-29 17:50 ` [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt Sam Ravnborg
2010-09-29 23:19 ` [PATCH] Documentation/kbuild: correct variable definitions in matt mooney
2010-09-29 23:19 ` [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt matt mooney
2010-10-01 20:56 ` Michal Marek [this message]
2010-10-01 20:56 ` Michal Marek
2010-10-02 4:14 ` [PATCH] Documentation/kbuild: correct variable definitions in matt mooney
2010-10-02 4:14 ` [PATCH] Documentation/kbuild: correct variable definitions in makefiles.txt matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001205646.GA10988@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.