From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, John Clark <clarkjc@runbox.com>
Subject: Re: [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation
Date: Tue, 5 Oct 2010 19:00:03 +0200 [thread overview]
Message-ID: <20101005170003.GA12478@laped.lan> (raw)
In-Reply-To: <79964C6A-5575-4DF7-9F3F-920E576B4460@suse.de>
On Tue, Oct 05, 2010 at 06:42:34PM +0200, Alexander Graf wrote:
>
> On 02.10.2010, at 20:17, John Clark wrote:
>
> >> Hi,
> >>
> >> Alex:
> >> I think you've missed the part of the patch that renames the _lo -> _hi.
> >> As John says, qemu had the hi/lo parts reversed when reading 4xx TLB regs.
> >>
> >> Except for the comments and the define, the patch looks good to me.
> >> John, please also add a Signed-off-by line.
> >>
> >> Cheers
> >
> > Ok, I have removed the superfluous comments, added defines for magic
> > numbers, added braces to conform to the QEMU coding style guidelines,
> > and regression tested it in my system. Patch included below.
> >
> > Thanks.
> >
> > - John
> >
> > Signed-off-by: John Clark <clarkjc@runbox.com>
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
Applied, thanks John and Alex.
Cheers
next prev parent reply other threads:[~2010-10-05 17:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 5:38 [Qemu-devel] Minor MMU fixes for PowerPC 40x emulation John Clark
2010-10-02 9:35 ` Alexander Graf
[not found] ` <4CA762B1.7060505@runbox.com>
2010-10-02 16:55 ` Alexander Graf
2010-10-02 17:04 ` John Clark
2010-10-02 17:06 ` Edgar E. Iglesias
2010-10-02 17:10 ` Alexander Graf
2010-10-02 18:17 ` John Clark
2010-10-05 16:42 ` Alexander Graf
2010-10-05 17:00 ` Edgar E. Iglesias [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-02 16:54 John Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005170003.GA12478@laped.lan \
--to=edgar.iglesias@gmail.com \
--cc=agraf@suse.de \
--cc=clarkjc@runbox.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.