Re: [PATCH v6 07/12] Add async PF initialization to PV guest.

[Gleb Natapov <gleb@redhat.com>]

On Tue, Oct 05, 2010 at 03:25:54PM -0300, Marcelo Tosatti wrote:
> On Mon, Oct 04, 2010 at 05:56:29PM +0200, Gleb Natapov wrote:
> > Enable async PF in a guest if async PF capability is discovered.
> > 
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > ---
> >  Documentation/kernel-parameters.txt |    3 +
> >  arch/x86/include/asm/kvm_para.h     |    5 ++
> >  arch/x86/kernel/kvm.c               |   92 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 100 insertions(+), 0 deletions(-)
> > 
> 
> > +static int __cpuinit kvm_cpu_notify(struct notifier_block *self,
> > +				    unsigned long action, void *hcpu)
> > +{
> > +	int cpu = (unsigned long)hcpu;
> > +	switch (action) {
> > +	case CPU_ONLINE:
> > +	case CPU_DOWN_FAILED:
> > +	case CPU_ONLINE_FROZEN:
> > +		smp_call_function_single(cpu, kvm_guest_cpu_notify, NULL, 0);
> 
> wait parameter should probably be 1.
Why should we wait for it? FWIW I copied this from somewhere (May be
arch/x86/pci/amd_bus.c).

--
			Gleb.