From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ryan Mallon <ryan@bluewatersys.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
timur@freescale.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: Add CS4271 codec support
Date: Wed, 6 Oct 2010 17:49:41 -0700 [thread overview]
Message-ID: <20101007004940.GC30751@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CAD16A5.1090501@bluewatersys.com>
On Thu, Oct 07, 2010 at 01:39:01PM +1300, Ryan Mallon wrote:
> From: Alexander Sverdlin <subaparts@yandex.ru>
>
> Added support for Cirrus CS4271 codec to ALSA SoC subsystem.
>
> Applies on: 2.6.36-rc6
Unfortunately there have been major changes in the ASoC APIs in -next
for Liam's multi-component work so you'll need to update this before it
can be applied. You should always submit code against -next (except for
bug fixes to be sent to Linus).
See
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
for current code.
I gave the driver a quick review and it looks really good - it just
needs to be updated for current APIs.
> +static const struct snd_kcontrol_new cs4271_snd_controls[] = {
> + SOC_DOUBLE_R("Master Playback Volume", CS4271_VOLA, CS4271_VOLB, 0, 0x7F, 1),
TLV information would be nice but isn't essential.
> + SOC_SINGLE("Digital Loopback Switch", CS4271_MODE2, 4, 1, 0),
This should probably be done as part of DAPM. Again probably not
essential.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: Add CS4271 codec support
Date: Wed, 6 Oct 2010 17:49:41 -0700 [thread overview]
Message-ID: <20101007004940.GC30751@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4CAD16A5.1090501@bluewatersys.com>
On Thu, Oct 07, 2010 at 01:39:01PM +1300, Ryan Mallon wrote:
> From: Alexander Sverdlin <subaparts@yandex.ru>
>
> Added support for Cirrus CS4271 codec to ALSA SoC subsystem.
>
> Applies on: 2.6.36-rc6
Unfortunately there have been major changes in the ASoC APIs in -next
for Liam's multi-component work so you'll need to update this before it
can be applied. You should always submit code against -next (except for
bug fixes to be sent to Linus).
See
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
for current code.
I gave the driver a quick review and it looks really good - it just
needs to be updated for current APIs.
> +static const struct snd_kcontrol_new cs4271_snd_controls[] = {
> + SOC_DOUBLE_R("Master Playback Volume", CS4271_VOLA, CS4271_VOLB, 0, 0x7F, 1),
TLV information would be nice but isn't essential.
> + SOC_SINGLE("Digital Loopback Switch", CS4271_MODE2, 4, 1, 0),
This should probably be done as part of DAPM. Again probably not
essential.
next prev parent reply other threads:[~2010-10-07 0:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 0:39 [PATCH 1/2] ASoC: Add CS4271 codec support Ryan Mallon
2010-10-07 0:39 ` Ryan Mallon
2010-10-07 0:49 ` Mark Brown [this message]
2010-10-07 0:49 ` Mark Brown
2010-10-07 0:53 ` Ryan Mallon
2010-10-07 0:53 ` Ryan Mallon
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` [PATCH 2/2] ASoC: EDB93xx machine sound driver Ryan Mallon
2010-10-07 0:50 ` Ryan Mallon
2010-10-07 3:12 ` Mark Brown
2010-10-07 3:12 ` Mark Brown
2010-10-07 21:46 ` [PATCH 1/2] ASoC: Add CS4271 codec support Timur Tabi
2010-10-07 21:46 ` Timur Tabi
2010-10-07 21:59 ` Ryan Mallon
2010-10-07 21:59 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007004940.GC30751@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=ryan@bluewatersys.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.