From: Timur Tabi <timur@freescale.com>
To: Ryan Mallon <ryan@bluewatersys.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: Add CS4271 codec support
Date: Thu, 7 Oct 2010 16:46:20 -0500 [thread overview]
Message-ID: <4CAE3FAC.6010508@freescale.com> (raw)
In-Reply-To: <4CAD16A5.1090501@bluewatersys.com>
Ryan Mallon wrote:
> + * For setups with variable MCLKs, pass 0 as 'freq' argument. This will cause
> + * theoretically possible sample rates to be enabled. Call it again with a
> + * proper value set one the external clock is set (most probably you would do
> + * that from a machine's driver 'hw_param' hook.
If you're going to copy/paste parts of my driver verbatim into yours, you should
put something like this in the comments:
Based on the CS4270 driver by Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: timur@freescale.com (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: Add CS4271 codec support
Date: Thu, 7 Oct 2010 16:46:20 -0500 [thread overview]
Message-ID: <4CAE3FAC.6010508@freescale.com> (raw)
In-Reply-To: <4CAD16A5.1090501@bluewatersys.com>
Ryan Mallon wrote:
> + * For setups with variable MCLKs, pass 0 as 'freq' argument. This will cause
> + * theoretically possible sample rates to be enabled. Call it again with a
> + * proper value set one the external clock is set (most probably you would do
> + * that from a machine's driver 'hw_param' hook.
If you're going to copy/paste parts of my driver verbatim into yours, you should
put something like this in the comments:
Based on the CS4270 driver by Timur Tabi <timur@freescale.com>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-10-07 21:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 0:39 [PATCH 1/2] ASoC: Add CS4271 codec support Ryan Mallon
2010-10-07 0:39 ` Ryan Mallon
2010-10-07 0:49 ` Mark Brown
2010-10-07 0:49 ` Mark Brown
2010-10-07 0:53 ` Ryan Mallon
2010-10-07 0:53 ` Ryan Mallon
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` [PATCH 2/2] ASoC: EDB93xx machine sound driver Ryan Mallon
2010-10-07 0:50 ` Ryan Mallon
2010-10-07 3:12 ` Mark Brown
2010-10-07 3:12 ` Mark Brown
2010-10-07 21:46 ` Timur Tabi [this message]
2010-10-07 21:46 ` [PATCH 1/2] ASoC: Add CS4271 codec support Timur Tabi
2010-10-07 21:59 ` Ryan Mallon
2010-10-07 21:59 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAE3FAC.6010508@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.