All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andres Salomon <dilinger@queued.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: David Miller <davem@davemloft.net>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	sam@ravnborg.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export
Date: Fri, 08 Oct 2010 18:38:55 +0000	[thread overview]
Message-ID: <20101008113855.7d37d394@debxo> (raw)
In-Reply-To: <20101008182745.GI3863@angua.secretlab.ca>

On Fri, 8 Oct 2010 12:27:45 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:

> On Fri, Oct 08, 2010 at 10:45:57AM -0700, David Miller wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> > Date: Fri, 8 Oct 2010 11:36:50 -0600
> > 
> > > Weird.  Yeah, no other platforms expect to get a phandle type
> > > definition from the kernel headers.  The only thing driving this
> > > conversation is from arch/sparc/include/asm/Kbuild:
> > > 
> > > header-y += openprom.h
> > 
> > It was probably at one point for the sake of asm/openpromio.h but
> > that header has no dependencies on openprom.h
> > 
> > The only hit I can find in google code search, for non-kernel code,
> > is the SILO bootloader.
> > 
> > But that tree includes it's own copy of include/asm/openprom.h so
> > the actual kernel copy isn't even used.
> > 
> > I'd say we can stop exporting that header and also therefore not
> > worry about making phandle_t visible to userspace.
> 
> Yay!  That simplifies everything, and I believe it also means that the
> phandle/ihandle definitions can remain where they currently are in
> linux/of.h
> 
> Andres, can you post an updated series that includes removing
> openprom.h from the header export list?
> 

Sure, I'll just need to rework/retest the build.  I've already done
that with the openprom.h-removal patch (which was just sent).


WARNING: multiple messages have this Message-ID (diff)
From: Andres Salomon <dilinger@queued.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: David Miller <davem@davemloft.net>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	sam@ravnborg.org, devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace
Date: Fri, 8 Oct 2010 11:38:55 -0700	[thread overview]
Message-ID: <20101008113855.7d37d394@debxo> (raw)
In-Reply-To: <20101008182745.GI3863@angua.secretlab.ca>

On Fri, 8 Oct 2010 12:27:45 -0600
Grant Likely <grant.likely@secretlab.ca> wrote:

> On Fri, Oct 08, 2010 at 10:45:57AM -0700, David Miller wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> > Date: Fri, 8 Oct 2010 11:36:50 -0600
> > 
> > > Weird.  Yeah, no other platforms expect to get a phandle type
> > > definition from the kernel headers.  The only thing driving this
> > > conversation is from arch/sparc/include/asm/Kbuild:
> > > 
> > > header-y += openprom.h
> > 
> > It was probably at one point for the sake of asm/openpromio.h but
> > that header has no dependencies on openprom.h
> > 
> > The only hit I can find in google code search, for non-kernel code,
> > is the SILO bootloader.
> > 
> > But that tree includes it's own copy of include/asm/openprom.h so
> > the actual kernel copy isn't even used.
> > 
> > I'd say we can stop exporting that header and also therefore not
> > worry about making phandle_t visible to userspace.
> 
> Yay!  That simplifies everything, and I believe it also means that the
> phandle/ihandle definitions can remain where they currently are in
> linux/of.h
> 
> Andres, can you post an updated series that includes removing
> openprom.h from the header export list?
> 

Sure, I'll just need to rework/retest the build.  I've already done
that with the openprom.h-removal patch (which was just sent).


  reply	other threads:[~2010-10-08 18:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08  7:43 [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to Andres Salomon
2010-10-08  7:43 ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace Andres Salomon
2010-10-08  7:43 ` Andres Salomon
2010-10-08 17:12 ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and Grant Likely
2010-10-08 17:12   ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace Grant Likely
2010-10-08 17:17   ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and David Miller
2010-10-08 17:17     ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace David Miller
2010-10-08 17:36     ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and Grant Likely
2010-10-08 17:36       ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace Grant Likely
     [not found]       ` <20101008173650.GH3863-MrY2KI0G/OVr83L8+7iqerDks+cytr/Z@public.gmane.org>
2010-10-08 17:45         ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and David Miller
2010-10-08 17:45           ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace David Miller
2010-10-08 17:45           ` David Miller
2010-10-08 18:27           ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and Grant Likely
2010-10-08 18:27             ` [PATCH 1/2 v2] of: move phandle/ihandle into types.h and export to userspace Grant Likely
2010-10-08 18:38             ` Andres Salomon [this message]
2010-10-08 18:38               ` Andres Salomon
2010-10-08 18:34           ` [PATCH] sparc: stop exporting openprom.h header Andres Salomon
2010-10-08 18:34             ` Andres Salomon
2010-10-08 18:52             ` David Miller
2010-10-08 18:52               ` David Miller
2010-10-08 19:00               ` Grant Likely
2010-10-08 19:00                 ` Grant Likely
2010-10-08 19:00                 ` Grant Likely
     [not found]                 ` <AANLkTikuaM5VZadCs302HwYYhOHi1Czw2BLam3ZQP=aj-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-08 19:02                   ` David Miller
2010-10-08 19:02                     ` David Miller
2010-10-08 19:02                     ` David Miller
2010-10-08 21:34                 ` Andres Salomon
2010-10-08 21:34                   ` Andres Salomon
2010-10-08 21:34                   ` Andres Salomon
2010-10-09  8:51                   ` Grant Likely
2010-10-09  8:51                     ` Grant Likely
2010-10-09  8:51                     ` Grant Likely
2010-10-09 20:48                     ` Andres Salomon
2010-10-09 20:48                       ` Andres Salomon
2010-10-10  5:13                       ` Grant Likely
2010-10-10  5:13                         ` Grant Likely
2010-10-10  7:19                         ` Andres Salomon
2010-10-10  7:19                           ` Andres Salomon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101008113855.7d37d394@debxo \
    --to=dilinger@queued.net \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.