All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: [patch 2/2] OSS: soundcard: fix return value of sound_open()
Date: Sun, 10 Oct 2010 19:34:22 +0200	[thread overview]
Message-ID: <20101010173422.GC5851@bicker> (raw)

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index a5ab61e..46c0d03 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
 	}
 
 	mutex_unlock(&soundcard_mutex);
-	return 0;
+	return retval;
 }
 
 static int sound_release(struct inode *inode, struct file *file)

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: [patch 2/2] OSS: soundcard: fix return value of sound_open()
Date: Sun, 10 Oct 2010 17:34:22 +0000	[thread overview]
Message-ID: <20101010173422.GC5851@bicker> (raw)

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index a5ab61e..46c0d03 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
 	}
 
 	mutex_unlock(&soundcard_mutex);
-	return 0;
+	return retval;
 }
 
 static int sound_release(struct inode *inode, struct file *file)

             reply	other threads:[~2010-10-10 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-10 17:34 Dan Carpenter [this message]
2010-10-10 17:34 ` [patch 2/2] OSS: soundcard: fix return value of sound_open() Dan Carpenter
2010-10-11 11:59 ` Takashi Iwai
2010-10-11 11:59   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101010173422.GC5851@bicker \
    --to=error27@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.