All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 2/2] OSS: soundcard: fix return value of sound_open()
@ 2010-10-10 17:34 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-10 17:34 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index a5ab61e..46c0d03 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
 	}
 
 	mutex_unlock(&soundcard_mutex);
-	return 0;
+	return retval;
 }
 
 static int sound_release(struct inode *inode, struct file *file)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [patch 2/2] OSS: soundcard: fix return value of sound_open()
@ 2010-10-10 17:34 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-10-10 17:34 UTC (permalink / raw)
  To: Jaroslav Kysela; +Cc: Takashi Iwai, alsa-devel, kernel-janitors

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
index a5ab61e..46c0d03 100644
--- a/sound/oss/soundcard.c
+++ b/sound/oss/soundcard.c
@@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
 	}
 
 	mutex_unlock(&soundcard_mutex);
-	return 0;
+	return retval;
 }
 
 static int sound_release(struct inode *inode, struct file *file)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [patch 2/2] OSS: soundcard: fix return value of sound_open()
  2010-10-10 17:34 ` Dan Carpenter
@ 2010-10-11 11:59   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-10-11 11:59 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors

At Sun, 10 Oct 2010 19:34:22 +0200,
Dan Carpenter wrote:
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied.  Thanks.


Takashi


> diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
> index a5ab61e..46c0d03 100644
> --- a/sound/oss/soundcard.c
> +++ b/sound/oss/soundcard.c
> @@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
>  	}
>  
>  	mutex_unlock(&soundcard_mutex);
> -	return 0;
> +	return retval;
>  }
>  
>  static int sound_release(struct inode *inode, struct file *file)
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch 2/2] OSS: soundcard: fix return value of sound_open()
@ 2010-10-11 11:59   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2010-10-11 11:59 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: alsa-devel, kernel-janitors

At Sun, 10 Oct 2010 19:34:22 +0200,
Dan Carpenter wrote:
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied.  Thanks.


Takashi


> diff --git a/sound/oss/soundcard.c b/sound/oss/soundcard.c
> index a5ab61e..46c0d03 100644
> --- a/sound/oss/soundcard.c
> +++ b/sound/oss/soundcard.c
> @@ -249,7 +249,7 @@ static int sound_open(struct inode *inode, struct file *file)
>  	}
>  
>  	mutex_unlock(&soundcard_mutex);
> -	return 0;
> +	return retval;
>  }
>  
>  static int sound_release(struct inode *inode, struct file *file)
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-10-11 11:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-10 17:34 [patch 2/2] OSS: soundcard: fix return value of sound_open() Dan Carpenter
2010-10-10 17:34 ` Dan Carpenter
2010-10-11 11:59 ` Takashi Iwai
2010-10-11 11:59   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.