All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	"Govindraj.R" <govindraj.raja@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error
Date: Tue, 12 Oct 2010 18:02:27 +0000	[thread overview]
Message-ID: <20101012180227.GA11846@kroah.com> (raw)
In-Reply-To: <1286731715-17908-1-git-send-email-segooon@gmail.com>

On Sun, Oct 10, 2010 at 09:28:35PM +0400, Vasiliy Kulikov wrote:
> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
> 
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
>  I cannot compile this driver, so it is not tested.
> 
>  drivers/serial/omap-serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

This seems to be in the omap tree, and not in my tree, so you will need
to push this through the omap maintainers.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
	"Govindraj.R" <govindraj.raja@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error
Date: Tue, 12 Oct 2010 11:02:27 -0700	[thread overview]
Message-ID: <20101012180227.GA11846@kroah.com> (raw)
In-Reply-To: <1286731715-17908-1-git-send-email-segooon@gmail.com>

On Sun, Oct 10, 2010 at 09:28:35PM +0400, Vasiliy Kulikov wrote:
> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
> 
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
>  I cannot compile this driver, so it is not tested.
> 
>  drivers/serial/omap-serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

This seems to be in the omap tree, and not in my tree, so you will need
to push this through the omap maintainers.

thanks,

greg k-h

  reply	other threads:[~2010-10-12 18:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-10 17:28 [PATCH] serial: omap-serial: fix signess error Vasiliy Kulikov
2010-10-10 17:28 ` Vasiliy Kulikov
2010-10-12 18:02 ` Greg KH [this message]
2010-10-12 18:02   ` Greg KH
2010-10-12 18:39 ` Kevin Hilman
2010-10-12 18:39   ` Kevin Hilman
2010-10-12 20:21   ` Tony Lindgren
2010-10-12 20:21     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101012180227.GA11846@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=govindraj.raja@ti.com \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=segooon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.