From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Vasiliy Kulikov <segooon@gmail.com>,
kernel-janitors@vger.kernel.org,
"Govindraj.R" <govindraj.raja@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error
Date: Tue, 12 Oct 2010 20:21:05 +0000 [thread overview]
Message-ID: <20101012202105.GW25462@atomide.com> (raw)
In-Reply-To: <8739sb1cif.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101012 11:30]:
> [adding linux-omap list]
>
> Vasiliy Kulikov <segooon@gmail.com> writes:
>
> > "ret" is unsigned, so check for (ret < 0) made no sense.
> > Made it signed.
> >
> > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > ---
> > I cannot compile this driver, so it is not tested.
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Since the original driver is being queued via the omap tree, we can
> queue this one as well.
>
> Tony, can you add this one to the 2.6.37 queue?
Thanks, adding into omap-for-linus.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Vasiliy Kulikov <segooon@gmail.com>,
kernel-janitors@vger.kernel.org,
"Govindraj.R" <govindraj.raja@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error
Date: Tue, 12 Oct 2010 13:21:05 -0700 [thread overview]
Message-ID: <20101012202105.GW25462@atomide.com> (raw)
In-Reply-To: <8739sb1cif.fsf@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [101012 11:30]:
> [adding linux-omap list]
>
> Vasiliy Kulikov <segooon@gmail.com> writes:
>
> > "ret" is unsigned, so check for (ret < 0) made no sense.
> > Made it signed.
> >
> > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> > ---
> > I cannot compile this driver, so it is not tested.
>
> Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> Since the original driver is being queued via the omap tree, we can
> queue this one as well.
>
> Tony, can you add this one to the 2.6.37 queue?
Thanks, adding into omap-for-linus.
Regards,
Tony
next prev parent reply other threads:[~2010-10-12 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 17:28 [PATCH] serial: omap-serial: fix signess error Vasiliy Kulikov
2010-10-10 17:28 ` Vasiliy Kulikov
2010-10-12 18:02 ` Greg KH
2010-10-12 18:02 ` Greg KH
2010-10-12 18:39 ` Kevin Hilman
2010-10-12 18:39 ` Kevin Hilman
2010-10-12 20:21 ` Tony Lindgren [this message]
2010-10-12 20:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101012202105.GW25462@atomide.com \
--to=tony@atomide.com \
--cc=alan@linux.intel.com \
--cc=govindraj.raja@ti.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.