From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
jassi.brar@samsung.com, ben-linux@fluff.org,
'Seungwhan Youn' <sw.youn@samsung.com>,
linux-arm-kernel@lists.infradead.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning
Date: Wed, 13 Oct 2010 09:09:02 +0100 [thread overview]
Message-ID: <20101013080902.GA6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <002301cb6aac$12a05e10$37e11a30$%kim@samsung.com>
On Wed, Oct 13, 2010 at 04:55:55PM +0900, Kukjin Kim wrote:
> Seungwhan Youn wrote:
> > This patch adds warning about changing EPLL rate to notice that other
> > driver that controls H/W, which is using EPLL, will has unknown effects
> > by this EPLL rate change.
> > + printk(KERN_WARNING "EPLL Rate changes from %lu to %lu\n",
> > + clk->rate, rate);
> Do we really need KERN_WARNING here?
> How about just KERN_INFO?...In my opinion, to change EPLL value seems to be
> nearer 'information' message more than 'warning'.
Personally I don't think it really makes much odds so long as the
message is displayed on the console by default.
WARNING: multiple messages have this Message-ID (diff)
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning
Date: Wed, 13 Oct 2010 09:09:02 +0100 [thread overview]
Message-ID: <20101013080902.GA6424@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <002301cb6aac$12a05e10$37e11a30$%kim@samsung.com>
On Wed, Oct 13, 2010 at 04:55:55PM +0900, Kukjin Kim wrote:
> Seungwhan Youn wrote:
> > This patch adds warning about changing EPLL rate to notice that other
> > driver that controls H/W, which is using EPLL, will has unknown effects
> > by this EPLL rate change.
> > + printk(KERN_WARNING "EPLL Rate changes from %lu to %lu\n",
> > + clk->rate, rate);
> Do we really need KERN_WARNING here?
> How about just KERN_INFO?...In my opinion, to change EPLL value seems to be
> nearer 'information' message more than 'warning'.
Personally I don't think it really makes much odds so long as the
message is displayed on the console by default.
next prev parent reply other threads:[~2010-10-13 8:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-12 11:19 [PATCH v2 0/6] Add S/PDIF common driver for Samsung SoCs Seungwhan Youn
2010-10-12 11:19 ` Seungwhan Youn
2010-10-12 11:34 ` [PATCH v2 1/6] ARM: S5P: Reduce duplicated EPLL control codes Seungwhan Youn
2010-10-12 11:34 ` Seungwhan Youn
2010-10-13 8:05 ` Kukjin Kim
2010-10-13 8:05 ` Kukjin Kim
2010-10-13 8:48 ` Seungwhan Youn
2010-10-13 8:48 ` Seungwhan Youn
2010-10-12 11:37 ` [PATCH v2 2/6] ARM: S5PV210: Fix wrong EPLL rate getting on setup clocks Seungwhan Youn
2010-10-12 11:37 ` Seungwhan Youn
2010-10-12 11:42 ` [PATCH v2 3/6] ARM: S5PV210: Add EPLL clock operations Seungwhan Youn
2010-10-12 11:42 ` Seungwhan Youn
2010-10-13 8:08 ` Kukjin Kim
2010-10-13 8:08 ` Kukjin Kim
2010-10-12 11:46 ` [PATCH v2 4/6] ARM: S5P: Add EPLL rate change warning Seungwhan Youn
2010-10-12 11:46 ` Seungwhan Youn
2010-10-13 7:55 ` Kukjin Kim
2010-10-13 7:55 ` Kukjin Kim
2010-10-13 8:09 ` Mark Brown [this message]
2010-10-13 8:09 ` Mark Brown
2010-10-13 8:21 ` Kukjin Kim
2010-10-13 8:21 ` Kukjin Kim
2010-10-13 8:25 ` Mark Brown
2010-10-13 8:25 ` Mark Brown
2010-10-12 11:51 ` [PATCH v2 5/6] ASoC: SAMSUNG: Add S/PDIF CPU driver Seungwhan Youn
2010-10-12 11:51 ` Seungwhan Youn
2010-10-15 10:05 ` Mark Brown
2010-10-15 10:05 ` Mark Brown
2010-10-16 4:01 ` Jassi Brar
2010-10-16 4:01 ` [alsa-devel] " Jassi Brar
2010-10-12 11:58 ` [PATCH v2 6/6] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio Seungwhan Youn
2010-10-12 11:58 ` Seungwhan Youn
2010-10-13 6:10 ` [alsa-devel] [PATCH v2 0/6] Add S/PDIF common driver for Samsung SoCs Jassi Brar
2010-10-13 6:10 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013080902.GA6424@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=jassi.brar@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.